LDB initialization.

[gmarco]

I was used to have tekability as my default LDB durability feeder.
Tekability also put the durability value inside the char frame slots. It is a nice features, but:
1) I don't use so much because I usually have autorepair and so I often repair all the items.
2) it conflicts with other addon that write on the same char slots :-)

So I decided to write my minimalist LDB durability feeder (mydurability). It does only the LDB part and show the minimum durability value.

Now the question after all the p.r things :-)

I used this code:

local ldb = LibStub:GetLibrary("LibDataBroker-1.1")
local dataobj = ldb:NewDataObject("MyDurability", {
    type = "data source",
    icon = "Interface\\Minimap\\Tracking\\Repair",
    text = "100%",
})

but I don't include external libraries to my addon itself thinking that these libraries ( es: LibDataBroker-1.1 and CallbackHandler-1.0.lua ) should be provided by the LDB display manager.

Is this a correct assumption ?

P.s.
The addon works fine ... :-)

The code for any welcome review is:

local ADDON = ...
 
local math_min = math.min
local string_format = string.format
local prgname = "mydurability"
local perc
local format_color = "|cff%02x%02x%02x%s"
 
local slots = {
   "HeadSlot",
   "ShoulderSlot",
   "ChestSlot",
   "WristSlot",
   "HandsSlot",
   "WaistSlot",
   "LegsSlot",
   "FeetSlot",
   "MainHandSlot",
   "SecondaryHandSlot",
}
 
local text_color = {
    {0,1,0},
    {1,1,0},
    {1,0.5,0},
    {1,0,0},
}
 
local ldb = LibStub:GetLibrary("LibDataBroker-1.1")
local dataobj = ldb:NewDataObject("MyDurability", {
    type = "data source",
    icon = "Interface\\Minimap\\Tracking\\Repair",
    text = "100%",
})
 
local frame_md = CreateFrame("Frame", ADDON.."_LDB")
frame_md:RegisterEvent("UPDATE_INVENTORY_DURABILITY")
 
frame_md:SetScript("OnEvent", function(self, event, ...)
    
    local mindurability = 1
 
    for i=1, #slots do
       local slotid = GetInventorySlotInfo(slots[i])
       local durability, maxdurability = GetInventoryItemDurability(slotid)  
       if durability and maxdurability and maxdurability ~= 0 then
          mindurability = math_min(durability/maxdurability, mindurability)       
       end 
    end 
    
    if     mindurability >= 0  and  mindurability < 0.25   then perc = 4
    elseif mindurability >= 0.25 and  mindurability < 0.50   then perc = 3
    elseif mindurability >= 0.50 and  mindurability < 0.75   then perc = 2
    elseif mindurability >= 0.75 and mindurability <= 1 then perc = 1
    end
    
    dataobj.text = string_format(format_color, text_color[perc][1]*255, text_color[perc][2]*255, text_color[perc][3]*255, string_format("%d%%",mindurability*100)).."|r"
 
end
)

Thanks anyone for attention

[gmarco]

A little bit more complete :-)

local ADDON = ...
 
local math_min = math.min
local string_format = string.format
local string_gsub = string.gsub
local table_insert = table.insert
local prgname = "mydurability"
local idx, perc
local format_color = "|cff%02x%02x%02x%s"
 
local durabilities = {}
 
local slots = {
   "HeadSlot",
   "ShoulderSlot",
   "ChestSlot",
   "WristSlot",
   "HandsSlot",
   "WaistSlot",
   "LegsSlot",
   "FeetSlot",
   "MainHandSlot",
   "SecondaryHandSlot",
}
 
local text_color = {
    {0,1,0},
    {1,1,0},
    {1,0.5,0},
    {1,0,0},
}
 
local ldb = LibStub:GetLibrary("LibDataBroker-1.1")
local dataobj = ldb:NewDataObject("MyDurability", {
    type = "data source",
    icon = "Interface\\Minimap\\Tracking\\Repair",
    text = "100%",
})
 
local frame_md = CreateFrame("Frame", ADDON.."_LDB")
frame_md:RegisterEvent("UPDATE_INVENTORY_DURABILITY")
frame_md:SetScript("OnEvent", function(self, event, ...)
    
    local mindurability = 1
    durabilities = {}
    
    for idx=1, #slots do
        local slotid = GetInventorySlotInfo(slots[idx])
        local durability, maxdurability = GetInventoryItemDurability(slotid)  
        if durability and maxdurability and maxdurability ~= 0 then 
            table_insert(durabilities, tostring(string_format("%d", (durability/maxdurability)*100)))
            mindurability = math_min(durability/maxdurability, mindurability)         
        end 
    end 
    
    if     mindurability >= 0  and  mindurability < 0.25   then perc = 4
    elseif mindurability >= 0.25 and  mindurability < 0.50   then perc = 3
    elseif mindurability >= 0.50 and  mindurability < 0.75   then perc = 2
    elseif mindurability >= 0.75 and mindurability <= 1 then perc = 1
    end
    
    dataobj.text = string_format(format_color, text_color[perc][1]*255, text_color[perc][2]*255, text_color[perc][3]*255, string_format("%d%%",mindurability*100)).."|r"
 
end
)
 
function dataobj:OnEnter()
    GameTooltip:SetOwner(self, "ANCHOR_NONE")
    GameTooltip:SetPoint("TOPLEFT", self, "BOTTOMLEFT")
    GameTooltip:ClearLines()
    dataobj.OnTooltipShow(GameTooltip)
    GameTooltip:Show()
end
 
function dataobj:OnTooltipShow()
    -- GameTooltip:AddLine(prgname .. " v" .. GetAddOnMetadata(prgname, "Version"))
    GameTooltip:AddLine(prgname)
    GameTooltip:AddLine(" ")
    for idx=1, #slots do
        if durabilities[idx] then 
            GameTooltip:AddDoubleLine(string_gsub(slots[idx],"Slot",""), durabilities[idx],1,1,1, 1,1,1)
        end
    end
end
 
function dataobj:OnLeave()
    GameTooltip:Hide()
end

[Rilgamon]

Every library your addon needs should be included or your toc should have them listed as standalone requirements. You cant make sure that your addon is loaded after the broker display addon (I tried it ... thats why my broker addons start with zz_ ).

[gmarco]

Hi Rilgamon,

I imagined this thing, but after a few tries with different broker display (only 2 addons, a display and mine) it always works even if my addon was loaded before.
I am saying this thinking the addon are loaded in alpha order, so MyDurability is loaded before TitanPanel for example :-)

If there is no broker display I have no output (obviusly) but also no error :-)

Btw it is not a problem to include the 3 libs in the toc and in the addon itself ... It was more a curiosity to know how it should be setup :-)

P.s.
I saw your addons a lot of times and I always tried to figure why their name begin with zz_ :-))

Thanks for your reply.

[myrroddin]

Originally Posted by gmarco but I don't include external libraries to my addon itself thinking that these libraries ( es: LibDataBroker-1.1 and CallbackHandler-1.0.lua ) should be provided by the LDB display manager. Is this a correct assumption ?

Incorrect, for two reasons: you are making an assumption that a different author has done his or her job correctly, which by not bundling required libraries, you are not doing your job correctly, thus creating your own problem; the other reason is that if your Broker plugin requires those libraries, then you should include them as standard practice, after all, they are required.

[gmarco]

Originally Posted by myrroddin Incorrect, for two reasons: you are making an assumption that a different author has done his or her job correctly, which by not bundling required libraries, you are not doing your job correctly, thus creating your own problem; the other reason is that if your Broker plugin requires those libraries, then you should include them as standard practice, after all, they are required.

Hi myrroddin,
thanks for the reply. As stated above I already suppose that I should include those libs (and I did in the final addon package as published).

Just to explain why I wrote that question...
My thoughts about not including them were: if my addon need (like all others LDB addons those 3 libs) it should logical that only the broker display load them for all the addons that use the display (it is mandatory otherwhise the addons don't work at all) and those libs too. But as pointed out by Rilgamon it can happens (and surely happens :-) that there is a load order problem. If the display broker is loaded after the addon without libs probably this fails to load.

Btw I have learned that is not important who loads the libs ... the important thing is that those libs will go in memory for all :-)

Thanks again for your answer again.

[ravagernl]

Originally Posted by gmarco Hi myrroddin, thanks for the reply. As stated above I already suppose that I should include those libs (and I did in the final addon package as published). Just to explain why I wrote that question... My thoughts about not including them were: if my addon need (like all others LDB addons those 3 libs) it should logical that only the broker display load them for all the addons that use the display (it is mandatory otherwhise the addons don't work at all) and those libs too. But as pointed out by Rilgamon it can happens (and surely happens :-) that there is a load order problem. If the display broker is loaded after the addon without libs probably this fails to load. Btw I have learned that is not important who loads the libs ... the important thing is that those libs will go in memory for all :-) Thanks again for your answer again.

LibStub makes sure only one copy of every different library stays in memory by using version checking. If a libstub library is loaded, the lib checks if LibStub has the same version or a newer version of the same library. In that case, the script uses the language construct "return" to exit the script, so there is no script being run. This will affect loading times a little, but not by much.

If you include a LibStub library, you have to set the library in the OptDeps field in the toc when the library can be installed standalone (like people downloading Ace libraries through the curse client). This way, you can make sure the standalone library is not being loaded after your addon.

More info: http://www.wowace.com/addons/libstub/

This is why both data source display addons and data source addons should both include LibDataBroker.

[gmarco]

After having understood the library problem I'd like to ask another thing if possible.

I am doing 2 different for cycle, one to find the min durability and one to fill the gametooltip.

I have tried to use only a cycle in this way:

for idx=1, #slots do
 
        local slotid = GetInventorySlotInfo(slots[idx])
 
        local durability, maxdurability = GetInventoryItemDurability(slotid)  
 
        if durability and maxdurability and maxdurability ~= 0 then 
           
            GameTooltip:AddDoubleLine(string_gsub(slots[idx],"Slot",""), tostring(string_format("%d", (durability/maxdurability)*100)))
            -- table_insert(durabilities, tostring(string_format("%d", (durability/maxdurability)*100)))
 
            mindurability = math_min(durability/maxdurability, mindurability)         
 
        end 
 
    end 
 
    
 
    if     mindurability >= 0  and  mindurability < 0.25   then perc = 4
 
    elseif mindurability >= 0.25 and  mindurability < 0.50   then perc = 3
 
    elseif mindurability >= 0.50 and  mindurability < 0.75   then perc = 2
 
    elseif mindurability >= 0.75 and mindurability <= 1 then perc = 1
 
    end
 
    
 
    dataobj.text = string_format(format_color, text_color[perc][1]*255, text_color[perc][2]*255, text_color[perc][3]*255, string_format("%d%%",mindurability*100)).."|r"

to fill the gametooltip while I am finding the min value, thinking that I can fill the tooltip and later only call the hide and show to manage it on the enter/leave event.

But it does not work and so I found the solution to fill a table of durabilities while looking for the min durability cycle and then used another cycle on the slots and durabilities table to fill the tooltip on event.

Any clues ?

Thanks very much to everyone for attention.

[Phanx]

Your one-loop method does not work because the GameTooltip is used by many addons and many parts of the default UI. Every time something else shows the GameTooltip, its previous contents are erased, so you cannot add something to the tooltip and expect it to still be there 5 minutes later after the tooltip has been shown and hidden 742 times for units, items, quests, spells, and dozens of other things.

However, since the tooltip is not shown frequently, and is probably never shown in speed-critical situations, I wouldn't even bother with keeping a table of durability values; just ask for them again when the user requests a tooltip.

Here is a 90-second strip-down of tekability that only does the Broker stuff:

local SLOTIDS, SLOTS = {}, { "Head", "Shoulder", "Chest", "Waist", "Legs", "Feet", "Wrist", "Hands", "MainHand", "SecondaryHand" }
for _, slot in pairs(SLOTS) do
	SLOTIDS[slot] = GetInventorySlotInfo(slot .. "Slot")
end

local dataobj = LibStub("LibDataBroker-1.1"):NewDataObject("Durability", {
	type = "data source",
	icon = "Interface\\Minimap\\Tracking\\Repair",
	text = "100%",
	OnTooltipShow = function(tooltip)
		tooltip:AddLine("Durability", 1, 1, 1)
		for slot, id in pairs(SLOTIDS) do
			local v1, v2 = GetInventoryItemDurability(id)
			if v1 and v2 and v2 ~= 0 then
				local val = string.format("%d%%", v1/v2*100)
				tooltip:AddDoubleLine(slot, val, nil, nil, nil, GetGradientColor(v1 / v2))
			end
		end
		tooltip:Show()
	end,
})

local function GetGradientColor(perc)
	local relperc = perc * 2 % 1
	if perc <= 0 then
		return 1, 0, 0
	elseif perc < 0.5 then
		return 1, relperc, 0
	elseif perc == 0.5 then
		return 1, 1, 0
	elseif perc < 1.0 then
		return 1 - relperc, 1, 0
	else
		return 0, 1, 0
	end
end

local frame = CreateFrame("Frame")
frame:RegisterEvent("UPDATE_INVENTORY_DURABILITY")
frame:SetScript("OnEvent", function()
	local min = 1
	for _, slot in ipairs(SLOTDS) do
		local v1, v2 = GetInventoryItemDurability(SLOTIDS[slot])
		if v1 and v2 and v2 ~= 0 then
			min = math.min(v1/v2, min)
		end
	end

	local r, g, b = GetGradientColor(min)
	dataobj.text = string.format("|cff%02x%02x%02x%d%%", r * 255, g * 255, b * 255, min * 100)
end

[gmarco]

Originally Posted by Phanx Your one-loop method does not work because the GameTooltip is used by many addons and many parts of the default UI.

Aargh ... and I that I thought it was only mine :-)

Btw thanks again Phanx. You are amazing as always ... now I'll check your code and try to use it on my addon to perfect it.