Finding Mobs in fight and retrieving threat info

[duelle]

Hello,

I'm quite new to WoW-Lua-Programming and want to learn the rest of it "by doing".
I'm a part-time tank and would like to develop an addon that shows me a list of mobs that attack a party or raid member that is no tank.
So I can see whether there are untanked mobs.

I searched the WoW-API but did not find any function that can return me a list of mobs in fight.

Afterwards I need to retrieve threat information for each of them.
So far I found just a function that can give me aggro information if the mob is in my target/focus or so.

Could you give me any hints to solve those problems?

Thank you for your help!

Greetz
duelle

[ravagernl]

What you might do is scan for the GUID when you mouseover or target a mob (and/or when your partymembers target a mob), check if it has threat from someone in your party, and add it to a table.

You can use the UNIT_DIED subevent in COMBAT_LOG_EVENT_UNFILTERED to see when a mob dies.

Or you might like to try out the addon MagicTargets(http://wow.curse.com/downloads/wow-a...c-targets.aspx).

[duelle]

Thank you for the fast reply.

Assuming one mob was "forgotten" by the tank and attacks a healer because of heal aggro. If nobody targets this mob it would never be in the list derived from targets/focuses/mouseovers isn't it?

Is there another way to find the mobs that are in fight?
Perhaps via the combat log or another WoW-API function?

In what extent could I use the UNIT_DIED event for that addon?
When it is dead I don't want to care about it or am I misunderstanding you?

[ravagernl]

When the mob is dead, you need to remove it from the list of mobs that you are tracking.

You can indeed find out about a mob attacking your healer via the combat log. Just see if the source GUID is not in your party and the destination GUID is in your party.

There's 2 functions to query for threat:
http://www.wowwiki.com/API_UnitThreatSituation
http://www.wowwiki.com/API_UnitDetailedThreatSituation

[duelle]

Originally Posted by mrruben5 When the mob is dead, you need to remove it from the list of mobs that you are tracking.

That's for sure a very good point - didn't mention that yet^^

Originally Posted by mrruben5 You can indeed find out about a mob attacking your healer via the combat log. Just see if the source GUID is not in your party and the destination GUID is in your party. There's 2 functions to query for threat: http://www.wowwiki.com/API_UnitThreatSituation http://www.wowwiki.com/API_UnitDetailedThreatSituation

As far as I understand that, I would parse the combat log for attacks of non-party/raid members on party/raid members ... retrieve their name/id and then check whether they are a tank. If not I would list the attacking mob as not being tanked.
Do you agree ?

Thanks a lot so far!

P.S.: Hope that my english is understandable - if not don't hesitate to ask .. then I'll try my best to explain it more exactly or in other words...

[ravagernl]

Yes

To keep track of party GUID's you can register for the event PARTY_MEMBERS_CHANGED:

local guidtounit = {}
 
function addon:PARTY_MEMBERS_CHANGED()
    wipe(guidtounit)
    guidtounit[UnitGUID('player')] = 'player'
    if UnitExists('pet') do
        guidtounit[UnitGUID('pet')] = 'pet' 
    end
    for i= 1, GetNumPartyMembers() do
        guidtounit[UnitGUID('party'..i)] = 'party'..i
        if UnitExists('party'..i..'pet') do
            guidtounit[UnitGUID('party'..i..'pet')] = 'party'..i..'pet' 
        end
    end
end

Or you could also check using http://wowprogramming.com/docs/api/CombatLog_Object_IsA

[duelle]

Thank you a lot!

That's a great idea to store a list of all raid/group members.
I will play around with those things tomorrow (or later this day )

Just noting it down in here:

• Every time the group changes refresh the [GUID -> unitId] table
• Check the CombatLog for attacks of non-raid members on raid-members (which I luckily now have in a table )
• If the attacked raid-member is not marked as a tank (or whatever gives the raid-member the right to tank a mob^^) add the attacking mob to a list
• Display the list in some way (this will be the last step to take - gui )

Further notes concerning functions I will probably use:

• UnitPlayerOrPetInRaid(uId) -> returns wheter the given uId is a player or pet in raid
• UnitPlayerOrPetInParty(uId) -> same as above for party
• guid = UnitGUID(uId) -> retrieves the GUID for the given unit
• UnitDetailedThreatSituation
• UnitThreatSituation

Gonna go to sleep now ... good night/morning

[ravagernl]

isTank, isHeal, isDPS = UnitGroupRolesAssigned(Unit);

[duelle]

There's one further thing that came to my mind this morning:

Assuming there are two mobs with the same name.
One of them attacks my healer and one myself as tank.
Now my addon would get the guid and the name of the healer-attacking one.

But I can't target a mob via guid isn't it?
So eventually I would target the wrong one if I wrote a frame that allowed me to target the untanked one - because they both have the same name and therefore I can't really distinguish between them.

I thought about creating a list of mobs as I have a list of raid/party members - but that does not solve the problem above.

Which would be the easiest way to check wheter I'm in party or in raid?
Perhaps via the member count?

You gave me the hint

isMatch = CombatLog_Object_IsA(unitFlags, mask)

I understand what it does - but don't understand how to use it yet.
Because I don't really know where to pass it one Combatlog-"Line" it should filter.

[duelle]

Hi,

I started programming the last days.

UPDATE:
The most important functions seem to work - except the slash command which is currently not that important though.

The question from the post before is still open: Can I form a targetting command that uses the guid so I can identify a mob out of multiple mobs with the same name?

The code can of course be optimized a lot ... additionaly I need to add a check whether the attacked unit is tank or not.

Here is the code:

local prefix = "[DX-LostMobs]";
local outputChannel =  "SAY";
 
SLASH_DX_LM_1 = "/lm";
SLASH_DX_LM_2 = "/lostmobs";
 
--SlashCmdList["DX_LOST_MOBS"] = function(msg)
--  print(prefix..msg);
-- end;
 
local LostMobs = {};
guidtounit = {};
guidtomob = {};
untanked = {};
local srcGuid,srcName,tarGuid,tarName;
 
function onEvent(self,event,...)
  local temp,_  = select(2,...);
  if event == "COMBAT_LOG_EVENT_UNFILTERED" then
    if temp == "UNIT_DIED" then
      --return onEvent(self,select(2,...),...);
      print("Some unit died - checking moblist....");
      UnitDied(event,...);
    else
      return ParseCombatLog(select(3,...));
    end;
  elseif event == "PARTY_MEMBERS_CHANGED" then
    return PartyMembersChanged();
  end;
end;
 
function ParseCombatLog(...)
 
  srcGuid,srcName,_,tarGuid,tarName,_ = ...;
  if (not IsRaidOrPartyMember(srcGuid)) and IsRaidOrPartyMember(tarGuid) then
    if not guidtomob[srcGuid] then
      guidtomob[srcGuid] = srcName;
    end;
    print(prefix..srcName.." is attacking "..tarName);
  end;
end;
 
function IsRaidOrPartyMember(id)
  if guidtounit[id] or guidtounit[UnitGUID(id)] then
    return 1;
  else
    return nil;
  end;
end;
 
 
function UnitDied(event,...)
 
  local guid,name,_ = select(6,...);
 
  if not (UnitPlayerOrPetInRaid(guid) or UnitPlayerOrPetInParty(guid)) then
    print(guidtomob);
    tremoveKey(guidtomob,guid);
    print(guidtomob);
  end;
end;
 
 
function PartyMembersChanged()
  print("Something changed within the group!");
  wipe(guidtounit);
  guidtounit[UnitGUID('player')] = 'player';
  if UnitExists('pet') then
      guidtounit[UnitGUID('pet')] = 'pet';
  end;
  for i= 1, GetNumPartyMembers() do
      guidtounit[UnitGUID('party'..i)] = 'party'..i;
      if UnitExists('party'..i..'pet') then
          guidtounit[UnitGUID('party'..i..'pet')] = 'party'..i..'pet';
      end;
  end;
  print(prefix.."Party-Data updated - "..#guidtounit.." Members in list");
end;
 
function tremoveKey(table,key)
  local element = table[key];
  table[key] = nil;
  return element;
end;
 
 
local frame = CreateFrame("Frame");
frame:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED");
frame:RegisterEvent("PARTY_MEMBERS_CHANGED");
frame:SetScript("onEvent",onEvent);