Combat icon for target

andaril · 10-02-12, 03:24 PM

Hello.
I'm using ouf_drk fan update. http://www.wowinterface.com/download...Fanupdate.html
I need to add combat state icon for my target. How to do it with ouf?

I found in wow functions:

Lua Code:

UnitAffectingCombat("unit")

http://www.wowwiki.com/API_UnitAffectingCombat

And in code
/ouf_drk/lib.lua

Lua Code:

--combat icon
    if f.mystyle=="player" then
        f.Combat = h:CreateTexture(nil, 'OVERLAY')
        f.Combat:SetSize(15,15)
        f.Combat:SetTexture('Interface\\CharacterFrame\\UI-StateIcon')
        f.Combat:SetTexCoord(0.58, 0.90, 0.08, 0.41)
        f.Combat:SetPoint('BOTTOMRIGHT', 7, -7)
    end

So i think all i need is to add some code like:

Lua Code:

--combat icon
    if f.mystyle=="target" and UnitAffectingCombat( %UNIT% ) then
        f.Combat = h:CreateTexture(nil, 'OVERLAY')
        f.Combat:SetSize(15,15)
        f.Combat:SetTexture('Interface\\CharacterFrame\\UI-StateIcon')
        f.Combat:SetTexCoord(0.58, 0.90, 0.08, 0.41)
        f.Combat:SetPoint('BOTTOMRIGHT', 7, -7)
    end

And the question: is what i should put into %UNIT%?
It's new for me and i don't know where ouf/ouf_layout stores "unit" and how to get it.
I tried some variants, but no results. And search didn't give me results too, mb cos of my bad english. ;(

Thanks for help.

Phanx · 10-02-12, 04:18 PM

No. If you add a UnitAffectingCombat check there, you will never see a Combat icon, because the frame is created before anyone is in combat, so the check will prevent the Combat icon from being created in the first place.

All you need to do is create the icon; oUF will handle hiding it and showing it when needed. Just use the first (original) code block, but change:

Code:

if f.mystyle=="player" then

to:

Code:

if f.mystyle=="player" or f.mystyle=="target" then

andaril · 10-02-12, 05:09 PM

Originally Posted by Phanx

All you need to do is create the icon; oUF will handle hiding it and showing it when needed. Just use the first (original) code block, but change

It was my first move when i found that code.

But it isn't working for me at all. Icon for target is displaying always, doesn't matter in combat target or no. ;(

API call ( UnitAffectingCombat ) i found in xperl when looking for their implementation of this. And i thought its right way.

Also in ouf framework
ouf/elements/combat.lua
hardcoded

Code:

UnitAffectingCombat('player')

and all displaying goes only when unit == 'player'

Mb i need to write some plugin or something? If "yes" can u give some guide links or examples?
Thanks for ur time.

Phanx · 10-02-12, 07:43 PM

Actually upon further inspection it appears that oUF simply doesn't support a Combat element for anything other than the player unit, so you'll have to handle it yourself. Take the original code:

Code:

--combat icon
    if f.mystyle=="player" then
        f.Combat = h:CreateTexture(nil, 'OVERLAY')
        f.Combat:SetSize(15,15)
        f.Combat:SetTexture('Interface\\CharacterFrame\\UI-StateIcon')
        f.Combat:SetTexCoord(0.58, 0.90, 0.08, 0.41)
        f.Combat:SetPoint('BOTTOMRIGHT', 7, -7)
    end

And replace the "end" at the end with this:

Code:

    elseif f.mystyle == "target" then
        local combat = CreateFrame("Frame", nil, h)
        combat:SetSize(15, 15)
        combat:SetPoint("BOTTOMRIGHT", 7, -7)
        f.CombatIcon = combat

        local combaticon = combat:CreateTexture(nil, "ARTWORK")
        combaticon:SetAllPoints(true)
        combaticon:SetTexture("Interface\\CharacterFrame\\UI-StateIcon")
        combaticon:SetTexCoord(0.58, 0.9, 0.08, 0.41)
        combat.icon = combaticon

        combat.__owner = f
        combat:SetScript("OnUpdate", function(self)
            local unit = self.__owner.unit
            if unit and UnitAffectingCombat(unit) then
                self.icon:Show()
            else
                self.icon:Hide()
            end
        end)
    end

andaril · 10-03-12, 03:25 AM

It works.
Thank you for doing all work for me.