SecureHandlerState

[SDPhantom]

I ended up downloading the entire addon to see what I can do with it. After many hours of testing I think I came up with a solution. (Modified files temporarily attached)



The first thing I ended up doing was to stop PlayerPet:UpdatePortrait() from reloading the model if it's already being displayed. This should stop the portrait jitter. The optional force arg forces the update to happen and is for use with the UNIT_PORTRAIT_UPDATE event.

function PlayerPet:UpdatePortrait(force)
    local unit = self.frame.unit
    local guid = UnitGUID(unit)
 
    local texture = self.frame.portrait.texture.texture
    local model = self.frame.portrait.model
 
    if UnitIsVisible(unit) then
        texture:Hide()
        if force or guid ~= model.guid or not model:IsShown() or model:GetModel() == "" then
            model:ClearModel()
            model:SetUnit(unit)
            model:SetPortraitZoom(1)
            model:Show()
            model.guid = guid
        end
    else
        model:Hide()
        SetPortraitTexture(texture, unit)
        texture:Show()
    end
end

While RegisterAttributeDriver() is being used for both UnitFrames now, to keep things simple, the OnAttributeChanged script was removed entirely. (It was firing at the wrong time anyway.)



I ended up using UNIT_PET to synchronize the swapping of the player and pet frames. The quirk about this is the vehicle UnitID doesn't work, but you can still access the vehicle data using the pet UnitID. Fortunately, UnitHasVehicleUI() does seem to return the correct state here for both entering and exiting a vehicle. None of the UNIT_*_VEHICLE events are used anymore.

Player.lua

function Player:UNIT_PET()
    self.frame.unit = UnitHasVehicleUI("player") and "pet" or "player"
    self:UpdateDisplay()
end

PlayerPet.lua

function PlayerPet:UNIT_PET(...)
    self.frame.unit = UnitHasVehicleUI("player") and "player" or "pet"
    self:UpdateDisplay()
end

Edit: Attachments deleted, see later posts.

[Resike]

Holy shit dude, thats exactly what i wanted to be like. Thanks a lot.

[Resike]

I have some issues again.
While it's working prefectly when you enter/exit vehilces with a summoned pet. Now it doesn't work properly when you don't have a pet.

[SDPhantom]

If you're referring to the fraction of a second that the unitframe appears blank, it looks like that's the UnitWatchFrame stepping in when it detects the vehicle as a pet. It was probably there before, but not as noticeable. Technically, the UnitWatchFrame is supposed to check the OnUpdate after we update our frame. I'm not sure how it gets in before that happens.

With more testing, I've been getting varied results between the rare occasion where the pair of UnitFrames got stuck on exit and showed up blank, to the issue noted above, and many times running with perfect timing (no issues at all).

[Resike]

Originally Posted by SDPhantom If you're referring to the fraction of a second that the unitframe appears blank, it looks like that's the UnitWatchFrame stepping in when it detects the vehicle as a pet. It was probably there before, but not as noticeable. Technically, the UnitWatchFrame is supposed to check the OnUpdate after we update our frame. I'm not sure how it gets in before that happens. With more testing, I've been getting varied results between the rare occasion where the pair of UnitFrames got stuck on exit and showed up blank, to the issue noted above, and many times running with perfect timing (no issues at all).

Nah, i found some other type of vehicles which does not triggger the UNIT_PET events at the right time, reporting UnitHasVehicleUI("player") to false and the whole swap does not occour.

So i'm not sure how reliable this UNIT_PET method is. However i could not came up with a better soution i tried almost all the vehicle releated events.

https://www.youtube.com/watch?v=M_O3JryZVBQ

[SDPhantom]

How do these work? They use a more brute force method that piggybacks on RegisterAttributeDriver() and reacts whenever the driver does so. This is because it not only triggers on UNIT_PET, but every 200ms as well. I also added additional conditions to the driver that makes it delay the trigger until there is unit information that the display functions can act on. Apparently, the [vehicleui] condition can trigger before or after UNIT_PET.



Edit: I had to replace all the instances of self.frame.unit to use SecureButton_GetUnit(self.frame) instead. My previous attachment to this post replaced the UNIT_PET event with an update from the frame's OnAttributeChanged script. This worked well when you didn't have a pet, but showed the pet's stats instead of the vehicle if there was one out. The new hybrid method uses the attribute driver to determine the unit shown and uses UNIT_PET to make sure the display code gets the vehicle if the pet unit swaps after the attribute driver changes units.

<Attachments removed to save space>