macro for Sha / Galleon lock

[Voxxel]

Yea, seems we don't need to track Oondasta quest at all since it seems the boss works as the Pre-nerfed Galleon where you were able to loot anytime you find him (because it could happen only once or twice a week)

[p3lim]

If we're really minimalizing something this small

for name, id in pairs{
    Oondasta = 32519,
    Galleon = 32098,
    Nalak = 32518,
    Sha = 32099
} do
    print(name, IsQuestFlaggedCompleted(id))
end

/run for k,v in pairs{Oondasta=32519,Galleon=32098,Nalak=32518,Sha=32099} do print(k,IsQuestFlaggedCompleted(v)) end

Returns true or nil based on completion status, good enough for many.

[Voxxel]

Ok, I was wrong, you cannot loot Oondasta more than once a week (despite its loong respawn). Moreover, you're not allowed to use your mogu coins more than once a week.

According to this, the completition quest should be marked as completed but it doens't work actually. Maybe a wrong quest?

[Phanx]

Wowhead only lists 4 weekly Short-Supply Reward quests which correspond to the 4 weekly world bosses. I'd guess the quest itself is just buggy.

[Rilgamon]

Originally Posted by Phanx Wowhead only lists 4 weekly Short-Supply Reward quests which correspond to the 4 weekly world bosses. I'd guess the quest itself is just buggy.

Yes, Delaene reportet that killing Nalak marks both quests in my addon and I was able to check it tonight. So its blizz's fault.

[Rilgamon]

http://us.battle.net/wow/en/forum/topic/8728854089#3

We are aware of the request and looking to add a way for characters to track which world boss had already been defeated in a given week.

Why not just fix the weekly quests in question?

[Phanx]

In addition to fixing the quest, they should just add these as raid locks so they show up on /raidinfo and the calendar. Doesn't seem like it would be too difficult.

[Voxxel]

hello again,

I'm using an extended veriosn of that beautiful color-coded macro made by Phanx, however I can't realize how can I set up the order of the list. Here is my extended code:

/run for k, v in pairs({ Galleon = 32098, Chest = 32609, Rares = 32610, Room_key = 32626, Nalak = 32518, Oondasta = 32519, Sha = 32099}) do print(format("%s: %s", k, IsQuestFlaggedCompleted(v) and "\124cff00ff00Yes\124r" or "\124cffff0000No\124r")) end

I tried to move them forth and back but the list order does not follow. It would be fine if it could print them in the following order:

1. Galleon
2. Sha
3. Chest
4. Rares
5. Room_key
6. Nalak
7. Oondasta

[Seerah]

You can't. This is because it is set up as a dictionary style table with string keys rather than numerical indexes.

[Dridzt]

You can try this.

/run for k,v in ipairs({{32098,"Galleon"},{32099,"Sha"},{32609,"Chest"},{32610,"Rares"},{32626,"Key"},{32518,"Nalak"},{32519,"Oondasta"}}) do print(format("%d.%s:%s",k,v[2],IsQuestFlaggedCompleted(v[1]) and "\124cff00ff00Yes" or "\124cffff0000No"))end

[Voxxel]

Originally Posted by Dridzt You can try this. /run for k,v in ipairs({{32098,"Galleon"},{32099,"Sha"},{32609,"Chest"},{32610,"Rares"},{32626,"Key"},{32518,"Nalak"},{32519,"Oondasta"}}) do print(format("%d.%s:%s",k,v[2],IsQuestFlaggedCompleted(v[1]) and "\124cff00ff00Yes" or "\124cffff0000No"))end

Wow! You're my man, Dridzt! Thanks!

[ravagernl]

Yay! 8 new tables each time that macro runs

[Phanx]

Here is a cleaner version of that that only creates one table instead of eight:

/run local t={"Galleon",32098,"Sha",32099,"Chest",32609,"Rares",32610,"RoomKey",32626,"Nalak",32518,"Oondasta",32519}for i=1,#t-1,2 do print(t[i],IsQuestFlaggedCompleted(t[i+1])and "\124cff00ff00Yes" or "\124cffff0000No")end

[Rilgamon]

Someone asked me to include those quests (key,chest,roll) into zz_Worldboss. So I tried to find an event that would indicate when one of those hidden quests is marked.

I tried "QUEST_AUTOCOMPLETE" and "QUEST_LOG_UPDATE" both dont fire. I hate the idea to have it running in an onupdate.

I tested with the chest which is easy enough to find on my empty realm. The key-quest was marked right the moment I looted it from the chest and the chest itself took a few seconds before it was marked. But cant find the right event for this

[Phanx]

Assuming you are displaying this information in a Broker plugin's tooltip, why do you need an event? Just query IsQuestFlaggedCompleted(id) when the user requests the tooltip. If you really think querying again on each tooltip request is too expensive, you can cache the state for the rest of the session after the first time.

[Rilgamon]

In my broker I display the information of all chars. So it would be helpfull when the info is stored the moment it's known to make sure the addon has the right data when the player switches to another char. For now I've added an 5 seconds ooc-onupdate additionally to registering PLAYER_LOGOUT.

local function update()
    for questId, questData in pairs(db['quests']) do
        if(questData['minlevel'] <= db['char_db'][player]['level']) then
            db['char_db'][player][questId] = IsQuestFlaggedCompleted(questId) and true or nil
        end
    end
end
local function onupdate(self,dt)
    self['elapsed'] = (self['elapsed'] or 0) - dt
    if(self['elapsed'] < 0) then
        self['elapsed'] = 5
        update()
    end
end
local function event(self,evnt,...)
    print(evnt)
    print(...)
    if(evnt == "PLAYER_REGEN_DISABLED") then
        self:SetScript("OnUpdate", nil)
    elseif(evnt == "PLAYER_REGEN_ENABLED") then
        self:SetScript("OnUpdate", onupdate)
    else
        update()
    end
end

[Tonyleila]

I love this macro its not containing the rar mobs @ Isel of thunder but If you were there to get the key guess u have killed a rar mob. Also one questflag that missing in your macros is the new 5.3 Weekly in the Barrens:

/run for k, v in pairs({ Galleon=32098, Sha=32099, Nalak=32518, Oon=32519, Champ=32641, Key=32626, Barrens=32862}) do print(format("%s: %s", k, IsQuestFlaggedCompleted(v) and "\124cff00ff00Yes" or "\124cffff0000No")) end

[oscarucb]

SavedInstances shows the world boss kills, weekly quests, raid lockouts and other useful information for ALL of your toons.
Better than any macro because you don't have to relog to see your alts..

[Rilgamon]

To keep this macro alive

37460 - Drov the Ruiner
37462 - Tarlna the Ageless
37464 - Rukhmar

[Tonyleila]

Originally Posted by Rilgamon To keep this macro alive 37460 - Drov the Ruiner 37462 - Tarlna the Ageless 37464 - Rukhmar

Thanks the new macro is now this, it still includes all bosses that drop mounts:

/run for k, v in pairs({ Galleon=32098,Sha=32099,Nalak=32518,Oondasta=32519,Drov=37460,Tarlna=37462,Rukhmar=37464}) do print(format("%s: %s", k, IsQuestFlaggedCompleted(v) and "\124cff00ff00Yes" or "\124cffff0000No")) end