Chat Bubble help

[cokedrivers]

Hello,

I have found a code I'm trying to get to my liking and need some assistance.

Below is the current code i'm using I have everything set how I would like it except the Senders name, I can get the "player" names to be class color but I cannot seem to get the NPC's name to change to the reaction they have against me (ie Friendly hated and so on).

Current Code:

local events = {
    CHAT_MSG_SAY = 'chatBubbles',
    CHAT_MSG_YELL = 'chatBubbles',
    CHAT_MSG_PARTY = 'chatBubblesParty',
    CHAT_MSG_PARTY_LEADER = 'chatBubblesParty',
    CHAT_MSG_MONSTER_SAY = 'chatBubbles',
    CHAT_MSG_MONSTER_YELL = 'chatBubbles',
    CHAT_MSG_MONSTER_PARTY = 'chatBubblesParty',
}
 
local function SkinFrame(frame)
    for i = 1, select('#', frame:GetRegions()) do
        local region = select(i, frame:GetRegions())
        if (region:GetObjectType() == 'FontString') then
            frame.text = region
        else
            region:Hide()
        end
    end
 
    frame.text:SetFontObject('SystemFont_Small')
    frame.text:SetJustifyH('LEFT')
 
    frame:ClearAllPoints()
    frame:SetPoint('TOPLEFT', frame.text, -7, 25)
    frame:SetPoint('BOTTOMRIGHT', frame.text, 7, -7)
    frame:SetBackdrop({
        bgFile = 'Interface\\Tooltips\\UI-Tooltip-Background',
        edgeFile = 'Interface\\Tooltips\\UI-Tooltip-Border',
        tileSize = 16,
        edgeSize = 12,
        insets = {left=3, right=3, top=3, bottom=3},
    })
    frame:SetBackdropColor(0, 0, 0, 1)
    local _, class = UnitClass("player")
    local color = RAID_CLASS_COLORS[class] or { r = 0.5, g = 0.5, b = 0.5 }
    frame:SetBackdropBorderColor(color.r * 255, color.g * 255, color.b * 255)
 
    frame.sender = frame:CreateFontString(nil, 'OVERLAY', 'NumberFont_Outline_Med')
    frame.sender:SetPoint('BOTTOMLEFT', frame.text, 'TOPLEFT', 0, 4)
    frame.sender:SetJustifyH('LEFT')
 
    frame:HookScript('OnHide', function()
        frame.inUse = false
    end)
end
 
local function UpdateFrame(frame, guid, name)
    if (not frame.text) then
        SkinFrame(frame)
    end
    frame.inUse = true
 
    local class
    if (guid ~= nil and guid ~= '') then
        _, class, _, _, _, _ = GetPlayerInfoByGUID(guid)
    end
    
    if (name) then
        local color = RAID_CLASS_COLORS[class] or { r = 0.75, g = 0.75, b = 0.75 }
        frame.sender:SetText(('|cFF%2x%2x%2x%s|r'):format(color.r*255, color.g*255, color.b*255, name))
        if frame.text:GetWidth() < frame.sender:GetWidth() then
            frame.text:SetWidth(frame.sender:GetWidth())
        end
    end
end
 
local function FindFrame(msg)
    for i = 1, WorldFrame:GetNumChildren() do
        local frame = select(i, WorldFrame:GetChildren())
        if (not frame:GetName() and not frame.inUse) then
            for i = 1, select('#', frame:GetRegions()) do
                local region = select(i, frame:GetRegions())
                if region:GetObjectType() == 'FontString' and region:GetText() == msg then
                    return frame
                end
            end
        end
    end
end
 
local ChatBubbleFrame = CreateFrame('Frame')
for event, cvar in pairs(events) do
    ChatBubbleFrame:RegisterEvent(event)
end
 
ChatBubbleFrame:SetScript('OnEvent', function(self, event, msg, sender, _, _, _, _, _, _, _, _, _, guid)
    if (GetCVarBool(events[event])) then
        ChatBubbleFrame.elapsed = 0
        ChatBubbleFrame:SetScript('OnUpdate', function(self, elapsed)
            self.elapsed = self.elapsed + elapsed
            local frame = FindFrame(msg)
            if (frame or self.elapsed > 0.3) then
                ChatBubbleFrame:SetScript('OnUpdate', nil)
                if (frame) then
                    UpdateFrame(frame, guid, sender)
                end
            end
        end)
    end
end)

I have tried:

local reaction = UnitReaction(unit, 'player')
 
        if (reaction) then
            r = FACTION_BAR_COLORS[reaction].r
            g = FACTION_BAR_COLORS[reaction].g
            b = FACTION_BAR_COLORS[reaction].b
        else

But I keep getting an error that says unit is nil.

Any help on this would be great.

Thanks Coke

[SDPhantom]

Where are you getting a UnitID from? I can't find it anywhere in the code.

[cokedrivers]

Originally Posted by SDPhantom Where are you getting a UnitID from? I can't find it anywhere in the code.

I'm not sure where to look for the UnitID of a chat message I have been searching all morning and can not find anything that will help me get the senders reaction to the player.

I guess ill just have to stick with the Class color for players and grey for everything else.

Thanks
Coke

[Seerah]

Have you had a look at BubbleBobble? http://www.wowinterface.com/download...bleBobble.html (I don't remember if it has what you're looking for)
/edit: it's also 5 years old.

[ObbleYeah]

http://www.wowinterface.com/forums/s...8&postcount=15

[cokedrivers]

Ok so I think I'm getting closer..

I know this may seem long and drawn out but seems the only choice I have at the moment...

Here is the code I'm trying

local function UpdateFrame(frame, guid, name)
    if (not frame.text) then
        SkinFrame(frame)
    end
    frame.inUse = true

    local class
    if (guid ~= nil and guid ~= '') then
        _, class, _, _, _, _ = GetPlayerInfoByGUID(guid)
    end

	CUSTOM_FACTION_BAR_COLORS = {
		[1] = {r = 1, g = 0, b = 0},
		[2] = {r = 1, g = 0, b = 0},
		[3] = {r = 1, g = 1, b = 0},
		[4] = {r = 1, g = 1, b = 0},
		[5] = {r = 0, g = 1, b = 0},
		[6] = {r = 0, g = 1, b = 0},
		[7] = {r = 0, g = 1, b = 0},
		[8] = {r = 0, g = 1, b = 0},
	}	
	
	-- Find Unit Types
	for _, UNITZ in pairs ({
	
		-- Main Units
		player, pet, vehicle, target, focus, mouseover, none, npc,
		
		-- Party Members
		party1, party2, party3, party4,
		
		-- Party Pets
		partypet1, partypet2, partypet3, partypet4, 
		
		-- Raid Players
		raid1, raid2, raid3, raid4, raid5, raid6, raid7, raid8, raid9, raid10,
		raid11, raid12, raid13, raid14, raid15, raid16, raid17, raid18, raid19, raid20,
		raid21, raid22, raid23, raid24, raid25, raid26, raid27, raid28, raid29, raid30,
		raid31, raid32, raid33, raid34, raid35, raid36, raid37, raid38, raid39, raid40,
		
		-- Raid Player Pets
		raidpet1, raidpet2, raidpet3, raidpet4, raidpet5, raidpet6, raidpet7, raidpet8, raidpet9, raidpet10,
		raidpet11, raidpet12, raidpet13, raidpet14, raidpet15, raidpet16, raidpet17, raidpet18, raidpet19, raidpet20,
		raidpet21, raidpet22, raidpet23, raidpet24, raidpet25, raidpet26, raidpet27, raidpet28, raidpet29, raidpet30,
		raidpet31, raidpet32, raidpet33, raidpet34, raidpet35, raidpet36, raidpet37, raidpet38, raidpet39, raidpet40,

		-- Bosses
		boss1, boss2, boss3, boss4, boss5,
		
		-- Arena Players
		arena1, arena2, arena3, arena4, arena5,
		
	}) do
		reaction = UnitReaction(UNITZ, "player")
	end
	
	if (name) then
		local color = RAID_CLASS_COLORS[class] or CUSTOM_FACTION_BAR_COLORS[reaction]
		frame.sender:SetText(('|cFF%2x%2x%2x%s|r'):format(color.r * 255, color.g * 255, color.b * 255, name))
		if frame.text:GetWidth() < frame.sender:GetWidth() then
			frame.text:SetWidth(frame.sender:GetWidth())
		end
	end	
end

Now for players again it works fine, but for my NPC in my Garrison I get a color error

Error:

2x cChat\cChat-6.2.3.lua:493: attempt to index local 'color' (a nil value)
cChat\cChat-6.2.3.lua:493: in function <cChat\cChat.lua:435>
cChat\cChat-6.2.3.lua:528: in function <cChat\cChat.lua:522>

Locals:
frame = <unnamed> {
 0 = <userdata>
 text = <unnamed> {
 }
 inUse = true
 sender = <unnamed> {
 }
}
guid = nil
name = "Scout Valdez"
class = nil
color = nil
(*temporary) = <function> defined =[C]:-1
(*temporary) = <unnamed> {
 0 = <userdata>
}
(*temporary) = <function> defined =[C]:-1
(*temporary) = "|cFF%2x%2x%2x%s|r"
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index local 'color' (a nil value)"
SkinFrame = <function> defined @cChat\cChat.lua:400

Line 493 is the local color one

Any ideas?

Coke

[myrroddin]

Throwing darts here, but this might help. Or not LOL.

First, what kind of unit is "UNITZ"? Surely that's a typo...

do
reaction = UnitReaction(UNITZ, "player")
end

Next, since NPCs don't have unitIDs unless you are directly interracting with them, but they do have GUIDs, you might want to sort that out. In other words, if you want to keep the reaction color for an NPC that you are indirectly interracting with (IE target of target, where target == tankPlayer and target'starget == boss), you will need to store or cache that.

local color
-- if a player unitID then ...
color = CUSTOM_CLASS_COLORS[class] or RAID_CLASS_COLORS[class]
-- elseif unitID is an NPC then ...
color = CUSTOM_FACTION_BAR_COLORS[UnitReaction(unitID)] or UnitReaction(unitID)
-- end

[myrroddin]

I was browsing the CHAT_MSG_xx events, and nearly all have a GUID as one of their args. You can then convert the GUID into an unitID if necessary, even NPCs.

About using custom colors: you must check for those first before you use built in colors, for logical reasons. Think about this psuedocode logic:

local _, class = UnitClass("player")
local color = RAID_CLASS_COLORS[class] or CUSTOM_COLORS[class] -- will always find RCC and never CC
local color = CUSTOM_COLORS[class] or RCC[class] -- if CC not found, then check RCC, which is found

The same will go for your custom unit reaction colors. You must check for those first, then built in API.

[Seerah]

Originally Posted by myrroddin First, what kind of unit is "UNITZ"? Surely that's a typo... do reaction = UnitReaction(UNITZ, "player") end

UNITZ is a variable that is assigned a unitID in the pairs loop that line is found in.

[cokedrivers]

Thanks Everyone for the Help but it seems my coding skills suck so I'm just going to stick with what I have gotten to work.

This works for half of what I'm looking for.

local function UpdateFrame(frame, guid, name)
    if (not frame.text) then
        SkinFrame(frame)
    end
    frame.inUse = true

    local class
    if (guid ~= nil and guid ~= '') then
        _, class, _, _, _, _ = GetPlayerInfoByGUID(guid)
    end

	
	if (name) then
		local color = RAID_CLASS_COLORS[class] or {r = 1, g = 1, b = 0.2}
		frame.sender:SetText(('|cFF%2x%2x%2x%s|r'):format(color.r * 255, color.g * 255, color.b * 255, name))
		if frame.text:GetWidth() < frame.sender:GetWidth() then
			frame.text:SetWidth(frame.sender:GetWidth())
		end
	end	
end

Thanks again
Coke