Move the Watch Frame onLoad?

[Mayron]

Hi guys,

I am using this following script on the OnUpdate window in kgPanels to move the Watch Frame:
WatchFrame:SetPoint("TOPRIGHT", "Minimap", "BOTTOMLEFT", 50, -20)

However I usually hate having things on the OnUpdate and try to always avoid it when ever possible. In this case I want to change it to the OnLoad script window because then I can use other Lua scripts in the future to move it when ever needed.

My issue is that if I use the same script on Load instead it does not work. This is because of the loading order I think as it is too quick and Blizzard moves this to its original location so my script does not do anything.

I really do not know where to begin with this, can anyone help or point me in the right direction? Thank you!

[Rainrider]

You could try WatchFrame:SetUserPlaced(true) to prevent Blizzard code from repositioning the frame. You also normally have to call ClearAllPoints() before setting your points. You could also try using OnShow or OnSizeChanged instead of OnLoad.

[Seerah]

Yes, avoid OnUpdate scripts whenever possible.

1. When moving frames, always call :ClearAllPoints() first. (Multiple :SetPoint() calls can be used for one frame to alter its size and anchoring)

2. In my Who Framed Watcher Wabbit addon, I move the WatchFrame after the PLAYER_ENTERING_WORLD event fires. In your OnLoad script put self:RegisterEvent("PLAYER_ENTERING_WORLD" then in your OnEvent script put your code for moving it.

3. As mentioned in #1 above, multiple :SetPoint() calls can influence the anchoring and size of a frame - this is what the WatchFrame does. Once you move it, you may find that it is smaller than you would like (only showing one or two quests, due to it being 40px tall, iirc). You'll then need to call :SetHeight() on the frame with the size you wish it to be.

[Mayron]

No still no use, I think it is just because kgPanels load quicker. Only OnUpdate has any effect

[pelf]

You could register for the ADDON_LOADED event and look for "Blizzard_QuestChoice" (which is the one that has the Watch Frame in it). Once that addon loads, then try moving the frame, and unregister the event.

[Rainrider]

Originally Posted by pelf You could register for the ADDON_LOADED event and look for "Blizzard_QuestChoice" (which is the one that has the Watch Frame in it). Once that addon loads, then try moving the frame, and unregister the event.

That is untrue. The watch frame is handled by WatchFrame.lua/xml.

[Phanx]

Originally Posted by Mayron No still no use, I think it is just because kgPanels load quicker. Only OnUpdate has any effect

It has nothing to do with the load order of anything. The WatchFrame moves because the default UI moves it (see UIParent.lua, lines 2190-2210). Based on the current state of that code, you should be able to prevent the default UI from moving the WatchFrame by calling this, once:

WatchFrame:SetUserPlaced(true)

If that doesn't work, you can always use a simple post-hook:

hooksecurefunc("UIParent_ManageFramePositions", function()
	WatchFrame:ClearAllPoints()
	WatchFrame:SetPoint("TOPRIGHT", "Minimap", "BOTTOMLEFT", 50, -20)
end)

Personally, I avoid the whole problem by just nuking the WatchFrame's ClearAllPoints and SetPoints methods:

local noop = function() end
WatchFrame.ClearAllPoints = noop
WatchFrame.SetPoint = noop

...but that would make it more difficult to move the frame via scripts later.

[pelf]

I see what I did... well, that's the last time I use wowprogramming's FrameXML browser . GitHub is prettier, anyway.

EDIT: What in the world is go-hero.net? I've never seen that one.

[Rainrider]

In order to use SetUserPlaced(true) you have to call WatchFrame:SetMovable(true). To sum it up:

OnLoad script:

self:RegisterEvent("PLAYER_ENTERING_WORLD")

OnEvent script:

WatchFrame:SetMovable(true)
WatchFrame:SetUserPlaced(true)
WatchFrame:SetPoint("TOPRIGHT", Minimap, "BOTTOMLEFT", 50, -20)

You don't have to call ClearAllPoints() as long as you use "TOPRIGHT" as your anchor point, because that's the only anchor point used by Blizzard to position the WatchFrame and the SetPoint call overwrites it.

[Phanx]

You shouldn't need to delay until PLAYER_ENTERING_WORLD to call that code, since by the time kgPanels is loaded and running your custom scripts, all the default UI code has already been loaded.

Originally Posted by Rainrider You don't have to call ClearAllPoints() as long as you use "TOPRIGHT" as your anchor point, because that's the only anchor point used by Blizzard to position the WatchFrame and the SetPoint call overwrites it.

See the code in UIParent.lua I linked to in my previous post; if that code has run before your code runs, then the BOTTOMRIGHT point will also have been set. Calling ClearAllPoints costs basically nothing, but avoids any problems that might cause.

[Mayron]

Originally Posted by Phanx hooksecurefunc("UIParent_ManageFramePositions", function() WatchFrame:ClearAllPoints() WatchFrame:SetPoint("TOPRIGHT", "Minimap", "BOTTOMLEFT", 50, -20) end)

Thank you Phanx. The "WatchFrame:SetUserPlaced(true)" did not work since it said the WatchFrame is not moveable or something like that however the hooksecurefunc was what I needed and works perfectly!

I then read from Rainrider that I could have used "WatchFrame:SetMovable(true)" so thank you for that but I tried out hooksecurefunc() first.

Appreciate it and to all others who have helped as well!

Also thank you for making this very clear to me as that should help me in the future:

Originally Posted by Phanx You shouldn't need to delay until PLAYER_ENTERING_WORLD to call that code, since by the time kgPanels is loaded and running your custom scripts, all the default UI code has already been loaded.

[Mayron]

Hi guys,

In the end the only script that would work is the following:

local WatchEvent = CreateFrame("Frame")
WatchEvent:RegisterEvent("PLAYER_ENTERING_WORLD") 
WatchEvent:SetScript("OnEvent", function()
	WatchFrame:SetMovable(true)
	WatchFrame:SetUserPlaced(true)
	WatchFrame:SetHeight(300)
	if MBar3:IsVisible() and not MBar4:IsVisible() then
		WatchFrame:SetPoint("TOPRIGHT", "Minimap", "BOTTOMLEFT", 80, -20)
	elseif MBar4:IsVisible() then
		WatchFrame:SetPoint("TOPRIGHT", "Minimap", "BOTTOMLEFT", 40, -20)
	else
		WatchFrame:SetPoint("TOPRIGHT", "Minimap", "BOTTOMLEFT", 120, -20)
	end
end)

I have another issue though. The "WatchFrame:SetHeight(300)" line does not work as it appears to not have any limit. I can track any number of quests and it all shows up and its too long. Does anyone know why this might be?

[Rainrider]

As Phanx stated before, FrameXML is loaded before addons, meaning WatchFrame.lua/.xml and UIParent.lua were ran before your code was evaluated. Thus UIParent.lua ran this line:

WatchFrame:SetPoint("BOTTOMRIGHT", "UIParent", "BOTTOMRIGHT", -CONTAINER_OFFSET_X, CONTAINER_OFFSET_Y);

(see the link from Phanx above)

So, you either call WatchFrame:ClearAllPoints() and then use WatchFrame:SetHeight(300) or you overwrite the BOTTOMRIGHT anchor and do the math for the height you want (WatchFrame:GetTop() - WatchFrame:GetBottom())

Apart from that, as Phanx said, and you quoted, you don't need your WatchEvent frame and wait for PLAYER_ENTERING_WORLD.

I'm sorry that my previous explanations proved misleading or wrong, I didn't take all aspects into account and just aimed at minimal code. Please accept my apologies.

[Phanx]

Originally Posted by Mayron I have another issue though. The "WatchFrame:SetHeight(300)" line does not work as it appears to not have any limit. I can track any number of quests and it all shows up and its too long. Does anyone know why this might be?

I don't know why, but I avoid the issue by setting the height implicitly instead of explicitly:

WatchFrame:ClearAllPoints()
WatchFrame:SetPoint("TOPLEFT", UIParent, "TOPLEFT", 30, 10)
WatchFrame:SetPoint("BOTTOMLEFT", UIParent, "LEFT", 30, -100)

Also, if you want a custom width:

hooksecurefunc("WatchFrame_SetWidth", function(width)
	WATCHFRAME_EXPANDEDWIDTH = 406 -- adjust as desired
	WATCHFRAME_MAXLINEWIDTH = 394 -- needs to be about 12px narrower than above
	if WatchFrame:IsShown() and not WatchFrame.collapsed then
		WatchFrame:SetWidth(WATCHFRAME_EXPANDEDWIDTH)
		WatchFrame_Update()
	end
end)

-- do this with the rest of your initialization stuff:
WatchFrame_SetWidth(1)
WatchFrame_Update(WatchFrame)

[Mayron]

I managed to get it working with this:

local WatchEvent = CreateFrame("Frame")
WatchEvent:RegisterEvent("PLAYER_ENTERING_WORLD") 
WatchEvent:SetScript("OnEvent", function()
	WatchFrame:ClearAllPoints()
	WatchFrame:SetHeight(400)
	if MBar3:IsVisible() and not MBar4:IsVisible() then
		WatchFrame:SetPoint("TOPRIGHT", "Minimap", "BOTTOMLEFT", 80, -20)
	elseif MBar4:IsVisible() then
		WatchFrame:SetPoint("TOPRIGHT", "Minimap", "BOTTOMLEFT", 40, -20)
	else
		WatchFrame:SetPoint("TOPRIGHT", "Minimap", "BOTTOMLEFT", 120, -20)
	end
end)

However it only works when I login. When I reload the UI with the command then it resets itself back to its default look. Do you know why this is or how to fix it? Also I tried running it without the "PLAYER_ENTERING_WORLD" and it does not take effect by changing anything.

[Rainrider]

That's why you need SetUserPlaced(true), else the default ui will reposition the frame. What should work is this:

local wf = WatchFrame
wf:SetMovable(true)
wf:SetUserPlaced(true)
wf:ClearAllPoints()
if MBar3:IsVisible() and not MBar4:IsVisible() then
    wf:SetPoint("TOPRIGHT", "Minimap", "BOTTOMLEFT", 80, -20)
elseif MBar4:IsVisible() then
    wf:SetPoint("TOPRIGHT", "Minimap", "BOTTOMLEFT", 40, -20)
else
    wf:SetPoint("TOPRIGHT", "Minimap", "BOTTOMLEFT", 120, -20)
end
wf:SetHeight(400)

You should be able to place the whole code in the OnLoad script for your kgPanels frame.

[Mayron]

Originally Posted by Rainrider That's why you need SetUserPlaced(true), else the default ui will reposition the frame. What should work is this: local wf = WatchFrame wf:SetMovable(true) wf:SetUserPlaced(true) wf:ClearAllPoints() if MBar3:IsVisible() and not MBar4:IsVisible() then     wf:SetPoint("TOPRIGHT", "Minimap", "BOTTOMLEFT", 80, -20) elseif MBar4:IsVisible() then     wf:SetPoint("TOPRIGHT", "Minimap", "BOTTOMLEFT", 40, -20) else     wf:SetPoint("TOPRIGHT", "Minimap", "BOTTOMLEFT", 120, -20) end wf:SetHeight(400) You should be able to place the whole code in the OnLoad script for your kgPanels frame.

Thank you! This works at the same time as does not work. It is very strange but if I use this code in the OnLoad kgPanel script on its own then it does not work when I ReloadUI. However if I use the script below on its own:

local WatchEvent = CreateFrame("Frame")
WatchEvent:RegisterEvent("PLAYER_ENTERING_WORLD") 
WatchEvent:SetScript("OnEvent", function()
	WatchFrame:ClearAllPoints()
	WatchFrame:SetHeight(600)
	if MBar3:IsVisible() and not MBar4:IsVisible() then
		WatchFrame:SetPoint("TOPRIGHT", "Minimap", "BOTTOMLEFT", 80, -20)
	elseif MBar4:IsVisible() then
		WatchFrame:SetPoint("TOPRIGHT", "Minimap", "BOTTOMLEFT", 40, -20)
	else
		WatchFrame:SetPoint("TOPRIGHT", "Minimap", "BOTTOMLEFT", 120, -20)
	end
end)

Inside an addon it does not work either. HOWEVER it does work only when I use your code and that code together! I have no idea why though. I got what I want but need to use both of them together, one inside the Onload script in KgPanels and the other in an addon..

Very Confusing!

[Rainrider]

I actually tested my script in-game and it works (apart from that MBar stuff, because I can't test this). You probably have some action bars addon that creates the bars, whose visibility you check. If you use an addon for this and not kgPanels, you can just add WatchFrame:SetMovable(true) and WatchFrame:SetUserPlaced(true) in your code and it should work without the kgPanels OnLoad script.