Quantcast N2 C13 - WoWInterface
Thread Tools Display Modes
12-30-14, 06:40 PM   #1
nelegalno2
A Flamescale Wyrmkin
Join Date: Dec 2014
Posts: 132
N2 C13

It seems I'm having trouble with github, if anyone is willing to push this manually otherwise I'll do so on 5th.

Last edited by nelegalno2 : 12-31-14 at 02:23 PM.
  Reply With Quote
12-31-14, 01:14 PM   #2
samyonair
A Frostmaul Preserver
 
samyonair's Avatar
Join Date: May 2009
Posts: 257
I have found one failure because I cannot merge without problems,

we need a decission

which codebase should be used your files are converted with Unix and my with DOS

don't know why but without to know which utf8 I should use I cannot merge it,

will do that because misstakes in german I've found by the way to chnage them manually at merging,

2. I found a double in Credits Page

JimJoBlue is double one time for guide locations updates and checking one only for guide locations updates, could be removed but this should decide Rythal

Greetings Samyonair
  Reply With Quote
12-31-14, 01:50 PM   #3
nelegalno2
A Flamescale Wyrmkin
Join Date: Dec 2014
Posts: 132
Originally Posted by samyonair View Post
I have found one failure because I cannot merge without problems,

we need a decission

which codebase should be used your files are converted with Unix and my with DOS

don't know why but without to know which utf8 I should use I cannot merge it,

will do that because misstakes in german I've found by the way to chnage them manually at merging,

2. I found a double in Credits Page

JimJoBlue is double one time for guide locations updates and checking one only for guide locations updates, could be removed but this should decide Rythal

Greetings Samyonair
github uses Unix line endings and I don't convert them since my software supports both, most of the translation files I use are in UTF-8 encoding since WoW uses it and it won't trow errors if i forget to use an LUA escape sequence for it. Not to mention that KR, RU, CN and TW are untranslatable without it.
  Reply With Quote
12-31-14, 02:22 PM   #4
nelegalno2
A Flamescale Wyrmkin
Join Date: Dec 2014
Posts: 132
Carbonite-N2C13.zip
Updated to https://github.com/Rythal/Carbonite/...6a41393c9410e2
  Reply With Quote
12-31-14, 02:23 PM   #5
Rythal
Featured Artist
Featured
Join Date: Aug 2012
Posts: 1,447
L["JimboBlue for guide location updates"] should be the right one, (with it changed to jimjoblue).
  Reply With Quote
12-31-14, 02:25 PM   #6
nelegalno2
A Flamescale Wyrmkin
Join Date: Dec 2014
Posts: 132
Originally Posted by Rythal View Post
L["JimboBlue for guide location updates"] should be the right one, (with it changed to jimjoblue).
The name is corrected but since i wasn't sure which line should stay they are both still there.
  Reply With Quote
01-01-15, 12:19 PM   #7
nelegalno2
A Flamescale Wyrmkin
Join Date: Dec 2014
Posts: 132
Carbonite-N2C13.zip
Updated version with some fixes and up to https://github.com/Rythal/Carbonite/...5d3318323bedf7

P.S. Now I can finally see the quest givers on the map.

Last edited by nelegalno2 : 01-01-15 at 12:21 PM.
  Reply With Quote
01-01-15, 12:49 PM   #8
samyonair
A Frostmaul Preserver
 
samyonair's Avatar
Join Date: May 2009
Posts: 257
will merge your files later, because, have merged them with my files, and have finished Keybindings

will create a Pull Request after last tests

Greetings Samyonair
  Reply With Quote
01-01-15, 01:46 PM   #9
samyonair
A Frostmaul Preserver
 
samyonair's Avatar
Join Date: May 2009
Posts: 257
Your Version from 31.12.2014 is now in my PR will later check your changes, I'm done for now, thanks for your Help with Keybinds

Greetings Samyonair
  Reply With Quote
01-01-15, 06:01 PM   #10
nelegalno2
A Flamescale Wyrmkin
Join Date: Dec 2014
Posts: 132
Originally Posted by samyonair View Post
Your Version from 31.12.2014 is now in my PR will later check your changes, I'm done for now, thanks for your Help with Keybinds

Greetings Samyonair
Thanks and you are welcome.
  Reply With Quote
01-03-15, 05:28 AM   #11
nelegalno2
A Flamescale Wyrmkin
Join Date: Dec 2014
Posts: 132
Carbonite-N2C13.zip
Updated to https://github.com/Rythal/Carbonite/...1854142c1b6111

@samyonair: Carbonite-deDE+N2C13.zip
  Reply With Quote
01-03-15, 05:14 PM   #12
samyonair
A Frostmaul Preserver
 
samyonair's Avatar
Join Date: May 2009
Posts: 257
Sorry I have so many branches at the moment to re check, cannot put in yours because every try gitextensions break

greetings Samyonair
  Reply With Quote
01-04-15, 02:20 AM   #13
nelegalno2
A Flamescale Wyrmkin
Join Date: Dec 2014
Posts: 132
Originally Posted by samyonair View Post
Sorry I have so many branches at the moment to re check, cannot put in yours because every try gitextensions break

greetings Samyonair
NP, I'll make a pull with them tomorrow or the day after.
  Reply With Quote
01-13-15, 02:18 AM   #14
nelegalno2
A Flamescale Wyrmkin
Join Date: Dec 2014
Posts: 132
https://github.com/Rythal/Carbonite/pull/231

P.S. This can be moved to the Archive.
  Reply With Quote
01-14-15, 10:30 AM   #15
nelegalno2
A Flamescale Wyrmkin
Join Date: Dec 2014
Posts: 132
Removed fixes from pull so translation files can be updated, preview of the suggested changes: https://github.com/Rythal/Carbonite/pull/231/files
  Reply With Quote

WoWInterface » Featured Projects » Carbonite » Carbonite: Dev Talk » N2 C13

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off