help [addon chat]

[Caetan0]

friends,
I have this addon that whenever I go into combat, the windows of the minimap and chat are invisible.

local HiC = CreateFrame("Frame", "HiC", UIParent)
function HiC.OnEvent(self, event)
	if event == "PLAYER_REGEN_DISABLED" then
		GeneralDockManager:Hide()
		DEFAULT_CHAT_FRAME:Hide()
		FriendsMicroButton:Hide()
		ChatFrameMenuButton:Hide()
		MinimapCluster:Hide()
	else
		GeneralDockManager:Show()
		DEFAULT_CHAT_FRAME:Show()
		FriendsMicroButton:Show()
		ChatFrameMenuButton:Show()
		MinimapCluster:Show()
	end
end
HiC:SetScript("OnEvent", HiC.OnEvent)
HiC:RegisterEvent("PLAYER_REGEN_ENABLED")
HiC:RegisterEvent("PLAYER_REGEN_DISABLED")

The problem is that often, when I go into combat, the chat window remains visible, Would anyone know what might be?

[Caetan0]

someone has any idea of why this occurred

[zork]

Are you sure that you do not get any "Addon blocked message?"

If so you got a taint and the addon action is blocked. Show/Hide is prohibited for certain Blizzard frames in combat. You can change that by using secure methods.

RegisterStateDriver(MinimapCluster, "visibility", "[combat] hide;show")

[Caetan0]

Friend, I used the code that you sent and it has worked bwem, however, when the map loads into a new scenario, I have to enter all the codes again.

The solution I found was this, see if this could be good or better?

local combate = 0
local function onUpdate(self,elapsed)
    combate = combate + elapsed
    if combate >= 0 then
        RegisterStateDriver(GeneralDockManager, "visibility", "[combat] hide;show")
        RegisterStateDriver(DEFAULT_CHAT_FRAME, "visibility", "[combat] hide;show")
        RegisterStateDriver(FriendsMicroButton, "visibility", "[combat] hide;show")
        RegisterStateDriver(ChatFrameMenuButton, "visibility", "[combat] hide;show")
        RegisterStateDriver(MinimapCluster, "visibility", "[combat] hide;show")
        RegisterStateDriver(ChatFrame4, "visibility", "[combat] hide;show")
        combate = 0
    end
local f = CreateFrame("frame")
f:SetScript("OnUpdate", onUpdate)

[zork]

OnUpdate fires on every single frame the game is drawing. You run your function 200times a second on 200fps.

Not sure what you are trying to do and why you are rewriting the state driver all the time.
The state driver runs every 0.2 seconds. Frames will hide automatically after 0.2 seconds again.

Btw have you tried this?

local frame = CreateFrame("Frame","myFrameHider")
RegisterStateDriver(frame, "visibility", "[combat] hide;show")
GeneralDockManager:SetParent(frame)
FriendsMicroButton:SetParent(frame)
ChatFrame1:SetParent(frame)
ChatFrameMenuButton:SetParent(frame)
MinimapCluster:SetParent(frame)
ChatFrame4:SetParent(frame)

This reparents your frames and adds the statedriver to the parent frame.

[Caetan0]

did not work

[Aanson]

Originally Posted by Caetan0 friends, I have this addon that whenever I go into combat, the windows of the minimap and chat are invisible. local HiC = CreateFrame("Frame", "HiC", UIParent) function HiC.OnEvent(self, event) if event == "PLAYER_REGEN_DISABLED" then GeneralDockManager:Hide() DEFAULT_CHAT_FRAME:Hide() FriendsMicroButton:Hide() ChatFrameMenuButton:Hide() MinimapCluster:Hide() else GeneralDockManager:Show() DEFAULT_CHAT_FRAME:Show() FriendsMicroButton:Show() ChatFrameMenuButton:Show() MinimapCluster:Show() end end HiC:SetScript("OnEvent", HiC.OnEvent) HiC:RegisterEvent("PLAYER_REGEN_ENABLED") HiC:RegisterEvent("PLAYER_REGEN_DISABLED") The problem is that often, when I go into combat, the chat window remains visible, Would anyone know what might be?

This should work, as other chat frames (ie ChatFrame2 etc) seem to inherit their behavior from ChatFrame1. Although, I'm pretty sure that FriendsMicroButton and ChatFrameMenuButton are parented to ChatFrame1 anyway, so you can probably remove the lines for them:

local HiC = CreateFrame("Frame", "HiC", UIParent)
function HiC.OnEvent(self, event)
    if event == "PLAYER_REGEN_DISABLED" then
        GeneralDockManager:Hide()
        ChatFrame1:Hide()
        MinimapCluster:Hide()
    else
        GeneralDockManager:Show()
        ChatFrame1:Show()
        MinimapCluster:Show()
    end
end
HiC:SetScript("OnEvent", HiC.OnEvent)
HiC:RegisterEvent("PLAYER_REGEN_ENABLED")
HiC:RegisterEvent("PLAYER_REGEN_DISABLED")

From what I've learned about OnUpdate, you should try and always use a counter, but if you're checking that the counter >= 0.0 (or that the counter is more than or equal to zero) then it may as well not exist.

If ever you are tempted to use OnUpdate, I suggest that you change you're line to:

combate = combate + elapsed
if combate >= 1 then
  -- input your code
  combate = 0  -- reset your counter to 0 after your code has been input 
end

That way, your OnUpdate code will only be read once per second as opposed to 60 times per second (with a frame rate of 60).