Always include realm name

[Lombra]

Just a quick check.. would this ever not work to make sure realm name is always included?

if not name:match("%-") then
	name = name.."-"..gsub(GetRealmName(), " ", "")
end

Assuming it's either the full realm name or nothing, which will be the case for any CHAT_MSG event, yes? And realm name will always be there for messages from other realms, yes?

Do realm names ever have spaces in them nowadays in API contexts? (except for GetRealmName then)

[Shaft840]

Hey Lombra,

That code should do the trick, or something like

if not string.find(name, "-") then
	name = name.."-"..string.gsub(GetRealmName(), " ", "")
end

CHAT_MSG_WHISPER
From what I remember, player is usually good with the realm name attached.

CHAT_MSG_WHISPER_INFORM
It depends, If the player does not enter -"realm" after the name then it will not be attached. If they do, it should.

Either way your code to check it is well used.

You are right that 2 word realm names have no spaces unless it is GetRealmName()

[Phanx]

Use UnitFullName("player") instead of GetRealmName() -- this way you don't have to strip out spaces, or any other characters Blizz decides to remove in the future, since it's already properly formatted:

if not string.find(name, "-") then
	local _, realm = UnitFullName("player")
	name = name.."-"..realm
end

[Sharparam]

But what if you don't have a unit handy?

[Lombra]

Ah, cool. Didn't know about that.

Originally Posted by Sharparam But what if you don't have a unit handy?

That's what I thought, too, but the point is to use the return from the player unit for all senders that has no realm name, which should only be ones that are from my realm.

[Sharparam]

At least if Blizzard has finally decided how to handle cross-realm stuff across the board. It seemed to be going back and forth several times over. Removing and adding realm suffixes like crazy...

[Phanx]

Originally Posted by Sharparam At least if Blizzard has finally decided how to handle cross-realm stuff across the board. It seemed to be going back and forth several times over. Removing and adding realm suffixes like crazy...

It's still hit-or-miss which API functions will accept a name-realm combo or only a name. Many functions that normally accept a name (for units in your group) currently fail if a realm name is included, eg. CheckInteractDistance or InviteUnit.