Best way of updating the target nameplate?

zork · 02-02-15, 02:13 AM

Lately I rewrote rNamePlates to support auras. It took me a while to figure out all the itches but I finally got everything working together perfectly.

http://www.wowinterface.com/download...tesDiablo.html

There is just one small scratch that I want to get rid off.

When having a visible target nameplate. Once I move the camera off the nameplate and then move it back to the nameplate the auras aren't working. That is because the nameplate GUID is reset. (Because the OnHide has been triggered)

The GUID scan is event driven and works perfectly. The only problem left is if I have a target nameplate without a GUID. Which can happed if the nameplate triggered the OnHide event and gets re-shown later on without a PLAYER_TARGET_CHANGED event being fired inbetween.

My question is. How would you re-test for a target nameplate GUID?

Here is what I do atm: https://code.google.com/p/rothui/sou...Plates.lua#614

So. What I'm thinking of is the following. In the OnUpdate I can count the frame with alpha of 1. If the result is 1 after the loop I check if I have a valid target and if the current nameplate marked as targetPlate has a GUID. If it does not I could apply it and scan for auras.

Well. That is my idea. Maybe anyone has a different approach that he might share?

Here is my idea:

Lua Code:

-- // rNamePlates
  -- // zork - 2014
 
  -----------------------------
  -- VARIABLES
  -----------------------------
 
  local an, at = ...
  local plates, namePlateIndex, _G, string, WorldFrame, unpack, math, wipe, mod = {}, nil, _G, string, WorldFrame, unpack, math, wipe, mod
 
  local cfg = {}
  cfg.scale                   = 0.35
  cfg.font                    = STANDARD_TEXT_FONT
  cfg.healthbar_fontsize      = 26
  cfg.castbar_fontsize        = 26
  cfg.aura_stack_fontsize     = 24
  cfg.aura_cooldown_fontsize  = 28
  cfg.point                   = {"CENTER",0,-16}
  cfg.notFocusedPlateAlpha    = 0.5
 
  -----------------------------
  -- AURAS
  -----------------------------
 
  local NUM_MAX_AURAS = 40
 
  local unitDB                = {}  --unit table by guid
  local spellDB                     --aura table by spellid
 
  local AuraModule = CreateFrame("Frame")
  AuraModule.playerGUID       = nil
  AuraModule.petGUID          = nil
  AuraModule.updateTarget     = false
  AuraModule.hasTarget        = false
  AuraModule.updateMouseover  = false
 
  function AuraModule:PLAYER_TARGET_CHANGED(...)
    if not spellDB then return end
    if spellDB.disabled then return end
    if UnitGUID("target") and UnitExists("target") and not UnitIsUnit("target","player") and not UnitIsDead("target") then
      self.updateTarget = true
      self.hasTarget = true
    else
      self.updateTarget = false
      self.hasTarget = false
    end
  end
 
  function AuraModule:UPDATE_MOUSEOVER_UNIT(...)
    if not spellDB then return end
    if spellDB.disabled then return end
    if UnitGUID("mouseover") and UnitExists("mouseover") and not UnitIsUnit("mouseover","player") and not UnitIsDead("mouseover") then
      self.updateMouseover = true
    else
      self.updateMouseover = false
    end
  end
 
  function AuraModule:UNIT_PET(...)
    if UnitGUID("pet") and UnitExists("pet") then
      self.petGUID = UnitGUID("pet")
    end
  end
 
  function AuraModule:PLAYER_LOGIN(...)
    if UnitGUID("player") then
      self.playerGUID = UnitGUID("player")
    end
    if UnitGUID("pet") and UnitExists("pet") then
      self.petGUID = UnitGUID("pet")
    end
  end
 
  AuraModule.CLEU_FILTER = {
    ["SPELL_AURA_APPLIED"]      = true, --UpdateAura
    ["SPELL_AURA_REFRESH"]      = true, --UpdateAura
    ["SPELL_AURA_APPLIED_DOSE"] = true, --UpdateAura
    ["SPELL_AURA_REMOVED_DOSE"] = true, --UpdateAura
    ["SPELL_AURA_STOLEN"]       = true, --RemoveAura
    ["SPELL_AURA_REMOVED"]      = true, --RemoveAura
    ["SPELL_AURA_BROKEN"]       = true, --RemoveAura
    ["SPELL_AURA_BROKEN_SPELL"] = true, --RemoveAura
  }
 
  function AuraModule:COMBAT_LOG_EVENT_UNFILTERED(...)
    if not spellDB then return end
    if spellDB.disabled then return end
    local _, event, _, srcGUID, _, _, _, destGUID, _, _, _, spellID, spellName, _, _, stackCount = ...
    if self.CLEU_FILTER[event] then
      if not unitDB[destGUID] then return end --no corresponding nameplate found
      if not spellDB[spellID] then return end --no spell info found
      local unitCaster = nil
      if srcGUID == self.playerGUID then
        unitCaster = "player"
      elseif srcGUID == self.petGUID then
        unitCaster = "pet"
      else
        return
      end
      if event == "SPELL_AURA_APPLIED" or event == "SPELL_AURA_REFRESH" or event == "SPELL_AURA_APPLIED_DOSE" or event == "SPELL_AURA_REMOVED_DOSE" then
        unitDB[destGUID]:UpdateAura(GetTime(),nil,unitCaster,spellID,stackCount)
      else
        unitDB[destGUID]:RemoveAura(spellID)
      end
    end
  end
 
  function AuraModule:UNIT_AURA(unit)
    if not spellDB then return end
    if spellDB.disabled then return end
    local guid = UnitGUID(unit)
    if guid and unitDB[guid] and not UnitIsUnit(unit,"player") then
      --print("ScanAuras", "UNIT_AURA", unitDB[guid].newPlate.id)
      unitDB[guid]:ScanAuras(unit,"HELPFUL")
      unitDB[guid]:ScanAuras(unit,"HARMFUL")
    end
  end
 
  function AuraModule:ADDON_LOADED(name,...)
    if name == an then
      self:UnregisterEvent("ADDON_LOADED")
      if not rNP_SPELL_DB then
        rNP_SPELL_DB = {}
      end
      spellDB = rNP_SPELL_DB --variable is bound by reference. there is no way this can fuck up. like no way.
      print(an,"AuraModule","loading spell db")
      if spellDB.disabled then
        print(an,"AuraModule","spell db is currently disabled on this character")
      end
    end
  end
 
  AuraModule:RegisterEvent("ADDON_LOADED")
  AuraModule:RegisterEvent("PLAYER_LOGIN")
  --ok unit_aura is important. otherwise new auras will only be found if they are preset on frame init.
  --one cannot add new spells to the DB via CLEU. there is missing data (duration).
  AuraModule:RegisterUnitEvent("UNIT_AURA","target","mouseover")
  AuraModule:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
  AuraModule:RegisterUnitEvent("UNIT_PET", "player")
  AuraModule:RegisterEvent("PLAYER_TARGET_CHANGED")
  AuraModule:RegisterEvent("UPDATE_MOUSEOVER_UNIT")
  AuraModule:SetScript("OnEvent", function(self, event, ...) self[event](self, ...) end)
 
  -----------------------------
  -- FUNCTIONS
  -----------------------------
 
  local trash = CreateFrame("Frame")
  trash:Hide()
 
  local function GetHexColorFromRGB(r, g, b)
    return string.format("%02x%02x%02x", r*255, g*255, b*255)
  end
 
  local function GetFormattedTime(time)
    if time <= 0 then
      return ""
    elseif time < 2 then
      return (math.floor(time*10)/10)
    elseif time < 60 then
      return string.format("%ds", mod(time, 60))
    elseif time < 3600 then
      return string.format("%dm", math.floor(mod(time, 3600) / 60 + 1))
    else
      return string.format("%dh", math.floor(time / 3600 + 1))
    end
  end
 
  local function RoundNumber(n)
    return (math.floor(n*100+0.5)/100)
  end
 
  local function NamePlateSetup(blizzPlate)
 
    blizzPlate.borderTexture:SetTexture(nil)
    blizzPlate.bossIconTexture:SetTexture(nil)
    blizzPlate.eliteDragonTexture:SetTexture(nil)
    blizzPlate.highlightTexture:SetTexture(nil)
    blizzPlate.threatTexture:SetTexture(nil)
 
    local name = blizzPlate.nameString:GetText() or "Unknown"
    local level = blizzPlate.levelString:GetText() or "-1"
    local hexColor = GetHexColorFromRGB(blizzPlate.levelString:GetTextColor()) or "ffffff"
 
    if blizzPlate.bossIconTexture:IsShown() then
      level = "??"
      hexColor = "ff6600"
    elseif blizzPlate.eliteDragonTexture:IsShown() then
      level = level.."+"
    end
    blizzPlate.newPlate.healthBar.name:SetText("|cff"..hexColor..""..level.."|r "..name)
  end
 
  local function NamePlateOnInit(blizzPlate)
 
    blizzPlate.barFrame, blizzPlate.nameFrame = blizzPlate:GetChildren()
    blizzPlate.healthBar, blizzPlate.castBar = blizzPlate.barFrame:GetChildren()
    blizzPlate.threatTexture, blizzPlate.borderTexture, blizzPlate.highlightTexture, blizzPlate.levelString, blizzPlate.bossIconTexture, blizzPlate.raidIconTexture, blizzPlate.eliteDragonTexture = blizzPlate.barFrame:GetRegions()
    blizzPlate.nameString = blizzPlate.nameFrame:GetRegions()
    blizzPlate.healthBar.statusbarTexture = blizzPlate.healthBar:GetRegions()
    blizzPlate.castBar.statusbarTexture, blizzPlate.castBar.borderTexture, blizzPlate.castBar.shieldTexture, blizzPlate.castBar.spellIconTexture, blizzPlate.castBar.nameString, blizzPlate.castBar.nameShadow = blizzPlate.castBar:GetRegions()
 
    blizzPlate.nameFrame:SetParent(trash)
    blizzPlate.levelString:SetParent(trash)
 
    blizzPlate.healthBar.__owner = blizzPlate
    blizzPlate.castBar.__owner = blizzPlate
 
    blizzPlate.healthBar:SetParent(trash)
    blizzPlate.castBar:SetParent(trash)
 
    blizzPlate.castBar.borderTexture:SetTexture(nil)
    blizzPlate.borderTexture:SetTexture(nil)
    blizzPlate.bossIconTexture:SetTexture(nil)
    blizzPlate.eliteDragonTexture:SetTexture(nil)
    blizzPlate.highlightTexture:SetTexture(nil)
    blizzPlate.threatTexture:SetTexture(nil)
 
  end
 
  local function SkinHealthBar(blizzPlate)
 
    local bar = CreateFrame("StatusBar",nil,blizzPlate.newPlate)
    bar:SetSize(256,64)
    bar:SetStatusBarTexture("Interface\\AddOns\\"..an.."\\media\\statusbar_fill")
    bar:SetScale(cfg.scale)
    bar:SetPoint(unpack(cfg.point))
 
    local le = bar:CreateTexture(nil,"BACKGROUND",nil,-8)
    le:SetTexture("Interface\\AddOns\\"..an.."\\media\\edge_left")
    le:SetSize(64,64)
    le:SetPoint("RIGHT",bar,"LEFT",0,0)
 
    local re = bar:CreateTexture(nil,"BACKGROUND",nil,-8)
    re:SetTexture("Interface\\AddOns\\"..an.."\\media\\edge_right")
    re:SetSize(64,64)
    re:SetPoint("LEFT",bar,"RIGHT",0,0)
 
    local bg = bar:CreateTexture(nil,"BACKGROUND",nil,-8)
    bg:SetTexture("Interface\\AddOns\\"..an.."\\media\\statusbar_bg")
    bg:SetAllPoints()
 
    local shadow = bar:CreateTexture(nil,"BACKGROUND",nil,-8)
    shadow:SetTexture("Interface\\Common\\NameShadow")
    shadow:SetPoint("BOTTOM",bar,"TOP",0,-20)
    shadow:SetSize(256,32)
    shadow:SetTexCoord(1,1,1,0,0,1,0,0)
    shadow:SetAlpha(0.5)
 
    local hlf = CreateFrame("Frame",nil,bar)
    hlf:SetAllPoints()
    bar.hlf = hlf
 
    local hl = hlf:CreateTexture(nil,"BACKGROUND",nil,-8)
    hl:SetTexture("Interface\\AddOns\\"..an.."\\media\\statusbar_highlight")
    hl:SetAllPoints()
 
    local name = bar.hlf:CreateFontString(nil, "BORDER")
    name:SetFont(cfg.font, cfg.healthbar_fontsize, "OUTLINE")
    name:SetPoint("BOTTOM",bar,"TOP",0,-24)
    name:SetPoint("LEFT",8,0)
    name:SetPoint("RIGHT",-8,0)
    name:SetText("Ich bin ein Berliner!")
    bar.name = name
 
    blizzPlate.raidIconTexture:SetParent(bar)
    blizzPlate.raidIconTexture:SetSize(60,60)
    blizzPlate.raidIconTexture:ClearAllPoints()
    blizzPlate.raidIconTexture:SetPoint("BOTTOM",bar,"TOP",0,40)
 
    blizzPlate.newPlate.healthBar = bar
 
  end
 
  local function SkinCastBar(blizzPlate)
 
    local bar = CreateFrame("StatusBar",nil,blizzPlate.newPlate)
    bar:SetSize(256,64)
    bar:SetStatusBarTexture("Interface\\AddOns\\"..an.."\\media\\statusbar_fill")
    bar:SetScale(cfg.scale)
    bar:SetPoint("TOP",blizzPlate.newPlate.healthBar,"BOTTOM",0,20)
 
    local le = bar:CreateTexture(nil,"BACKGROUND",nil,-8)
    le:SetTexture("Interface\\AddOns\\"..an.."\\media\\edge_left")
    le:SetSize(64,64)
    le:SetPoint("RIGHT",bar,"LEFT",0,0)
 
    local re = bar:CreateTexture(nil,"BACKGROUND",nil,-8)
    re:SetTexture("Interface\\AddOns\\"..an.."\\media\\edge_right")
    re:SetSize(64,64)
    re:SetPoint("LEFT",bar,"RIGHT",0,0)
 
    local bg = bar:CreateTexture(nil,"BACKGROUND",nil,-8)
    bg:SetTexture("Interface\\AddOns\\"..an.."\\media\\statusbar_bg")
    bg:SetAllPoints()
 
    local shadow = bar:CreateTexture(nil,"BACKGROUND",nil,-8)
    shadow:SetTexture("Interface\\Common\\NameShadow")
    shadow:SetPoint("TOP",bar,"BOTTOM",0,20)
    shadow:SetSize(256,32)
 
    local hlf = CreateFrame("Frame",nil,bar)
    hlf:SetAllPoints()
    bar.hlf = hlf
 
    local hl = hlf:CreateTexture(nil,"BACKGROUND",nil,-8)
    hl:SetTexture("Interface\\AddOns\\"..an.."\\media\\statusbar_highlight")
    hl:SetAllPoints()
 
    local name = bar.hlf:CreateFontString(nil, "BORDER")
    name:SetFont(cfg.font, cfg.castbar_fontsize, "OUTLINE")
    name:SetPoint("TOP",bar,"BOTTOM",0,30)
    name:SetPoint("LEFT",8,0)
    name:SetPoint("RIGHT",-8,0)
    bar.nameString = name
 
    local icon = bar:CreateTexture(nil,"BACKGROUND",nil,-8)
    icon:SetTexCoord(0.08,0.92,0.08,0.92)
    icon:SetPoint("RIGHT",bar,"LEFT",-58,22)
    icon:SetSize(60,60)
    bar.spellIconTexture = icon
 
    local iconBorder = bar:CreateTexture(nil,"BACKGROUND",nil,-7)
    iconBorder:SetTexture("Interface\\AddOns\\"..an.."\\media\\icon_border")
    iconBorder:SetPoint("CENTER",bar.spellIconTexture,"CENTER",0,0)
    iconBorder:SetSize(78,78)
    bar.spellIconBorder = iconBorder
 
    local shield = bar:CreateTexture(nil,"BACKGROUND",nil,-6)
    shield:SetTexture("Interface\\AddOns\\"..an.."\\media\\shield")
    shield:SetPoint("BOTTOM",bar.spellIconBorder,0,-5)
    shield:SetSize(36,36)
    bar.shieldTexture = shield
 
    if not blizzPlate.castBar:IsShown() then
      bar:Hide()
    end
 
    blizzPlate.newPlate.castBar = bar
 
  end
 
  local function NamePlatePosition(blizzPlate)
    local sizer = CreateFrame("Frame", nil, blizzPlate.newPlate)
    sizer:SetPoint("BOTTOMLEFT", WorldFrame)
    sizer:SetPoint("TOPRIGHT", blizzPlate, "CENTER")
    sizer:SetScript("OnSizeChanged", function(self, x, y)
      if blizzPlate:IsShown() then
        blizzPlate.newPlate:Hide() -- Important, never move the frame while it"s visible
        blizzPlate.newPlate:SetPoint("CENTER", WorldFrame, "BOTTOMLEFT", x, y) -- Immediately reposition frame
        blizzPlate.newPlate:Show()
      end
    end)
  end
 
  local function NamePlateSetGUID(blizzPlate,guid)
    if blizzPlate.guid and guid ~= blizzPlate.guid then
      unitDB[blizzPlate.guid] = nil
      wipe(blizzPlate.auras)
      blizzPlate:UpdateAllAuras() --hide visible buttons
      blizzPlate.guid = guid
      unitDB[guid] = blizzPlate
    elseif not blizzPlate.guid then
      blizzPlate.guid = guid
      unitDB[guid] = blizzPlate
    end
  end
 
  local function NamePlateOnShow(blizzPlate)
    NamePlateSetup(blizzPlate)
    blizzPlate.newPlate:Show()
  end
 
  local function NamePlateOnHide(blizzPlate)
    blizzPlate.newPlate.castBar:Hide()
    blizzPlate.newPlate:Hide()
    wipe(blizzPlate.auras)
    blizzPlate:UpdateAllAuras() --hide visible buttons
    if blizzPlate.guid then
      unitDB[blizzPlate.guid] = nil
      blizzPlate.guid = nil
    end
  end
 
  local function NamePlateCastBarOnHide(castBar)
    local blizzPlate = castBar.__owner
    local castBar2 = blizzPlate.newPlate.castBar
    castBar2:Hide()
  end
 
  local function NamePlateCastBarUpdate(castBar, value)
    local blizzPlate = castBar.__owner
    local castBar2 = blizzPlate.newPlate.castBar
    if castBar:IsShown() then
      castBar2:Show()
    else
      castBar2:Hide()
      return
    end
    if value == 0 then
      castBar2:Hide()
      return
    end
    castBar2.spellIconTexture:SetTexture(castBar.spellIconTexture:GetTexture())
    castBar2.nameString:SetText(castBar.nameString:GetText())
    castBar2:SetMinMaxValues(castBar:GetMinMaxValues())
    castBar2:SetValue(castBar:GetValue())
    if castBar.shieldTexture:IsShown() then
      castBar2.shieldTexture:Show()
      castBar2:SetStatusBarColor(0.8,0.8,0.8)
      castBar2.spellIconBorder:SetDesaturated(1)
    else
      castBar2.shieldTexture:Hide()
      castBar2:SetStatusBarColor(castBar:GetStatusBarColor())
      castBar2.spellIconBorder:SetDesaturated(0)
    end
  end
 
  local function NamePlateHealthBarUpdate(healthBar)
    local blizzPlate = healthBar.__owner
    local healthBar2 = blizzPlate.newPlate.healthBar
    healthBar2:SetMinMaxValues(healthBar:GetMinMaxValues())
    healthBar2:SetValue(healthBar:GetValue())
  end
 
  local RAID_CLASS_COLORS = RAID_CLASS_COLORS
  local FACTION_BAR_COLORS = FACTION_BAR_COLORS
 
  local function NamePlateHealthBarColor(blizzPlate)
    if blizzPlate.threatTexture:IsShown() then
      local r,g,b = blizzPlate.threatTexture:GetVertexColor()
      if g+b == 0 then
        blizzPlate.newPlate.healthBar:SetStatusBarColor(0,1,0)--tank mode
      else
        blizzPlate.newPlate.healthBar:SetStatusBarColor(r,g,b)
      end
      return
    end
    local r,g,b = blizzPlate.healthBar:GetStatusBarColor()
    if g+b == 0 then -- hostile
      r,g,b = FACTION_BAR_COLORS[2].r, FACTION_BAR_COLORS[2].g, FACTION_BAR_COLORS[2].b
    elseif r+b == 0 then -- friendly npc
      r,g,b = FACTION_BAR_COLORS[6].r, FACTION_BAR_COLORS[6].g, FACTION_BAR_COLORS[6].b
    elseif r+g > 1.95 then -- neutral
      r,g,b = FACTION_BAR_COLORS[4].r, FACTION_BAR_COLORS[4].g, FACTION_BAR_COLORS[4].b
    elseif r+g == 0 then -- friendly player, we don't like 0,0,1 so we change it to a more likable color
      r,g,b = 0/255, 100/255, 255/255
    end
    blizzPlate.newPlate.healthBar:SetStatusBarColor(r,g,b)
  end
 
  local function CreateNewPlate(blizzPlate)
    blizzPlate.newPlate = CreateFrame("Frame", nil, WorldFrame)
    blizzPlate.newPlate.id = namePlateIndex
    blizzPlate.newPlate:SetSize(36,36)
    plates[blizzPlate] = blizzPlate.newPlate
  end
 
  local function CreateNamePlateAuraFunctions(blizzPlate)
    blizzPlate.auras = {}
    blizzPlate.auraButtons = {}
    function blizzPlate:CreateAuraHeader()
      local auraHeader = CreateFrame("Frame",nil,self.newPlate)
      auraHeader:SetScale(cfg.scale)
      auraHeader:SetPoint("BOTTOMLEFT",self.newPlate.healthBar,"TOPLEFT",0,15)
      auraHeader:SetSize(60,45)
      blizzPlate.auraHeader = auraHeader
    end
    function blizzPlate:UpdateAura(startTime,expirationTime,unitCaster,spellID,stackCount)
      if not spellDB then return end
      if not spellDB[spellID] then return end
      if spellDB[spellID].blacklisted then return end
      if not expirationTime then
        expirationTime = startTime+spellDB[spellID].duration
      elseif not startTime then
        startTime = expirationTime-spellDB[spellID].duration
      end
      self.auras[spellID] = {
        spellId         = spellID,
        name            = spellDB[spellID].name,
        texture         = spellDB[spellID].texture,
        startTime       = startTime,
        expirationTime  = expirationTime,
        duration        = spellDB[spellID].duration,
        unitCaster      = unitCaster,
        stackCount      = stackCount,
      }
    end
    function blizzPlate:RemoveAura(spellID)
      if self.auras[spellID] then
        self.auras[spellID] = nil
      end
    end
    function blizzPlate:ScanAuras(unit,filter)
      if not spellDB then return end
      if spellDB.disabled then return end
      for index = 1, NUM_MAX_AURAS do
        local name, _, texture, stackCount, _, duration, expirationTime, unitCaster, _, _, spellID = UnitAura(unit, index, filter)
        if not name then break end
        if spellID and (unitCaster == "player" or unitCaster == "pet") and not spellDB[spellID] then
          spellDB[spellID] = {
            name        = name,
            texture     = texture,
            duration    = duration,
            blacklisted = false,
          }
          print(an,"AuraModule","adding new spell to db",spellID,name)
        end
        if spellID and (unitCaster == "player" or unitCaster == "pet") then
          self:UpdateAura(nil,expirationTime,unitCaster,spellID,stackCount)
        end
      end
    end
    function blizzPlate:CreateAuraButton(index)
      if not self.auraHeader then
        self:CreateAuraHeader()
      end
      local button = CreateFrame("Frame",nil,self.auraHeader)
      button:SetSize(self.auraHeader:GetSize())
      button.bg = button:CreateTexture(nil,"BACKGROUND",nil,-8)
      button.bg:SetTexture(1,1,1)
      button.bg:SetVertexColor(0,0,0,0.8)
      button.bg:SetAllPoints()
      button.icon = button:CreateTexture(nil,"BACKGROUND",nil,-7)
      button.icon:SetPoint("TOPLEFT",3,-3)
      button.icon:SetPoint("BOTTOMRIGHT",-3,3)
      button.icon:SetTexCoord(0.1,0.9,0.2,0.8)
      button.cooldown = button:CreateFontString(nil, "BORDER")
      button.cooldown:SetFont(cfg.font, cfg.aura_cooldown_fontsize, "OUTLINE")
      button.cooldown:SetPoint("BOTTOM",button,0,-5)
      button.cooldown:SetJustifyH("CENTER")
      button.stack = button:CreateFontString(nil, "BORDER")
      button.stack:SetFont(cfg.font, cfg.aura_stack_fontsize, "OUTLINE")
      button.stack:SetPoint("TOPRIGHT",button,5,5)
      button.stack:SetJustifyH("RIGHT")
      if index == 1 then
        button:SetPoint("CENTER")
      else
        button:SetPoint("LEFT",self.auraButtons[index-1],"RIGHT",10,0)
      end
      button:Hide()
      self.auraButtons[index] = button
      return button
    end
    function blizzPlate:UpdateAllAuras()
      local buttonIndex = 1
      for index, button in next, self.auraButtons do
        button:Hide()
      end
      for spellID, data in next, self.auras do
        local cooldown = data.expirationTime-GetTime()
        if cooldown < 0 then
          self:RemoveAura(spellID)
        else
          local button = self.auraButtons[buttonIndex] or self:CreateAuraButton(buttonIndex)
          --set texture
          button.icon:SetTexture(data.texture)
          --set cooldown
          button.cooldown:SetText(GetFormattedTime(cooldown))
          --set stackCount
          if data.stackCount and data.stackCount > 1 then
            button.stack:SetText(data.stackCount)
          else
            button.stack:SetText("")
          end
          button:Show()
          buttonIndex = buttonIndex + 1
        end
      end
    end
  end
 
  local function SkinPlate(blizzPlate)
    if plates[blizzPlate] then return end
    CreateNewPlate(blizzPlate)
    NamePlateOnInit(blizzPlate)
    SkinHealthBar(blizzPlate)
    SkinCastBar(blizzPlate)
    NamePlateSetup(blizzPlate)
    NamePlatePosition(blizzPlate)
    if not blizzPlate:IsShown() then
      blizzPlate.newPlate:Hide()
    end
    CreateNamePlateAuraFunctions(blizzPlate)
    blizzPlate:HookScript("OnShow", NamePlateOnShow)
    blizzPlate:HookScript("OnHide", NamePlateOnHide)
    blizzPlate.castBar:HookScript("OnShow", NamePlateCastBarUpdate)
    blizzPlate.castBar:HookScript("OnHide", NamePlateCastBarOnHide)
    blizzPlate.castBar:HookScript("OnValueChanged", NamePlateCastBarUpdate)
    blizzPlate.healthBar:HookScript("OnValueChanged", NamePlateHealthBarUpdate)
    NamePlateHealthBarUpdate(blizzPlate.healthBar)
    NamePlateHealthBarColor(blizzPlate)
    namePlateIndex = namePlateIndex+1
  end
 
  -----------------------------
  -- ONUPDATE
  -----------------------------
 
  local countFramesWithFullAlpha = 0
  local targetPlate = nil
  local delayCounter = 0
  local timer = 0.0
  local interval = 0.1
 
  WorldFrame:HookScript("OnUpdate", function(self, elapsed)
    timer = timer+elapsed
    countFramesWithFullAlpha = 0
    for blizzPlate, newPlate in next, plates do
      if blizzPlate:IsShown() then
        if blizzPlate:GetAlpha() == 1 then
          newPlate:SetAlpha(1)
        else
          newPlate:SetAlpha(cfg.notFocusedPlateAlpha)
        end
        if AuraModule.hasTarget and blizzPlate:GetAlpha() == 1 then
          countFramesWithFullAlpha = countFramesWithFullAlpha + 1
          targetPlate = blizzPlate
        end
        if AuraModule.updateMouseover and blizzPlate.highlightTexture:IsShown() and UnitGUID("mouseover") and UnitExists("mouseover") then
          NamePlateSetGUID(blizzPlate,UnitGUID("mouseover"))
          blizzPlate:ScanAuras("mouseover","HELPFUL")
          blizzPlate:ScanAuras("mouseover","HARMFUL")
          AuraModule.updateMouseover = false
        end
        if timer > interval then
          NamePlateHealthBarColor(blizzPlate)
          blizzPlate:UpdateAllAuras()
        end
      end
    end
    if timer > interval then
      timer = 0
    end
    if AuraModule.hasTarget and countFramesWithFullAlpha == 1 and (AuraModule.updateTarget or not targetPlate.guid) then
      --this may look wierd but is actually needed.
      --when the PLAYER_TARGET_CHANGED event fires the nameplate need one cycle to update the alpha, otherwise the old target would be tagged.
      if delayCounter == 1 then
        NamePlateSetGUID(targetPlate,UnitGUID("target"))
        targetPlate:ScanAuras("target","HELPFUL")
        targetPlate:ScanAuras("target","HARMFUL")
        AuraModule.updateTarget = false
        delayCounter = 0
        targetPlate = nil
      else
        delayCounter = delayCounter + 1
      end
    end
    if not namePlateIndex then
      for _, blizzPlate in next, {self:GetChildren()} do
        local name = blizzPlate:GetName()
        if name and string.match(name, "^NamePlate%d+$") then
          namePlateIndex = string.gsub(name,"NamePlate","")
          break
        end
      end
    else
      local blizzPlate = _G["NamePlate"..namePlateIndex]
      if not blizzPlate then return end
      SkinPlate(blizzPlate)
    end
  end)
 
  --reset some outdated (yet still active) bloat variables if people run old config.wtf files
  --setvar
  SetCVar("bloatnameplates",0)
  SetCVar("bloatthreat",0)
  SetCVar("bloattest",0)
 
  -----------------------------
  -- SLASH_COMMAND_LIST
  -----------------------------
 
  local color         = "FFFFAA00"
  local shortcut      = "rnp"
 
  local function HandleSlashCmd(cmd)
    if not spellDB then return end
    local spellID = tonumber(strsub(cmd, (strfind(cmd, " ") or 0)+1))
    if (cmd:match"blacklist") then
      print("|c"..color..an.." blacklist|r")
      if spellID and spellDB[spellID] then
        spellDB[spellID].blacklisted = true
        print(spellID,spellDB[spellID].name,"is now blacklisted")
      else
        print("no matching spellid found")
      end
    elseif (cmd:match"whitelist") then
      print("|c"..color..an.." whitelist|r")
      if spellID and spellDB[spellID] then
        spellDB[spellID].blacklisted = false
        print(spellID,spellDB[spellID].name,"is now whitelisted")
      else
        print("no matching spellid found")
      end
    elseif (cmd:match"list") then
      print("|c"..color..an.." list|r")
      print("spellID","|","name","|","blacklisted")
      print("------------------------------------")
      local count = 0
      for key, data in next, spellDB do
        if type(key) == "number" then
          print(key,"|",data.name,"|",data.blacklisted)
          count = count+1
        end
      end
      if count == 0 then
        print("list has no entries")
      end
    elseif (cmd:match"remove") then
      print("|c"..color..an.." remove|r")
      if spellID and spellDB[spellID] then
        print(spellID,spellDB[spellID].name,"removed")
        spellDB[spellID] = nil
      else
        print("no matching spellid found")
      end
    elseif (cmd:match"resetspelldb") then
      print("|c"..color..an.." resetspelldb|r")
      wipe(spellDB)
      print("spell db has been reset")
    elseif (cmd:match"disable") then
      print("|c"..color..an.." disable|r")
      spellDB.disabled = true
      print("spell db has been disabled")
    elseif (cmd:match"enable") then
      print("|c"..color..an.." enable|r")
      spellDB.disabled = false
      print("spell db has been enabled")
    else
      print("|c"..color..an.." command list|r")
      print("|c"..color.."\/"..shortcut.." list|r to list all entries in spellDB")
      print("|c"..color.."\/"..shortcut.." blacklist SPELLID|r to blacklist a spellid in spellDB")
      print("|c"..color.."\/"..shortcut.." whitelist SPELLID|r to whitelist a spellid in spellDB")
      print("|c"..color.."\/"..shortcut.." remove SPELLID|r to remove a spellid from spellDB")
      print("|c"..color.."\/"..shortcut.." disable|r to disable the spellDB for this character")
      print("|c"..color.."\/"..shortcut.." enable|r to enable the spellDB for this character")
      print("|c"..color.."\/"..shortcut.." resetspelldb|r to reset the spellDB for this character")
    end
  end
 
  --slash commands
  SlashCmdList[shortcut] = HandleSlashCmd
  SLASH_rnp1 = "/"..shortcut;
 
  print("|c"..color..an.." loaded.|r")
  print("|c"..color.."\/"..shortcut.."|r to display the command list")

So basically instead of using AuraModule.updateTarget I use a new variable AuraModule.hasTarget. Thus I'm able to recheck nameplates with no GUID.

Banknorris · 02-02-15, 03:18 AM

Originally Posted by zork

That is because the nameplate GUID is reset. (Because the OnHide has been triggered)

Do you really need to reset the GUID in the OnHide? Maybe you can store the timestamp of when OnHide triggered for the last time and remove GUID from hidden nameplates once every 10 min (or so) for all nameplates with a OnHide timestamp too old.

If the is a combat log event of that GUID dying then you can remove the info immediately (I guess).

Sorry if that makes no sense.

sticklord · 02-02-15, 10:38 AM

Originally Posted by Banknorris

Do you really need to reset the GUID in the OnHide? Maybe you can store the timestamp of when OnHide triggered for the last time and remove GUID from hidden nameplates once every 10 min (or so) for all nameplates with a OnHide timestamp too old.

If the is a combat log event of that GUID dying then you can remove the info immediately (I guess).

Sorry if that makes no sense.

You have no guarantee that it's the same nameplate that reshows when its been hidden. Not quite sure how it works but seems like theres a pool of them and it picks a random one. So you have to reset the guid.

And on topic, yeah tht's pretty much my way around it:

Lua Code:

if plate._Highlight:IsShown() then
        if not plate.highlighted then
            plate.highlighted = true
            plate.Highlight:Show()
            plate:SetGuid('mouseover') -- It's moused over, lets grab it while its hot
        end
    elseif plate.highlighted then
        plate.highlighted = nil
        plate.Highlight:Hide()
    end
 
    if isTarget then -- A boolean for alpha > 0.95 and UnitExist('target')
        if not plate.target then
            plate.target = true
            plate:SetGuid('target')
            plate:SetFrameLevel(5)
            plate.Glow:Show()
        end
    elseif plate.target then
        plate.target = nil
        plate:SetFrameLevel(0)
        plate.Glow:Hide()
    end

This is an OnUpdate for every nameplate though, I use it for abit more aswell.

Oppugno · 02-04-15, 02:07 AM

My preferred method is via the use of events/script handlers as opposed to polling (via OnUpdate).

A couple of facts that have already been mentioned but I'm going to mention them again as they're important for the explanation:

We know that when a nameplate belongs to the 'target' unit only that nameplate has an alpha of 1, all others have a lesser amount.
Nameplate alphas don't update until a frame after they are visible and a frame after the PLAYER_TARGET_CHANGED event fires.
When a nameplate is hidden it can no longer be relied upon to have the same correlation between units or GUIDs when/if re-shown.

From this you can expand out what needs to happen in response to each event (I've used your function names for ease):

NamePlateOnShow:

If you have a target and don't know the nameplate wait one frame and then check if the nameplate's alpha == 1.

NamePlateOnInit:

This is essentially a special case of OnShow as we had to wait one frame in order to find it via the main update function. The nameplate's alpha is already up to date so you check if alpha == 1 right away.

NamePlateOnHide:

Wipe any correlation you had established for this nameplate.

AuraModule:PLAYER_TARGET_CHANGED:

The target has changed. Wait one frame and then search all active nameplates for the one with an alpha == 1.

I've put together a dry coded version with the relevant sections of your code:

Lua Code:

local AuraModule = CreateFrame("Frame")
--[[
    Your stuff here...
]]--
AuraModule.hasTarget        = false -- if there is a target that could be a nameplate
AuraModule.updateTarget     = false -- if the target's nameplate is known / needs to be updated
 
AuraModule:Hide()
AuraModule:SetScript('OnUpdate', function(self, elapsed)
    if self.hasTarget and self.updateTarget then -- Some (mostly) unneeded redundancy, remove if you want.
        for blizzPlate in next, plates do
            if blizzPlate:IsShown() then -- Note: You should probably consider removing the need for this.
                if blizzPlate:GetAlpha() == 1 then
                    NamePlateSetGUID(blizzPlate,UnitGUID("target"))
                    blizzPlate:ScanAuras("target","HELPFUL")
                    blizzPlate:ScanAuras("target","HARMFUL")
                    
                    -- Stop any other nameplates from trying to update the target.
                    self.updateTarget = false
                    break
                end
            end
        end
    end
    self:Hide()
end)
 
-- Some aliases for readability.
AuraModule.ExecuteDelayedTargetSearch = AuraModule.Show
AuraModule.PreventDelayedTargetSearch = AuraModule.Hide
 
function AuraModule:PLAYER_TARGET_CHANGED(...)
    --[[
        Your stuff here...
    ]]--
    
    if UnitExists("target") and UnitGUID("target") and not UnitIsUnit("target","player") and not UnitIsDead("target") then
        self.updateTarget = true
        self.hasTarget = true
        self:ExecuteDelayedTargetSearch() -- Look for the target's nameplate on the next frame.
    else
        self.updateTarget = false
        self.hasTarget = false
        self:PreventDelayedTargetSearch() -- Stop any delayed target nameplate search.
    end
end
 
local function NamePlateOnInit(blizzPlate)
    --[[
        Your stuff here...
    ]]--
 
    if AuraModule.hasTarget and AuraModule.updateTarget then -- Have a target but don't know the nameplate.
        -- Plate alphas are accurate when first found because we had to wait a frame to find them.
        if blizzPlate:GetAlpha() == 1 then
            NamePlateSetGUID(blizzPlate,UnitGUID("target"))
            blizzPlate:ScanAuras("target","HELPFUL")
            blizzPlate:ScanAuras("target","HARMFUL")
            
            -- Stop any other nameplates from trying to update the target.
            AuraModule.updateTarget = false
            AuraModule:PreventDelayedTargetSearch() -- Stop any delayed target nameplate search.
        end
    end
end
 
local function NamePlateOnShow(blizzPlate)
    --[[
        Your stuff here...
    ]]--
    
    if AuraModule.hasTarget and AuraModule.updateTarget then -- Have a target but don't know the nameplate.
        -- Plate alphas are updated correctly a frame AFTER being reshown.
        AuraModule:ExecuteDelayedTargetSearch() -- Look for the target's nameplate on the next frame.
    end
end
 
local function NamePlateOnHide(blizzPlate)
    --[[
        Your stuff here...
    ]]--
end

Note that this example issues a complete delayed search in NamePlateOnShow instead of targeted check on the current nameplate. This dry code doesn't have the functionality to efficiently handle checking a subset of nameplates. If you did it this way I'd suggest additional functionality that adds all nameplates re-shown on a given frame to a special list which is checked by a separate delayed search function. Even if you don't implement this particular functionality it is still more practically efficient this way as you currently check all active nameplate each frame. In the worst possible case to reach the same O(n) you would have to be finding a new nameplate each frame or changing targets every frame.

Keen minds will also realise that if you run a delayed search and a frame after some nameplates are re-shown that they would have non-updated alphas and break the search. I've found that I could never get the nameplate's OnShow scripts to fire prior to the search frame's OnUpdate unless I intentionally delayed it. In the event that you do manage to have them show before the search's OnUpdate fires just delay their addition to the list of active nameplates by one frame.

P.S. Not that it really matters but isn't this in the wrong sub-forum (I'd expect General Authoring Discussion as opposed to Lua/XML Help)?

zork · 02-04-15, 02:38 AM

I tested my idea yesterday.
https://code.google.com/p/rothui/sou...s.lua&old=1361
It works perfectly.

@Oppugno
You need the OnUpdate anyway to scan for nameplates. I use that single OnUpdate script for everything.

First I do WorldFrame scans until I find the first evidence of a nameplate and thus the current nameplate index. That index increases on each /reload. After that I just check if _G["NamePlate"..nextIndex] exists. If it does I skin it.

Funny that you found out about the 1frame delay of alpha states aswell.

The AuraModule inside the OnUpdate is event driven. Thus the conditions will not trigger without a leading event. The only exception is the nameplate scan if I have a target and that nameplate has no GUID. After a delay of 1 frame I can be sure that this nameplate is matching the target.

The only part that I really don't like atm is the mixin of local and object functions. Currently each nameplate gets a set of functions. I could just make a single function and pass the nameplate as a parameter.

Oppugno · 02-04-15, 05:56 AM

I'm not saying to remove the OnUpdate, that's definently needed for the core. I was just saying move unneeded stuff out of it. For instance, to make my core match yours this would be my entire core (additions, removals):

Code:

--[[------------------------------------
--            Update Core             --
------------------------------------]]--
-- Upvalues
local select = select
local WorldFrame = WorldFrame
local _G = _G

-- Constants
local NAMEPLATE_NAME = 'NamePlate'
local NAMEPLATE_PATTERN = '^'..NAMEPLATE_NAME..'%d+$'

local nameplateIndex = nil

local PreviouslySeenFrames = {}
function Driver:SearchForNameplates(...)
	for i = 1, select("#", ...) do
		local frame = select(i, ...)
		if not PreviouslySeenFrames[frame] then -- Haven't seen the frame before.
			PreviouslySeenFrames[frame] = true
			
			local name = frame:GetName()
			if name and name:find(NAMEPLATE_PATTERN) then -- Is a nameplate
				nameplateIndex = tonumber((string.gsub(name, NAMEPLATE_NAME, '')))
				self:LookUpNameplates()
				
				-- Free up no longer needed table.
				PreviouslySeenFrames = nil
				break
			end
		end
	end
end

function Driver:LookUpNameplates()
	-- This string concatenation could/does happen every frame.
	-- IDEA: Cache it in addition to the nameplateIndex
	local nameplate = _G[NAMEPLATE_NAME..nameplateIndex]
	while nameplate do
		Nameplate.Initialise(nameplate)

		nameplateIndex = nameplateIndex + 1
		nameplate = _G[NAMEPLATE_NAME..nameplateIndex]
	end
end

local WorldFrame_NumChildren = 0
Driver:SetScript('OnUpdate', function(self, elapsed)
	-- Find any new nameplates
	if nameplateIndex then
		self:LookUpNameplates()
	else
		local numChildren = WorldFrame:GetNumChildren()
		if numChildren ~= WorldFrame_NumChildren then
			--Scan for nameplates
			self:SearchForNameplates(WorldFrame:GetChildren())
			
			WorldFrame_NumChildren = numChildren
		end
	end

	-- Update alphas of all active nameplates
	for nameplate, oldNameplate in pairs(ActiveNameplates) do
		nameplate:SetAlpha(oldNameplate:GetAlpha())
	end


	timer = timer + elapsed
	
	if timer <= interval then -- reversed the condition as this is going to be true more often
		for blizzPlate, newPlate in next, plates do
			if blizzPlate:GetAlpha() == 1 then
				newPlate:SetAlpha(1)
			else
				newPlate:SetAlpha(cfg.notFocusedPlateAlpha)
			end
		end
	else -- timer > interval
		-- Yes, this for block has to be duplicated but it's stupidly more efficient 
		-- than before without a million pipeline stalls from the failed ifs.
		for blizzPlate, newPlate in next, plates do
			if blizzPlate:GetAlpha() == 1 then
				newPlate:SetAlpha(1)
			else
				newPlate:SetAlpha(cfg.notFocusedPlateAlpha)
			end
			
			NamePlateHealthBarColor(blizzPlate)
			blizzPlate:UpdateAllAuras()
		end
		
		timer = 0
	end
end)

All Target, Mouseover and RaidIcon nameplates are identified by event handlers that don't use OnUpdate. As a side bonus of this you could also seperate that additional nameplate logic from the core OnUpdate into each nameplate's OnUpdate to fit your object orientated approach.

Miss-communications cleared up (hopefully), I'm glad your approach worked for you.

P.S. Keep up the good work. I appreciated the insights you shared about the moving of shown nameplates and the use of indexing instead of parsing WorldFrame's children.