Custom Scripts

[Resike]

I'm not very experience in callbacks, but is it possible to create a custom scripts for a frame which will get triggered just like the "OnShow"/"OnHide" ones but i manage what will trigger them?

[Malakahh]

If I understand you correctly, you're looking to create custom events?

[zork]

Well. The only events you can rely on are the events provided by the API.

If there is no event in the API that is triggering whatever you need to ask for you can fall back to an OnUpdate script checking stuff every now and then.

And there is :HookScript. http://www.wowwiki.com/API_Frame_HookScript

[Dridzt]

You can fire custom events using AceEvent-3.0 or even simpler with Callbackhandler-1.0

[Resike]

I have a total custom dropdown, each time the user changes it's value, i would like to update it's propesions, however there are more dropdowns created by the same template, so i need something like the OnValueChanged script for sliders.

The only workaround i managed to pull out, is to hide/show a totally irrelevant invisible frame and listen it's OnShow/OnHide. But it's sounds like a pretty dumb solution.

[kurapica.igas]

Well, if you only need one event handler for one frame's event, it's simple to do it , just add one method to your frame, like :

------------------------------
-- Template part
------------------------------
local function Fire(self, event, ...)
    return type(self[event]) == "function" and self[event](self, ...)
end
 
local function OnClick(self)
    return self.Parent:Fire("OnValueChanged", self:GetID())
end
 
function CreateDropDownMenu( ... )
    local menu = CreateFrame("Frame", ...)
 
    -- Give it a new method
    menu.Fire = Fire
 
    -- Create menu buttons
    for i = 1, 10 do
        local btn = CreateFrame("Button", nil, menu)
        btn:SetID(i)
        btn.Parent = menu
 
        btn:SetScript("OnClick", OnClick)
    end
 
    return menu
end
 
------------------------------
-- Test part
------------------------------
local menu = CreateDropDownMenu()
 
function menu:OnValueChanged(value)
    -- action
end

[Phanx]

Originally Posted by Resike I have a total custom dropdown, each time the user changes it's value, i would like to update it's propesions, however there are more dropdowns created by the same template, so i need something like the OnValueChanged script for sliders.

This seems pretty straightforward... without seeing your code (sigh) it's impossible to give you a specific solution, but I assume your template already has some way to detect when the user clicks on an item in the menu and call some function (eg. to update a value in your settings table) so why can't you just update whatever you want to update (I'm not sure what you meant there where you wrote "propesions") in that function?

[zork]

@Resike
Here is what I do on my dropdowns.

local dropdownMenu = createBasicDropDownMenu(parent, addon.."PanelHealthOrbFillingTexture", "Choose texture", db.getListFillingTexture, 196)
    dropdownMenu.click = function(self)
      UIDropDownMenu_SetSelectedValue(dropdownMenu, self.value)
      --save value
      panel.saveHealthOrbFillingTexture(self.value)
      --update orb view
      panel.updateHealthOrbFillingTexture()
    end

https://code.google.com/p/rothui/sou.../panel.lua#292

A dropdown item has the "func" attribute. It is called oncllick. I set that to my click handler. So basically what I do in my template function is this.

if not self.info.hasArrow then
  self.info.func = self.click or nil
end
UIDropDownMenu_AddButton(self.info, level)

[Resike]

Originally Posted by kurapica.igas Well, if you only need one event handler for one frame's event, it's simple to do it , just add one method to your frame, like : ------------------------------ -- Template part ------------------------------ local function Fire(self, event, ...)     return type(self[event]) == "function" and self[event](self, ...) end   local function OnClick(self)     return self.Parent:Fire("OnValueChanged", self:GetID()) end   function CreateDropDownMenu( ... )     local menu = CreateFrame("Frame", ...)       -- Give it a new method     menu.Fire = Fire       -- Create menu buttons     for i = 1, 10 do         local btn = CreateFrame("Button", nil, menu)         btn:SetID(i)         btn.Parent = menu           btn:SetScript("OnClick", OnClick)     end       return menu end   ------------------------------ -- Test part ------------------------------ local menu = CreateDropDownMenu()   function menu:OnValueChanged(value)     -- action end

I think this is what i need. Thanks.

[Resike]

My code looks like this, and i would like to replace the "OnHide" part:

local function CreateDropDown(frame, parent, list)
    frame = CreateFrame("Button", nil, parent)
    frame:SetWidth(200)
    frame:SetHeight(26)
    frame:SetBackdrop({
        bgFile = "Interface\\Buttons\\White8X8",
        edgeFile = "Interface\\Tooltips\\UI-Tooltip-Border",
        tile = true,
        tileSize = 16,
        edgeSize = 14,
        insets = {left = 2, right = 2, top = 2, bottom = 2}
    })
    frame:SetBackdropColor(0, 0, 0, 1)
    frame:SetBackdropBorderColor(0.3, 0.3, 0.3, 1.0)
    frame:SetHitRectInsets(0, 0, 0, 0)
    frame:SetScript("OnEnter", function(self)
        self:SetBackdropBorderColor(0.5, 0.5, 0.5, 1.0)
    end)
    frame:SetScript("OnLeave", function(self)
        self:SetBackdropBorderColor(0.3, 0.3, 0.3, 1.0)
    end)
    frame:SetScript("OnShow", function(self)
        frame.Menu:Hide()
    end)
    frame.List = list
    frame.Menu = CreateFrame("Frame", nil, frame)
    frame.Menu:SetPoint("TopLeft", frame, "BottomLeft", 0, 2)
    frame.Menu:SetWidth(frame:GetWidth())
    frame.Menu:SetHeight(20 * #frame.List + 10)
    frame.Menu:SetBackdrop({
        bgFile = "Interface\\Buttons\\White8X8",
        edgeFile = "Interface\\Tooltips\\UI-Tooltip-Border",
        tile = true,
        tileSize = 16,
        edgeSize = 14,
        insets = {left = 2, right = 2, top = 2, bottom = 2}
    })
    frame.Menu:SetBackdropColor(0, 0, 0, 1)
    frame.Menu:SetBackdropBorderColor(0.3, 0.3, 0.3, 1.0)
    frame.Menu:SetScript("OnEnter", function(self)
        self:SetBackdropBorderColor(0.5, 0.5, 0.5, 1.0)
    end)
    frame.Menu:SetScript("OnLeave", function(self)
        self:SetBackdropBorderColor(0.3, 0.3, 0.3, 1.0)
    end)
    frame.Menu:SetScript("OnShow", function(self)
        CloseDropDownMenus()
        --[[frame:SetNormalTexture("Interface\\ChatFrame\\UI-ChatIcon-ScrollUp-Up")
        frame:SetDisabledTexture("Interface\\ChatFrame\\UI-ChatIcon-ScrollUp-Disabled")
        frame:SetPushedTexture("Interface\\ChatFrame\\UI-ChatIcon-ScrollUp-Down")]]
    end)
    --[[frame.Menu:SetScript("OnHide", function(self, button)
        frame:SetNormalTexture("Interface\\ChatFrame\\UI-ChatIcon-ScrollDown-Up")
        frame:SetDisabledTexture("Interface\\ChatFrame\\UI-ChatIcon-ScrollDown-Disabled")
        frame:SetPushedTexture("Interface\\ChatFrame\\UI-ChatIcon-ScrollDown-Down")
    end)]]
    frame.Menu:Hide()
    for i = 1, #frame.List do
        frame.Menu[i] = CreateFrame("CheckButton", nil, frame.Menu)
        if not frame.List.LastChild then
            frame.Menu[i]:SetPoint("TopLeft", frame.Menu, "TopLeft", 5, -5)
        else
            frame.Menu[i]:SetPoint("TopLeft", frame.List.LastChild, "BottomLeft", 0, 0)
        end
        frame.Menu[i]:SetSize(20, 20)
        frame.Menu[i]:SetHitRectInsets(0, -frame:GetWidth() + 10 + frame.Menu[i]:GetWidth(), 0, 0)
        frame.Menu[i]:SetNormalFontObject(GameFontHighlightSmall)
        frame.Menu[i]:SetDisabledFontObject(GameFontHighlightSmall)
        frame.Menu[i]:SetHighlightFontObject(GameFontHighlightSmall)
        frame.Menu[i]:SetNormalTexture("Interface\\Buttons\\UI-CheckBox-Up")
        --frame.Menu[i]:GetNormalTexture():SetSize(20, 20)
        --frame.Menu[i]:GetNormalTexture():ClearAllPoints()
        --frame.Menu[i]:GetNormalTexture():SetPoint("TOPLEFT", 0, 0)
        frame.Menu[i]:SetCheckedTexture("Interface\\Buttons\\UI-Common-MouseHilight")
        frame.Menu[i]:SetHighlightTexture("Interface\\Buttons\\UI-CheckBox-Highlight")
        --frame.Menu[i]:GetCheckedTexture():SetSize(20, 20)
        --frame.Menu[i]:GetCheckedTexture():ClearAllPoints()
        --frame.Menu[i]:GetCheckedTexture():SetPoint("TOPLEFT", 0, 0)
        frame.Menu[i].Text = frame.Menu[i]:CreateFontString(nil, "Overlay")
        frame.Menu[i].Text:SetJustifyH("Left")
        frame.Menu[i].Text:SetJustifyV("Middle")
        frame.Menu[i].Text:SetWordWrap(false)
        frame.Menu[i].Text:SetPoint("Left", frame.Menu[i], "Right", 5, 0)
        --frame.Menu[i].Text:SetVertexColor(1, 1, 1)
        frame.Menu[i]:SetFontString(frame.Menu[i].Text)
        frame.Menu[i].Text:SetText(frame.List[i])
        frame.List.LastChild = frame.Menu[i]
        frame.Menu[i]:SetScript("OnEnter", function(self)
            frame.Menu:SetBackdropBorderColor(0.5, 0.5, 0.5, 1.0)
            self.Text:SetVertexColor(1, 0.82, 0)
        end)
        frame.Menu[i]:SetScript("OnLeave", function(self)
            frame.Menu:SetBackdropBorderColor(0.3, 0.3, 0.3, 1.0)
            self.Text:SetVertexColor(1, 1, 1)
        end)
        frame.Menu[i]:SetScript("OnClick", function(self, button)
            if button == "LeftButton" then
                for j = 1, #frame.Menu do
                    local k = frame.Menu[j]
                    if k ~= self then
                        k:SetChecked(false)
                    else
                        if not self:GetChecked() then
                            self:SetChecked(true)
                        end
                    end
                end
                frame.selected = frame.List[i]
                frame.Text:SetText(frame.selected)
                frame.Menu:Hide()
            end
        end)
    end
    frame.Title = frame:CreateFontString(nil, "Overlay")
    frame.Title:SetFontObject(GameFontNormal)
    frame.Title:SetJustifyV("Middle")
    frame.Title:SetJustifyH("Left")
    frame.Title:SetWordWrap(false)
    frame.Title:SetSize(100, 20)
    frame.Title:SetPoint("BottomLeft", frame, "TopLeft", 3, 0)
    frame.Title:SetPoint("BottomRight", frame, "TopRight", -3, 0)
    frame.Text = frame:CreateFontString(nil, "Overlay")
    frame.Text:SetFontObject(GameFontHighlightSmall)
    frame.Text:SetJustifyH("Left")
    frame.Text:SetJustifyV("Middle")
    frame.Text:SetWordWrap(false)
    frame.Text:SetPoint("TOPLEFT", 8, -2)
    frame.Text:SetPoint("BottomRight", -28, 2)
    frame:SetFontString(frame.Text)
    local t = frame:CreateTexture(nil, "Artwork")
    t:SetTexture("Interface\\ChatFrame\\UI-ChatIcon-ScrollDown-Up")
    t:SetPoint("TopRight")
    t:SetPoint("BottomRight")
    t:SetSize(26, 26)
    frame:SetNormalTexture(t)
    local t = frame:CreateTexture(nil, "Artwork")
    t:SetTexture("Interface\\ChatFrame\\UI-ChatIcon-ScrollDown-Disabled")
    t:SetPoint("TopRight")
    t:SetPoint("BottomRight")
    t:SetSize(26, 26)
    frame:SetDisabledTexture(t)
    local t = frame:CreateTexture(nil, "Artwork")
    t:SetTexture("Interface\\ChatFrame\\UI-ChatIcon-ScrollDown-Down")
    t:SetPoint("TopRight")
    t:SetPoint("BottomRight")
    t:SetSize(26, 26)
    frame:SetPushedTexture(t)
    local t = frame:CreateTexture(nil, "Artwork")
    t:SetTexture("Interface\\ChatFrame\\UI-ChatIcon-BlinkHilight")
    t:SetBlendMode("ADD")
    t:SetPoint("TopRight")
    t:SetPoint("BottomRight")
    t:SetSize(26, 26)
    frame:SetHighlightTexture(t)
    frame:SetScript("OnClick", function(self, button)
        if button == "LeftButton" then
            if frame.Menu:IsShown() then
                frame.Menu:Hide()
            else
                frame.Menu:Show()
            end
        end
    end)
    function frame:GetSelected()
        return frame.selected
    end
    function frame:SetSelected(value)
        frame.selected = value
        for i = 1, #frame.List do
            if frame.List[i] == value then
                frame.Menu[i]:SetChecked(true)
            else
                frame.Menu[i]:SetChecked(false)
            end
        end
        frame.Text:SetText(value)
    end
    return frame
end
 
local list = {
    [1] = "First",
    [2] = "Second",
    [3] = "Third"
}
 
local dropdown = CreateDropDown(dropdown, UIParent, list)
dropdown:SetSelected("First")
dropdown:SetPoint("Center", UIParent, "Center", 0, 0)
dropdown.Title:SetText("Title")
dropdown.Menu:SetScript("OnHide", function(self)
    -- Save Value
    print(dropdown:GetSelected())
end)

[Resike]

So what do you guys thing about it? It easy to use, no taints, very compact and goes easy on the resources too.



https://github.com/Resike/MoveAnythi...s/DropDown.lua

I need to come up with a better idea about the :RefreshList() tho.

[Phanx]

Well:

function DropDown:CreateDropDown(frame, parent, list)
    frame = CreateFrame("Button", nil, parent)

Whatever you're passing in as the first argument here is immediately overwritten; I'd suggest not bothering passing anything, and just do this instead:

function DropDown:CreateDropDown(parent, list)
    local frame = CreateFrame("Button", nil, parent)

But the main problems I see are that

1) You're creating a lot of duplicate copies of all your script handler functions. If you have 5 dropdowns that each have 10 list items, you've created 200 functions, plus another 30 functions every time you call your RefreshList function, where you only needed to create 16 total functions regardless of the number of dropdowns or items. Define each of those functions once, outside of the CreateDropDown function, and then refer to them inside, just like you did with your Fire function.

2) If you have a dropdown with 10 list items, then you're creating 10 frames when you create the dropdown, then another 10 frames every time you call RefreshList. You should be reusing those frames instead.

Also, there is absolutely no benefit to upvaluing any of these things:

local table = table
local type = type

local CloseDropDownMenus = CloseDropDownMenus
local CreateFrame = CreateFrame
local GameFontHighlight = GameFontHighlight
local GameFontHighlightSmall = GameFontHighlightSmall
local GameFontNormal = GameFontNormal

If you're ever calling any of those functions, or referring to any of those objects, so frequently that an upvalue is doing anything other than cluttering up your code, you're doing something seriously wrong; in your case, you're not using any of them with any frequency at all, so it's just clutter.

----------

I don't really feel like rewriting your code for you right now, but you may find something useful in here:
https://github.com/phanx/PhanxConfig...ngDropdown.lua

[Resike]

Originally Posted by Phanx Well: function DropDown:CreateDropDown(frame, parent, list) frame = CreateFrame("Button", nil, parent) Whatever you're passing in as the first argument here is immediately overwritten; I'd suggest not bothering passing anything, and just do this instead: function DropDown:CreateDropDown(parent, list) local frame = CreateFrame("Button", nil, parent)

To be honest this is my first try to create a template like this, so ofc it's not perfect. I'll fix this one for sure.

Originally Posted by Phanx But the main problems I see are that 1) You're creating a lot of duplicate copies of all your script handler functions. If you have 5 dropdowns that each have 10 list items, you've created 200 functions, plus another 30 functions every time you call your RefreshList function, where you only needed to create 16 total functions regardless of the number of dropdowns or items. Define each of those functions once, outside of the CreateDropDown function, and then refer to them inside, just like you did with your Fire function. 2) If you have a dropdown with 10 list items, then you're creating 10 frames when you create the dropdown, then another 10 frames every time you call RefreshList. You should be reusing those frames instead.

I know this is just a temporarly solution for now, the issue is i would like to keep the list sorted mostly, and i couldn't come up with a solution about how can i insert a button where it belongs allphabetically each time you add a new list item.

[p3lim]

Originally Posted by Resike I know this is just a temporarly solution for now, the issue is i would like to keep the list sorted mostly, and i couldn't come up with a solution about how can i insert a button where it belongs allphabetically each time you add a new list item.

buttons = {
  {name = 'one', callback = function() end, ...},
  {name = 'two', callback = function() end, ...}
}

table.sort(buttons, function(a, b)
  return a.name > b.name
end)

[Torhal]

The sort func should be returning the result of the comparison, though.

[p3lim]

Originally Posted by Torhal The sort func should be returning the result of the comparison, though.

Yeah, forgot about that part. :]

[Resike]

Originally Posted by p3lim buttons = { {name = 'one', callback = function() end, ...}, {name = 'two', callback = function() end, ...} } table.sort(buttons, function(a, b) return a.name > b.name end)

The issue is not really with the sorting part, more likely the hassle that comes with the inserting. (Repositioning, reindexing, copying the tables around.) Recreating the whole thing seemed easier.