Thread Tools Display Modes
03-23-13, 03:27 PM   #1
zork
A Pyroguard Emberseer
 
zork's Avatar
AddOn Author - Click to view addons
Join Date: Jul 2008
Posts: 1,740
5.2 secure menu

Is the new secure menu for all units?

If yes why do header units still call "menu" and not "togglemenu"?

I tried changing "menu" to "togglemenu" in ouf.lua and in a group the new menu will pop up.

*edit*

Oh that was quick. haste merged the change request into 1.6.4. So the change is in the commit already.
__________________
| Simple is beautiful.
| WoWI AddOns | GitHub | Zork (WoW)

"I wonder what the non-pathetic people are doing tonight?" - Rajesh Koothrappali (The Big Bang Theory)

Last edited by zork : 03-23-13 at 06:46 PM.
  Reply With Quote
03-23-13, 03:41 PM   #2
Nibelheim
local roygbi-
 
Nibelheim's Avatar
AddOn Author - Click to view addons
Join Date: Jan 2010
Posts: 1,600
Originally Posted by zork View Post
Is the new secure menu for all units?

If yes why do header units still call "menu" and not "togglemenu"?

I tried changing "menu" to "togglemenu" in ouf.lua and in a group the new menu will pop up.
Good question!
  Reply With Quote
03-23-13, 03:42 PM   #3
zork
A Pyroguard Emberseer
 
zork's Avatar
AddOn Author - Click to view addons
Join Date: Jul 2008
Posts: 1,740
I ripped all my menu code. Works beautifully. Thanks for the new menu call.

I made a pull request for the togglemenu change via Github.
__________________
| Simple is beautiful.
| WoWI AddOns | GitHub | Zork (WoW)

"I wonder what the non-pathetic people are doing tonight?" - Rajesh Koothrappali (The Big Bang Theory)
  Reply With Quote
03-26-13, 11:40 AM   #4
Rainrider
A Firelord
AddOn Author - Click to view addons
Join Date: Nov 2008
Posts: 454
I got this yesterday with the new menus: https://github.com/haste/oUF/issues/182 resulting in no dropdown menus for raid units. Maybe someone has a solution
  Reply With Quote
03-27-13, 04:36 PM   #5
zork
A Pyroguard Emberseer
 
zork's Avatar
AddOn Author - Click to view addons
Join Date: Jul 2008
Posts: 1,740
I can confirm the lua error. Wierd. No problem for party units though.

http://imgur.com/XJnsGmQ
__________________
| Simple is beautiful.
| WoWI AddOns | GitHub | Zork (WoW)

"I wonder what the non-pathetic people are doing tonight?" - Rajesh Koothrappali (The Big Bang Theory)
  Reply With Quote
03-28-13, 04:38 AM   #6
Dridzt
A Pyroguard Emberseer
 
Dridzt's Avatar
AddOn Author - Click to view addons
Join Date: Nov 2005
Posts: 1,360
This was recently fixed in SUF (and possibly Clique) in any case their changelogs will provide some insight, it's a Blizzard bug (that has a workaround) afaik.
  Reply With Quote
03-28-13, 05:48 AM   #7
zork
A Pyroguard Emberseer
 
zork's Avatar
AddOn Author - Click to view addons
Join Date: Jul 2008
Posts: 1,740
Both Cladhaire and Shadowed posted that it is ineed a Blizzard bug.

Cladhaire's workaround:
Lua Code:
  1. http://git.wowinterface.com/?a=commitdiff&p=Clique&h=3295be21cea50e68fe41d7641c8a7d128144141a

I cannot find any GIT from Shadowed.

Basically it comes down to rewriting the menu call for raid units from togglemenu back to menu. Which is "meh".
__________________
| Simple is beautiful.
| WoWI AddOns | GitHub | Zork (WoW)

"I wonder what the non-pathetic people are doing tonight?" - Rajesh Koothrappali (The Big Bang Theory)
  Reply With Quote

WoWInterface » Featured Projects » oUF (Otravi Unit Frames) » 5.2 secure menu


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off