colouring quest rewards by quality.

[ObbleYeah]

Hello, I'm working on a simple little script to colour quest reward item names by their quality. This is what I have currently:

-- colour quest reward names by quality -------------------------------------------------
 
    local function ColourRewards(qinfo)
        local isquestlog = QuestInfoFrame.questLog      
        local numQuestChoices = isquestlog and GetNumQuestLogChoices() or GetNumQuestChoices()
        local _, quality
        
        for i = 1, numQuestChoices, 1 do
            qinfo.type = "choice"
            if isquestlog then
                _, _, _, quality = GetQuestLogChoiceInfo(i)
            else
                _, _, _, quality = GetQuestItemInfo(qinfo.type, i)
            end
                
            local colour = ITEM_QUALITY_COLORS[quality]
                            
            -- only colour item if it's uncommon +
            if qinfo.Name and quality>=2 then
                qinfo.Name:SetTextColor(colour.r, colour.g, colour.b)
            else
                qinfo.Name:SetTextColor(1, 1, 1)
            end
        end
    end
 
    hooksecurefunc("QuestInfo_GetRewardButton", function(rewardsFrame, index)
        local q = rewardsFrame.RewardButtons[index]
 
        ColourRewards(q)
    end)

the issue is that whilst this works, it doesn't update properly. As far as I can tell it only updates if the level of quality of the reward increases. So a white reward will successfully change to a green one when I click through quests in my log, or a green will change to a blue, but a blue won't go back to being a green or white. Which leads to this:

(garrison resources are a white item)

any ideas what i'm doing wrong? am i hooking the wrong function or something?

[semlar]

I don't believe that these are "choices" (you don't pick one of these rewards, you just get them).

Therefor you should also be iterating over GetNumQuestRewards() / GetNumQuestLogRewards() to color these (and GetQuestLogRewardInfo in place of GetQuestLogChoiceInfo).

Don't set qinfo.type = "choice", either.

[ObbleYeah]

ah! thankyou.

[Phanx]

This is what I use to add borders + quality coloring to the quest items:

-- Common:

local function ColorByItemQuality(frame, quality, link)
	if link and not quality then
		local _ -- LINE BREAK IS INTENTIONAL
		_, _, quality = GetItemInfo(link or 0)
	end

	if quality and quality > 1 then
		local color = ITEM_QUALITY_COLORS[quality]
		frame:SetBorderColor(color.r, color.g, color.b)
	else
		frame:SetBorderColor()
		-- My border code uses the default color if no values
		-- are provided. Adjust as needed for your code.
	end
end

-- Quest rewards:

	for i = 1, MAX_NUM_ITEMS do
		AddBorder(_G["QuestInfoItem"..i])
	end

	hooksecurefunc("QuestInfo_Display", function()
		for i = 1, MAX_NUM_ITEMS do
			local f = _G["QuestInfoItem"..i]
			local link = f.type and (QuestInfoFrame.questLog and GetQuestLogItemLink or GetQuestItemLink)(f.type, f:GetID())
			ColorByItemQuality(f, nil, link)
		end
	end)

-- Quest required items:

	for i = 1, MAX_REQUIRED_ITEMS do
		AddBorder(_G["QuestProgressItem"..i])
	end

	hooksecurefunc("QuestFrameProgressItems_Update", function()
		for i = 1, MAX_REQUIRED_ITEMS do
			local f = _G["QuestProgressItem"..i]
			local link = f.type and GetQuestItemLink(f.type, f:GetID())
			ColorByItemQuality(f, nil, link)
		end
	end)

[ObbleYeah]

that's giving me an error on the beta:

attempt to index local "f" (a nil value)

in relation to this line of the QuestInfo_Display hook

local link = f.type and (QuestInfoFrame.questLog and GetQuestLogItemLink or GetQuestItemLink)(f.type, f:GetID())

[ObbleYeah]

my code with semlar's changes is working fine _apart_ from when i talk to quest givers, at which point i receive the following error (+ no recolouring takes place):

Invalid quest item in GetQuestItemInfo("type", index)

here's the new version:

-- colour quest reward names by quality -------------------------------------------------
 
    local function ColourRewards(qinfo)
        local isquestlog = QuestInfoFrame.questLog      
        local numQuestChoices = isquestlog and GetNumQuestLogChoices() or GetNumQuestChoices()
        local numQuestRewards = isquestlog and GetNumQuestLogRewards() or GetNumQuestRewards()
        local _, quality
                
        for i = 1, numQuestChoices, 1 do
            if isquestlog then
                _, _, _, quality = GetQuestLogChoiceInfo(i)
            else
                 _, _, _, quality = GetQuestItemInfo(qinfo.type, i)
            end
        end
        for i = 1, numQuestRewards, 1 do
            if isquestlog then
                _, _, _, quality = GetQuestLogRewardInfo(i)
            else
                _, _, _, quality = GetQuestItemInfo(qinfo.type, i)
            end
        end
        
        local colour = ITEM_QUALITY_COLORS[quality]     
                            
        -- only colour item if it's uncommon +
        if qinfo.Name and quality and quality>=2 then
            qinfo.Name:SetTextColor(colour.r, colour.g, colour.b)
        else
            qinfo.Name:SetTextColor(1, 1, 1)
        end
    end
 
    hooksecurefunc("QuestInfo_GetRewardButton", function(rewardsFrame, index)
        local q = rewardsFrame.RewardButtons[index]
 
        ColourRewards(q)
    end)

error is in relation to line 20. I assume I need to filter based on whether i'm dealing with "reward" or "choice"?

[semlar]

Rather than qinfo.type, just use the strings 'choice' and 'reward' because the type won't be set when QuestInfo_GetRewardButton is called.

[ObbleYeah]

quality for a blue item reward seems to be returning as -1?

[semlar]

You have your text-coloring part outside of your for loops.

Actually this won't work at all because you're looping over all of the rewards but not referencing any buttons except the one being fed to the hooked function.

[ObbleYeah]

weird that other quests seem to be reporting fine, just been that one instance otherwise so far.



anyway, the beta servers shitting the bed and i'm tired so I'll look at this with fresh eyes tomorrow - but how would recommend restructuring it?

[semlar]

You can try this, but I'm going to let you figure out if something is wrong with it because I don't have any quests with optional rewards.

hooksecurefunc('QuestInfo_GetRewardButton', function(rewardsFrame, index)
    local questItem = rewardsFrame.RewardButtons[index]
    local _, quality
    if QuestInfoFrame.questLog then
        local choices = GetNumQuestLogChoices()
        if index > choices then -- is reward
            index = index - choices
            _, _, _, quality = GetQuestLogRewardInfo(index)
        else -- is choice
            _, _, _, quality = GetQuestLogChoiceInfo(index)
        end
    else
        local choices = GetNumQuestChoices()
        if index > choices then -- is reward
            index = index - choices
            _, _, _, quality = GetQuestItemInfo('reward', index)
        else -- is choice
            _, _, _, quality = GetQuestItemInfo('choice', index)
        end 
    end
    
    if quality and quality >= 2 then
        local color = ITEM_QUALITY_COLORS[quality]
        questItem.Name:SetTextColor(color.r or 1, color.g or 1, color.b or 1)
    else
        questItem.Name:SetTextColor(1, 1, 1)
    end
end)

Essentially the goal is just to try and determine what item belongs to the button based on its index, and I have no idea if I'm determining whether an item is a reward or a choice correctly.

[Phanx]

Originally Posted by ObbleYeah that's giving me an error on the beta:

I haven't done anything on beta other than log in a couple weeks ago, but they've probably either (a) changed the button names or (b) changed the buttons to be created on demand. If it's the latter, just add an "if f then ... end" wrapper around that part. If it's the former, just use /fstack to figure out what the new names are.

Originally Posted by semlar Essentially the goal is just to try and determine what item belongs to the button based on its index, and I have no idea if I'm determining whether an item is a reward or a choice correctly.

That's why I chose not to hook the individual button function, and instead hook the overall function, so my function will just run once after all of the buttons are updated.