Fixing for MoP

[Whoboom]

I've been gone for a while. When I come back, MoP is out, and requests pour in for me to fix the add-on I Frankensteined together. It's just a small one that plays "TOASTY!" from Mortal Kombat whenever you get a crit. I've looked at the function pages and whatever I could think of to find out how to fix it for MoP. I need help. I got help from here a while ago when I first put it together, and had to modify it a few times with patches. Now I find I need to fully as the smart ones for guidance, or a slap to the face if that's what's called for.

Please will you help me?
I attached all code files.

[tinyu]

are you getting any error messages?

[Fizzlemizz]

For API changes try http://www.wowpedia.org/Patch_5.0.1/API_changes

[Dridzt]

At first glance I don't see anything that needs fixing.

1. Try your sound files in-game with

/run PlaySoundFile("Interface\\AddOns\\TOASTY\\CriticalDamage.mp3")

2. Put some debug print("Critical!") after each one to see if the events fire as appropriate.

You could add a channel parameter to you PlaySoundFile calls (usually "Master" so sounds can play with SFX turned off)
PlaySoundFile("Interface\\AddOns\\TOASTY\\CriticalDamage.mp3", "Master")

But overall if it was working like this it should still be working, it doesn't contain any code that became outdated.

[Whoboom]

Fizzlemizz - I have seen that page, and the part that pertains to me, I don't understand really.

tinyu - It's not even loading in the list of addons when in the interface/addons folder.

Dridzt - ok, so the LUA is still good. why do you think it isn't even loading into the list?

[Phanx]

There's nothing on that list that should affect this addon, and I don't see anything wrong with the code, though I didn't load it in-game to test it.

If it's not showing up in the addons list, then you have the files installed in the wrong place. Post the full, exact path to the TOASTY.toc file on your system.

Edit: On second thought, there is one issue with your code. You're loading your Lua file twice -- once from the TOC, and once from the XML. If you want to use XML to create your frame, then I'd suggest loading the Lua from the XML, and getting rid of the Lua file reference in the TOC. This should not prevent the addon from appearing in the in-game addons list, though.

[Whoboom]

NOW I have it as
C:\Program Files (x86)\World of Warcraft\interface\addons\TOASTY

for some reason there was an extra folder...it was
C:\Program Files (x86)\World of Warcraft\interface\addons\TOASTY\TOASTY

Phanx you solved it for me lol. Thank you so much for all the help. It is working perfectly again.

[Whoboom]

If I just drop the load from XML, it should still work without any other modifications?

[Phanx]

If you choose to load the Lua from the TOC instead of the XML, you need to switch the order in the TOC so that the Lua file is loaded before the XML file. Otherwise, no modifications are needed; just remove the Lua reference in either the XML or TOC file.

[myrroddin]

Sorry for hijacking, but the thread makes me ask. Didn't WoW do away with mp3s and switch to ogg files? It's great that Toasty works regardless; I am just curious.

[tinyu]

i think they use .ogg files for their own sounds but .mp3 files still work as does .wav (i think)

[Ketho]

I was thinking .wav doesn't work anymore since cata

[Phanx]

Support for WAV sounds was removed in Cataclysm. MP3 and Ogg Vorbis (*.ogg) both work, as far as I know, but Blizzard uses the Vorbis format for all of the client's built-in sound files now.

[Choonstertwo]

Originally Posted by Phanx Support for WAV sounds was removed in Cataclysm. MP3 and Ogg Vorbis (*.ogg) both work, as far as I know, but Blizzard uses the Vorbis format for all of the client's built-in sound files now.

Blizzard's sound effects and voice files use Ogg Vorbis, but all the music is still in MP3.