Dequip all problem

[nightcracker]

Hey, I have a - most likely - simple problem with my AddOn, Dequip. This is the code:

--Setting up variables
local cb = DEFAULT_CHAT_FRAME

--The actual function
function Dequip(msg)
if GetInventoryItemLink("player",msg) then
    for i=0,4 do
        for j=1,GetContainerNumSlots(i) do
            if not GetContainerItemLink(i,j) then
                PickupInventoryItem(msg) PickupContainerItem(i,j)
                return
            end 
         end
    end
end
end

--The function for dequipping all items
function Dequipall()
    for m=0,19 do
        Dequip(m)
    end
end

--Slash command handling
SLASH_DEQUIP1 = "/dq"
SLASH_DEQUIP2 = "/dequip"
SlashCmdList["DEQUIP"] = function(msg)
if (not msg or msg == "" or msg == "help") then
	cb:AddMessage('/dequip xxx | /dq xxx - Dequips slot where xxx can be the following slot or "all":')
    cb:AddMessage("Ammo = 0")
    cb:AddMessage("Head = 1")
    cb:AddMessage("Neck = 2")
    cb:AddMessage("Shoulder = 3")
    cb:AddMessage("Shirt = 4")
    cb:AddMessage("Chest = 5")
    cb:AddMessage("Waist = 6")
    cb:AddMessage("Legs = 7")
    cb:AddMessage("Feet = 8")
    cb:AddMessage("Wrist = 9")
    cb:AddMessage("Hands = 10")
    cb:AddMessage("First finger = 11")
    cb:AddMessage("Second finger = 12")
    cb:AddMessage("First trinket = 13")
    cb:AddMessage("Second trinket = 14")
    cb:AddMessage("Cloak = 15")
    cb:AddMessage("Mainhand = 16")
    cb:AddMessage("Offhand = 17")
    cb:AddMessage("Ranged = 18")
    cb:AddMessage("Tabard = 19")
elseif (msg=="all") then
    Dequipall()
else
    Dequip(msg)
end
end

Now, when I try Dequipall() it only dequips one thing instead of all, what should I do?

[v6o]

I'm sure it's because of the lag until an item slot in your bags changes.
You might want to blacklist slots already used OR save the last position you where at and continue from the slot after.

E.g.

local black = {}
 --The actual function
function Dequip(msg)
    if GetInventoryItemLink("player",msg) then
        for i=0,4 do
            for j=1,GetContainerNumSlots(i) do
                if not GetContainerItemLink(i,j) and not black[i.."-"..j] then
                    PickupInventoryItem(msg)
                    PickupContainerItem(i,j)
                    black[i.."-"..j] = true
                    return
                end 
             end
        end
    end
end

[nightcracker]

EDIT: Your one works, the only thing that had to be changed was:

local black = {}

--The actual function
function Dequip(msg)
if GetInventoryItemLink("player",msg) then
    for i=0,4 do
        for j=1,GetContainerNumSlots(i) do
            if not GetContainerItemLink(i,j) and not black[i.."-"..j]  then
                PickupInventoryItem(msg) PickupContainerItem(i,j)
                black[i.."-"..j] = true
                return
            end 
         end
    end
end
end

function Dequipall()
    for m=0,19 do
        Dequip(m)
    end
    black = {}
end

Because else if the user requips the items by hand, it will run out of slots eventually while there are empty slots.

[v6o]

Ah well it was just an fast example late at night with non-ironed out bugs so to say.
The only time you need to blacklist or remember which slots are being used is when you're unequipping more than one item at a time before the bags have time to update.
You might even want to save the time since last unequip to see if you need to use it. ~1sec should be enough for bags to update.