Displaying a simple gold counter

[jacob18d]

Hey everyone, I'm playing with adding a gold counter to an addon, and while at first glance it appeared to work correctly, today I've noticed it doesn't update, and sometimes it's wrong. This is the code I've got for it, and I'm wondering if anyone can see the errors in my way.

local GetMoneyResult = GetMoney()/10000;
local Gnumber = tonumber(string.sub(GetMoneyResult ,1,-6)) if Gnumber == nil or Gnumber == 0 then Gnumber = "" else Gnumber = (Gnumber .."|cffe7cb42g|cffffffff ") end
local Snumber = tonumber(string.sub(GetMoneyResult ,-4,-3)) if Snumber == nil or Snumber == 0 then Snumber = "" else Snumber = (Snumber .."|cffaeacaes|cffffffff ") end
local Cnumber = tonumber(string.sub(GetMoneyResult ,-2,-1)) if Cnumber == nil or Cnumber == 0 then Cnumber = "" else Cnumber = (Cnumber .."|cffc29373c|cffffffff") end
local MoneyStats = frame:CreateFontString(nil, "ARTWORK", "GameFontHighlightLarge");
MoneyStats:SetPoint("RIGHT", frame, "CENTER", 75*cos(math.pi/1.52), 75*sin(math.pi/1.52));
MoneyStats:SetJustifyH("RIGHT");
MoneyStats:SetShadowOffset(1, -1);
MoneyStats:SetText(Gnumber..Snumber..Cnumber)

I think I'm probably calling the GetMoney() from the wrong place, but I'm not sure how to correct it.

[Seerah]

Is that your whole code? Where are you registering for the PLAYER_MONEY event and updating the text?

[jacob18d]

Sorry, that wasn't everything I'd put in, I see a lot of problems with what I did, here's what I'm currently at, which mind you doesn't do anything.

Mind you I've been learning to Code LUA for all of about a day, so I'm sure there are a lot of problems with it.

-- MoneyDisplay OnLoad 

function MoneyDisplay_OnLoad()

   self:RegisterEvent("PLAYER_ENTERING_WORLD");
   self:RegisterEvent("PLAYER_MONEY");

end

-- End MoneyDisplay OnLoad
--
-- MoneyDisplay OnEvent

function MoneyDisplay_OnEvent(self, event, ...)

   if ( event == "PLAYER_ENTERING_WORLD" ) then
      MoneyDisplay = GetMoney();   
      return;

   end 
end

-- End MoneyDisplay OnEvent
--

if ( event == "PLAYER_MONEY" ) then

   local MoneyDisplay  = GetMoney();

end

local MoneyStats = frame:CreateFontString(nil, "ARTWORK", "GameFontHighlightLarge");
MoneyStats:SetPoint("RIGHT", frame, "CENTER", 75*cos(math.pi/1.52), 75*sin(math.pi/1.52));
MoneyStats:SetJustifyH("RIGHT");
MoneyStats:SetShadowOffset(1, -1);
MoneyStats:SetText()

I'm still working on it, and have not quite figured out what I need to do to make it work.

[Seerah]

I'm assuming you have an XML file, too? Where do you create your frame named "frame"?

[jacob18d]

No XML File. The frame is created in the lua.

local frame = CreateFrame("Frame",nil,UIParent)

Like I said, I'm trying to add this into an existing addon. Currently it shows Memory Usage, Ping, and FPS on the frame. I've placed text successfully in the correct area of the frame, and I've had it display the amount of gold I have on hand when the game reloads, but I have not been able to figure out how to update the amount of gold when it changes, and have that text update.

I'm thinking I underestimated the difficulty of what seemed like it would be a straight forward process.

[Seerah]

Change

function MoneyDisplay_OnEvent(self, event, ...)

   if ( event == "PLAYER_ENTERING_WORLD" ) then
      MoneyDisplay = GetMoney();   
      return;

   end 
end

-- End MoneyDisplay OnEvent
--

if ( event == "PLAYER_MONEY" ) then

   local MoneyDisplay  = GetMoney();

end

to this:

function MoneyDisplay_OnEvent(self, event, ...)

   if ( event == "PLAYER_ENTERING_WORLD" ) then
      MoneyDisplay = GetMoney();   
      return;

   elseif ( event == "PLAYER_MONEY" ) then

      local MoneyDisplay  = GetMoney();

   end
end

-- End MoneyDisplay OnEvent
--

/edit: alternately, you can look at my sStats addon (currently in beta) which is a framework to create what you are doing.

[jacob18d]

Thank you for your time, but apparently I'm missing something in the whole process. I can't seem to get any data from it, and MoneyDisplay is constantly a nil value. I'm probably just going to scrap the idea for now.

[Katae]

You're localizing your MoneyDisplay variable inside the if/else statment, that will result in nil:

Wrong:

if true then
  local MoneyDisplay = GetMoney()
end
print(MoneyDisplay) -- MoneyDisplay = nil

Right:

local MoneyDisplay
if true then
  MoneyDisplay = GetMoney()
end
print(MoneyDisplay) -- MoneyDisplay = GetMoney()

[nightcracker]

You could also try to do this with my addon ncDatatext.

[Drshow]

Originally Posted by jacob18d Hey everyone, I'm playing with adding a gold counter to an addon, and while at first glance it appeared to work correctly, today I've noticed it doesn't update, and sometimes it's wrong. This is the code I've got for it, and I'm wondering if anyone can see the errors in my way.

In guild tax i got current gold held to display with coin format with
set text with coin icons

 local convertedYM -- call for local before OnEvent
 
 function YourMoney() -- call after OnEvent
 Your_Money = GetMoney();
 convertedYM = GetCoinTextureString(Your_Money, " "); --Text string with icons
 if(convertedYM == "") then
  convertedYM = 0;
 end
        YourMoneyText:SetText("Your Money: "..convertedYM..""); -- with icons
 end

set text with out coin icons

 local convertedYM -- call for local before OnEvent
 
 function YourMoney() -- call after OnEvent
 Your_Money = GetMoney();
 convertedYM = GetCoinText(Your_Money, " "); --Text string without icons
 if(convertedYM == "") then
  convertedYM = 0;
 end
        YourMoneyText:SetText("Your Money: "..convertedYM..""); -- without icons
 end

[Drshow]

when you say gold counter, are you trying to display current gold with refreshes, or are you counting gold from a source only.

[zero-kill]

I tried to test this, then realized that I don't have any gold on the character :P Fail on my part LOL

[Drshow]

Originally Posted by zero-kill I tried to test this, then realized that I don't have any gold on the character :P Fail on my part LOL

lmfao, did it default to 0 or no. I had same issue on PTR n it loaded only double dashes -- untill i called the function.