Thread Tools Display Modes
04-07-13, 12:26 PM   #1
Zorhel
A Murloc Raider
Join Date: Apr 2013
Posts: 8
Help to update an addon to version 5.2 (DotaKillSound)

Hi, I'm new to the forum and my knowledge of lua are null, so we sought help from you who are professionals.

In the past used an addon for pvp, called DotaKillSound. The last version of the game supports this addon is 3.3.5a. I tried to change some of the files but I have not run the addon. Looking for information about lua, I found this forum and wanted to know if anyone can review the code of this addon and tell me if the code is not too old and if you can upgrade to the version of the game that is the 5.2. In general I want to know if you have an easy solution because if you have to rewrite the entire code addon, I'm not interested. I have no idea lua programming.

Would be very grateful if any of you can retrieve this addon, is truly one of the best addon I've seen and I would like to play with this addon.

removed link to offsite download ~ Cairenn

Thanks for your time.

Last edited by Cairenn : 04-07-13 at 10:17 PM.
  Reply With Quote
04-07-13, 12:30 PM   #2
Resike
A Pyroguard Emberseer
AddOn Author - Click to view addons
Join Date: Mar 2010
Posts: 1,290
Originally Posted by Zorhel View Post
Hi, I'm new to the forum and my knowledge of lua are null, so we sought help from you who are professionals.

In the past used an addon for pvp, called DotaKillSound. The last version of the game supports this addon is 3.3.5a. I tried to change some of the files but I have not run the addon. Looking for information about lua, I found this forum and wanted to know if anyone can review the code of this addon and tell me if the code is not too old and if you can upgrade to the version of the game that is the 5.2. In general I want to know if you have an easy solution because if you have to rewrite the entire code addon, I'm not interested. I have no idea lua programming.

Would be very grateful if any of you can retrieve this addon, is truly one of the best addon I've seen and I would like to play with this addon.

removed link to offsite download ~ Cairenn

Thanks for your time.
If you want to try something new but similar then:

http://www.wowinterface.com/downloads/info19569-PVPSound.html

Last edited by Cairenn : 04-07-13 at 10:17 PM.
  Reply With Quote
04-07-13, 01:16 PM   #3
semlar
A Pyroguard Emberseer
 
semlar's Avatar
AddOn Author - Click to view addons
Join Date: Sep 2007
Posts: 1,060
The game doesn't support wav files any more, so even if someone fixed the script it wouldn't work.

You would have to replace all of the sound files with mp3s or oggs.
  Reply With Quote
04-07-13, 01:32 PM   #4
Zorhel
A Murloc Raider
Join Date: Apr 2013
Posts: 8
Originally Posted by Resike View Post
If you want to try something new but similar then:

http://www.wowinterface.com/downloads/info19569-PVPSound.html
If you've tried it but not the same. Thanks for the reply
  Reply With Quote
04-07-13, 01:34 PM   #5
Zorhel
A Murloc Raider
Join Date: Apr 2013
Posts: 8
Originally Posted by semlar View Post
The game doesn't support wav files any more, so even if someone fixed the script it wouldn't work.

You would have to replace all of the sound files with mp3s or oggs.
I have not tried that actually did not know. I will change the format of the sound files and then I comment and it works.

Thank you!
  Reply With Quote
04-08-13, 01:21 PM   #6
Zorhel
A Murloc Raider
Join Date: Apr 2013
Posts: 8
I changed the format to wav files and modified the lua but still not working.

And shows me an error:


1x DotaKillSoundUU-2.4.3\dotakillsounduu-2.4.3.lua:52: attempt to index global "this" (a nil value)

DotaKillSoundUU-2.4.3\dotakillsounduu-2.4.3.lua:52: in function "DotaKillSoundUU_OnLoad"

<string>:"*:OnLoad":1: in function <string>:"*:OnLoad":1

Locals:
self = <unnamed> {
0 = <userdata>
}
If anyone knows how to fix this error would be very grateful.

Thanks!
  Reply With Quote
04-08-13, 02:12 PM   #7
Resike
A Pyroguard Emberseer
AddOn Author - Click to view addons
Join Date: Mar 2010
Posts: 1,290
Originally Posted by Zorhel View Post
I changed the format to wav files and modified the lua but still not working.

And shows me an error:



If anyone knows how to fix this error would be very grateful.

Thanks!
If you could upload the addon with your modified mp3 files then i could be able to make it work with 5.2 for you.
  Reply With Quote
04-08-13, 06:02 PM   #8
Zorhel
A Murloc Raider
Join Date: Apr 2013
Posts: 8
Originally Posted by Resike View Post
If you could upload the addon with your modified mp3 files then i could be able to make it work with 5.2 for you.
Thank you very much

Sorry for the link M**A did not know they were prohibited such links.
Attached Files
File Type: zip DotaKillSoundUU (MP3).zip (7.18 MB, 373 views)
  Reply With Quote
04-10-13, 06:42 PM   #9
Zorhel
A Murloc Raider
Join Date: Apr 2013
Posts: 8
Any progress?

Thanks for all your work!
  Reply With Quote
04-10-13, 07:37 PM   #10
Dridzt
A Pyroguard Emberseer
 
Dridzt's Avatar
AddOn Author - Click to view addons
Join Date: Nov 2005
Posts: 1,360
Originally Posted by Zorhel View Post
Any progress?

Thanks for all your work!
Just the changed files, replace the originals. (warning: drycoded)

Edit 11-Apr-2013:, updated the attachment with a missed file
(.toc wasn't included, it would fail to save settings due to renaming of SV)
Attached Files
File Type: zip DotaKillSoundUU-patch.zip (6.2 KB, 366 views)

Last edited by Dridzt : 04-11-13 at 07:47 AM.
  Reply With Quote
04-11-13, 06:36 AM   #11
Zorhel
A Murloc Raider
Join Date: Apr 2013
Posts: 8
Originally Posted by Dridzt View Post
Just the changed files, replace the originals. (warning: drycoded)
It works!

Thank you so much!
  Reply With Quote
04-11-13, 07:27 AM   #12
Dridzt
A Pyroguard Emberseer
 
Dridzt's Avatar
AddOn Author - Click to view addons
Join Date: Nov 2005
Posts: 1,360
Originally Posted by Zorhel View Post
It works!

Thank you so much!
I updated the attachment, I had also made a small change to the .toc file but forgot to include it in the .zip
  Reply With Quote
04-11-13, 08:20 AM   #13
Resike
A Pyroguard Emberseer
AddOn Author - Click to view addons
Join Date: Mar 2010
Posts: 1,290
Yeah, sorry i was working on it too, fixed the frames and the combat log stuff, but it still didnt wanted to work somehow, so i just put it aside a bit.
  Reply With Quote

WoWInterface » AddOns, Compilations, Macros » AddOn Help/Support » Help to update an addon to version 5.2 (DotaKillSound)

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off