Find raid member roles, effectively

[suicidalkatt]

Ok so, I've been requested by a friend to create an addon for him to simply automark his arena partners once they've gotten into arena.

It seems currently even with forming a raid and marking individuals before joining the arena clears those raid marks once they join.

Marking them by name is fairly easy however he wanted to know if it were possible to set marks by their talents and their talent role, without having them to set their own roles.

After looking through some of the blizzard inspect coding and some other addons like tiptac talents, the only usable solution would be to build a table of inspected group members and somehow queue up each raid member for inspection that doesn't have their role set already. Due to the inspection restrictions placed after the whole GearScore fad this becomes a bit of an issue.

So here is what I have so far in terms of setting roles for the raid automatically:

local function SetMarksByTalents()
    if IsInRaid() then --and inArena then
        local index = 0
        while index =< 40 do
            
            local unitID    = "raid"..index
            local name      = UnitName(unitID)
            local _,class   = UnitClass(unitID)
            local level     = UnitLevel(unitID)
            local spec      = nil
            local currentRole = UnitGroupRolesAssigned(unitID)
            
            if name and class and level and not AAM_TALENTS[name] then
                if level < 10 or class == "ROGUE" or class == "HUNTER" or class == "MAGE" or class == "WARLOCK" then
                    spec = "DAMAGER"
                elseif currentRole and currentRole ~= "NONE" then
                    spec = currentRole
                else
                    -- Use method for finding raid member role through inspection
                    -- Possibly add to a table that's being cleared through OnUpdate parsing players that appear in that list.
                    -- Register for INSPECT_READY and set the next indexed name for inspection.
                    --if CanInspect(unitID) and (not IsInspectFrameOpen()) then
                        --NotifyInspect(unitID)
                    --end
                end
                if spec then
                    AAM_TALENTS[name] = spec
                    UnitSetRole(unitID, spec)
                end
            end
            
            local index     = index +1
            local unitID    = "raid"..index
        end
    end 
end

[p3lim]

Take a look at how I do it in Symbiotic:
https://github.com/p3lim/Symbiotic/b...ic.lua#L95-113

I initate the request at line 70.

[Dridzt]

Use LibGroupInSpecT I'd say so there's one point of failure for this type of task.

[suicidalkatt]

Originally Posted by p3lim Take a look at how I do it in Symbiotic: https://github.com/p3lim/Symbiotic/b...ic.lua#L95-113 I initate the request at line 70.

About the same method as TipTac uses.

Originally Posted by Dridzt Use LibGroupInSpecT I'd say so there's one point of failure for this type of task.

I like this. They did their homework on it. I was even considering a lot of what they already did with stale unit id information. Creating a mirror of this with more compact code would probably not be as accurate.

I'd still like to see if I could reproduce a lot of their stuff with perhaps just 'raid1-5' although including the library wouldn't be very heavy on the addon.

[Phanx]

Originally Posted by suicidalkatt I'd still like to see if I could reproduce a lot of their stuff with perhaps just 'raid1-5' although including the library wouldn't be very heavy on the addon.

If there are only 5 players in your raid, then what could it possibly do with raid6+?

[suicidalkatt]

Originally Posted by Phanx If there are only 5 players in your raid, then what could it possibly do with raid6+?

Not sure what you mean here.

The addon will primarily be for Arena, that being said, you'll always get placed into raid1-5 once you join arena.

This was more just for faster talent scanning without requiring much throttling if any.

[Rainrider]

What you probably need is to call GetInspectSpecialization(name) which returns you a global spec id. You could then use GetSpecializationRoleByID(specID) to get a non-localized role string for that spec. Beware of the return behavior of UnitName(unitid). I use

local name, realm = UnitName(unitid)
if (realm == "") then realm = nil end
name = realm and name.."-"..realm or name

If you are interested, this is how I do the inspect thing currently. The code is more or less just proof of concept right now and there is probably room for optimization but the inspect works and hopefully does not collide with libs and other inspect addons (haven't tested yet).

I looked at LibGroupInSpecT, but if I didn't miss something, it re-queues the whole group for inspect every 10 sec or so to catch re-specs, which I don't need with my case. The docs say that if you don't call ClearInspectPlayer(name), the server sends further INSPECT_READY events for the unit, so maybe this is the way to get re-specs (haven't tested this yet).