SetHyperlink... broken with a patch?

[Rhianidd]

I have been using the abandoned add-on ProfessionsVault. It stopped working (showing what recipes my characters had/needed (13 chars on "1" server)), so I thought I broke something updating the list of items/spell ids... and so I started digging into the code. By placing a ton of debug statements, I found that it appears that SetHyperlink (which is hooked to colorize the icon and add to the tooltip) isn't actually setting it to the tooltip. It has the GetName() correct, but GetItem() has empty strings (not nil, empty).

Was something changed with SetHyperlink/GetItem? I even tried the TradeskillInfo addon, but don't get any results -- which I hadn't realized that was connected until today.

Rhianidd

[SDPhantom]

tooltip:GetItem() has been bugged on live for a while. There really isn't much of a workaround that'll work on a global scale and securely. It should fine with tooltip:SetHyperlink(), but the bug occurs when using the more UI-specialized functions like tooltip:SetMerchantItem(), tooltip:SetTradeSkillItem(), and others.

On a side note, while Legion is suffering from this bug as well, it does have a new profession window that has a tab that lists unlearned recipes. This mirrors the online Armory's profession page on a selected character. Example here.

[Rhianidd]

Originally Posted by SDPhantom tooltip:GetItem() has been bugged on live for a while. There really isn't much of a workaround that'll work on a global scale and securely. It should fine with tooltip:SetHyperlink(), but the bug occurs when using the more UI-specialized functions like tooltip:SetMerchantItem(), tooltip:SetTradeSkillItem(), and others. On a side note, while Legion is suffering from this bug as well, it does have a new profession window that has a tab that lists unlearned recipes. This mirrors the online Armory's profession page on a selected character. Example here.

So, if GetItem() doesn't work, how can we prove that SetHyperlink() was set properly? And does GetSpell() work? And do the GetLine() calls work? I might be able to work around the GetItem() if GetLine() does.

And it's not just the current char that I want to know if they have a recipe -- it's my whole horde (on alliance )... I would like to buy multiples if I find a new cooking recipe -- or get an engy schematic on my leatherworker... etc etc etc. As well as knowing at a glance if I need to be worried about the merchant or AH list or can continue on.

Rhianidd

[SDPhantom]

I reiterate.

Originally Posted by SDPhantom It should fine with tooltip:SetHyperlink(), but the bug occurs when using the more UI-specialized functions like tooltip:SetMerchantItem(), tooltip:SetTradeSkillItem(), and others.

My custom development addon securely hooks all tooltips to add a tag at the bottom showing item/spell/unit IDs. It also shows additional info for specific tooltips. Items show AH category, stack size, required and item levels, vendor price, and quantity on hand. Spells show their /cast string (used to be useful when we had ranks). Units show their GUID.

I noticed this bug when it came out and did the work to track down which tooltip:Set*() functions triggered it. I have workarounds implemented, but they're not by any means secure and could spread taint.

[Rhianidd]

Originally Posted by SDPhantom My custom development addon securely hooks all tooltips to add a tag at the bottom showing item/spell/unit IDs. It also shows additional info for specific tooltips. Items show AH category, stack size, required and item levels, vendor price, and quantity on hand. Spells show their /cast string (used to be useful when we had ranks). Units show their GUID.

Which addon? It'll save me a bit of trouble deciphering ProfessionsVault (abandoned over an expansion ago).

Thanks SDPhantom.

Rhianidd

[SDPhantom]

"Custom" meaning it's unreleased code that I wrote for my own use. I can still post the tooltip code used in it.

Base Code:

local Hooked={};
local Hooks={
    OnTooltipSetItem=function(self)
        local _,link=self:GetItem();
        if link then
            local _,_,quality,ilvl,clvl,mcat,scat,stack,_,_,price=GetItemInfo(link);
 
            self:AddLine(" ");
            self:AddDoubleLine(("%sLv %s %s|r"):format(ITEM_QUALITY_COLORS[quality or 1].hex,ilvl or "???",_G["ITEM_QUALITY"..(quality or 1).."_DESC"]),(stack or "??").." Stack");
 
            local count,total=GetItemCount(link),GetItemCount(link,true);
            if total>0 then
                local firstline=true;
                if count>0 then     self:AddDoubleLine(firstline and "On Hand" or " ",("Bags: %d"):format(count));      firstline=false; end
                if count<total then self:AddDoubleLine(firstline and "On Hand" or " ",("Bank: %d"):format(total-count));    firstline=false; end
                self:AddDoubleLine(" ",("Total: %d"):format(total));
            else
                self:AddDoubleLine("On Hand","Total: 0");
            end
            self:AddLine(" ");
 
            self:AddDoubleLine("Vendor:",price and GetCoinTextureString(price) or "???");
            self:AddDoubleLine("Req/Item Level:",("%s/%s"):format(clvl or "???",ilvl or "???"));
            self:AddDoubleLine("Category:",("%s - %s"):format(mcat or "???",scat or "???"));
            self:AddLine(link:match("|H(.-)|h"));
        end
    end;
    OnTooltipSetUnit=function(self)
        local _,unit=self:GetUnit();
        if unit then
            self:AddDoubleLine(" ",("unit:%s"):format(unit));
            self:AddLine(UnitGUID(unit));
        end
    end;
    OnTooltipSetSpell=function(self)
        local sname,srank,sid=self:GetSpell();
        if sid then
            self:AddDoubleLine(("%s(%s)"):format(sname,srank),("spell:%d"):format(sid));
        end
    end;
};
 
local function HookTooltip(tooltip)
    if Hooked[tooltip] then return; end
    for i,j in pairs(Hooks) do tooltip:HookScript(i,j); end
    Hooked[tooltip]=true;
end
 
hooksecurefunc(getmetatable(GameTooltip).__index,"SetOwner",function(self) if not Hooked[self] then HookTooltip(self); end end);

Insecure workaround:

local LinkFuncs={
    SetQuestItem=GetQuestItemLink;
    SetQuestLogItem=GetQuestLogItemLink;
    SetMerchantItem=GetMerchantItemLink;
    SetTradeSkillItem=function(skill,reagent) return reagent and GetTradeSkillReagentItemLink(skill,reagent) or GetTradeSkillItemLink(skill); end;
};
 
local ItemLink;
local Meta=getmetatable(GameTooltip).__index;
 
do  local GetItem=Meta.GetItem;
    function Meta:GetItem(...)
        local name,link=GetItem(self,...);
        if link and link:match("|Hitem:0[:|]") and ItemLink then link=ItemLink; end
        if name and link and #name<=0 then name=link:match("|h%[(.-)%]|h") or ""; end
        return name,link;
    end
end
 
for i,j in pairs(LinkFuncs) do
    local func=Meta[i];
    if func then
        Meta[i]=function(self,...)
            ItemLink=j(...);
            func(self,...);--   Script hooks run here
            ItemLink=nil;
        end
    end
end

[Rhianidd]

Thank you so much.

[SDPhantom]

Some of the API changed in Legion, requiring a modification of the workaround. They split tooltip:SetTradeSkillItem() into tooltip:SetRecipeResultItem() and tooltip:SetRecipeReagentItem(). They also moved some of the old tradeskill functions into C_TradeSkillUI. I included the new LinkFuncs table for Legion below.

local LinkFuncs={
	SetQuestItem=GetQuestItemLink;
	SetQuestLogItem=GetQuestLogItemLink;
	SetMerchantItem=GetMerchantItemLink;
	SetRecipeReagentItem=C_TradeSkillUI.GetRecipeReagentItemLink;
	SetRecipeResultItem=C_TradeSkillUI.GetRecipeItemLink;
};