Thread Tools Display Modes
04-30-18, 05:21 AM   #1
Edik
A Murloc Raider
 
Edik's Avatar
AddOn Author - Click to view addons
Join Date: Mar 2009
Posts: 5
In 7.3 you won't need any caching. In 8.x is quering Aura by name completely removed. So if you have mutiple checks in single line I guess caching is worth to try. If you do by aura index from 1 to 40 old fashioned way you won't need to cache. Just imagine if you have this in your old code.

Lua Code:
  1. function WWM:isEating() -- am I bussy by feeding self?
  2.   return UnitAura(ID_PLAYER, BUFF_FOOD) or UnitAura(ID_PLAYER, BUFF_DRINK) or UnitAura(ID_PLAYER, BUFF_REFRESHMENT) or UnitAura(ID_PLAYER, BUFF_DRINK_AND_FOOD)
  3. end

I had my wrappers a small glitch I did fix it original post.

Last edited by Edik : 04-30-18 at 05:29 AM.
  Reply With Quote
04-30-18, 12:28 PM   #2
boomboo
A Murloc Raider
AddOn Author - Click to view addons
Join Date: Nov 2009
Posts: 4
Originally Posted by Edik View Post
In 7.3 you won't need any caching. In 8.x is quering Aura by name completely removed. So if you have mutiple checks in single line I guess caching is worth to try. If you do by aura index from 1 to 40 old fashioned way you won't need to cache. Just imagine if you have this in your old code.
I know, I was talking from the 8.x perspective, and the comparrisons I ran were with single spell querying. As I mentioned though the overhead of all the data being copied and cleared wasn't worth it. You could run the tests yorself but I doubt you'll get different results.

Also UnitAura doesn't support querying by spellid in either 7.3 or 8.x, the second argument if numeric is just an index.

Last edited by boomboo : 04-30-18 at 12:35 PM.
  Reply With Quote

WoWInterface » PTR » PTR General Discussion » Wraper functions for 8.0.1 spell/aura changes


Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off