How do i correctly load saved varibles?

[CrazyCactuaR]

Hi WOWInterface, I've come begging for help as this one is causing me quite the grief.

So I've got myself a table full of varibles (tblMySettings), the addon saves this table using #SavedVaribles: tblMySettings and seem's to load what is saved fine.

The downside is, while still writing this addon, adding variables to the table the obvious problem is it does not load the newly added variables unless i manually set the value myself. Also obviously if somebody else was using the addon and i gave it them as a update, they also would not receive the new varible values unless they deleted my addon's savedvaribles files from the WTF folder.

I did manage to stumble across this;

function CopyDefaults(src, dst)
	if type(src) ~= "table" then return {} end
	if type(dst) ~= "table" then dst = {} end
	for k, v in pairs(src) do
		if type(v) == "table" then
			dst[k] = CopyDefaults(v, dst[k])
		elseif type(v) ~= type(dst[k]) then
			dst[k] = v
		end
	end
	return dst
end

However truth be told I really am not sure how to correctly use it on ADDON_LOADED to load any varibles that was saved but also load what hasn't been saved.

A BIG thank you to whoever helps regarding this.

[Sharparam]

You would have a "defaults" table defined in your AddOn that you then pass to CopyDefaults in ADDON_LOADED, so something like the following:

local defaults = {
  foo = "hello world",
  bar = { key = "value" },
  anumber = 42
}
 
local function addonLoaded(name) -- replace this with whatever you are using to handle ADDON_LOADED
  if name ~= myAddonName then return end
  -- Also assign it in case tblMySettings is nil
  tblMySettings = CopyDefaults(defaults, tblMySettings)
end

The CopyDefaults function you have won't replace values in the saved variables that are already of the same type as the corresponding key in the defaults table, so it will leave existing entries intact.

[CrazyCactuaR]

Originally Posted by Sharparam You would have a "defaults" table defined in your AddOn that you then pass to CopyDefaults in ADDON_LOADED, so something like the following: local defaults = {   foo = "hello world",   bar = { key = "value" },   anumber = 42 }   local function addonLoaded(name) -- replace this with whatever you are using to handle ADDON_LOADED   if name ~= myAddonName then return end   -- Also assign it in case tblMySettings is nil   tblMySettings = CopyDefaults(defaults, tblMySettings) end The CopyDefaults function you have won't replace values in the saved variables that are already of the same type as the corresponding key in the defaults table, so it will leave existing entries intact.

Thank you!

From trying this i can confirm that it does copy the default settings to another table, However a problem still exists.

default = {
one="hello",
two="bye",
}
profile = { }

default will move to profile.

If i were to add; three="meep" to default by editing the file and saving, after reloading wow or the ui it does not copy "three" to the profile table.

[Sharparam]

Can you post the complete code (including TOC)?

[CrazyCactuaR]

Originally Posted by Sharparam Can you post the complete code (including TOC)?

myAddon.toc

## Interface: 50401
## Title: myAddon
## Author: CrazyCactuaR
## DefaultState: Enabled
## SavedVariables: mySettings
myAddon.lua

myAddon.lua

myDefault = {
	one="hey",
	two="hoo",
}

mySettings = { }

function CopyDefaults(src, dst)
	if type(src) ~= "table" then return {} end
	if type(dst) ~= "table" then dst = {} end
	for k, v in pairs(src) do
		if type(v) == "table" then
			dst[k] = CopyDefaults(v, dst[k])
		elseif type(v) ~= type(dst[k]) then
			dst[k] = v
		end
	end
	return dst
end

function myAddon_OnLoad()
	mySettings = CopyDefaults(myDefault, mySettings)
end

myAddon_OnLoad()

If i did;

/script print(mySettings.one)

It would return "hey". So i decide here is where i edit myDefault, add three="meep", save, reloadui on wow and try the print of mySettings.three, but this returns nil.

Only way I could get it to copy three to mySettings was to delete myAddon.lua and myAddon.lua.bak from SavedVariables in WTF.

The obvious problem I see with this is if my initial addon I make is given out and people use it, then i continue it's development even further, anymore variables to that table i include will not appear to those who currently use my addon only to those who have not used it yet.

[Sharparam]

The issue is most likely that you're running the myAddon_OnLoad function at the end of the file, rather than when your addon has actually loaded. So the Saved Variables have not been initialized at the time of calling the function.

You'll need to listen for the ADDON_LOADED event and run the function when your addon has loaded (by checking the name arg).

local frame = CreateFrame("Frame")
 
-- Normally you'd use vararg (...) for the event args, but we're only listening for one specific event
local function onEvent(self, event, name)
  if name ~= "myAddon" then return end -- don't process event if it wasn't our addon that loaded
  mySettings = CopyDefaults(myDefaults, mySettings)
  self:UnregisterEvent("ADDON_LOADED") -- don't process further loaded events
end
 
frame:SetScript("OnEvent", onEvent)
frame:RegisterEvent("ADDON_LOADED")

Also, don't pollute the global namespace with names like "myDefaults", "CopyDefaults" etc, they are very generic names and there could be conflicts with other addons that use names like that. If you really need them to be global, prefix them with something like "myAddon_" or put them in a global table named like your addon.

[CrazyCactuaR]

Originally Posted by Sharparam The issue is most likely that you're running the myAddon_OnLoad function at the end of the file, rather than when your addon has actually loaded. So the Saved Variables have not been initialized at the time of calling the function. You'll need to listen for the ADDON_LOADED event and run the function when your addon has loaded (by checking the name arg). local frame = CreateFrame("Frame")   -- Normally you'd use vararg (...) for the event args, but we're only listening for one specific event local function onEvent(self, event, name)   if name ~= "myAddon" then return end -- don't process event if it wasn't our addon that loaded   mySettings = CopyDefaults(myDefaults, mySettings)   self:UnregisterEvent("ADDON_LOADED") -- don't process further loaded events end   frame:SetScript("OnEvent", onEvent) frame:RegisterEvent("ADDON_LOADED") Also, don't pollute the global namespace with names like "myDefaults", "CopyDefaults" etc, they are very generic names and there could be conflicts with other addons that use names like that. If you really need them to be global, prefix them with something like "myAddon_" or put them in a global table named like your addon.

Yup you are spot on pal, Thank you very much for that.