a little off topic: Merry Xmas and SecureTemplates

[gmarco]

Hi,

I like to wish merry xmas and happy new year to all the forum readers.
I really want also to say thanks to all of you for all the times you read and answered my questions.
Without your help and patience I think I was not able to write the little addons I have wrote.
This was (and is) much appreciated.

Now a question so the msg is not so much offtopic:

I'd like to find and to study some examples to understand better the SecureTemplates (http://www.wowwiki.com/SecureTemplates) framework with LDB.

I.e. I got a taint error if I call the profession tab from an LDB (and it works) and then I press the first aid, cooking profession etc etc buttons.

So I ask here if you can point me to some resources.

Thanks again for attention.

[Phanx]

Originally Posted by gmarco I.e. I got a taint error if I call the profession tab from an LDB (and it works) and then I press the first aid, cooking profession etc etc buttons.

Code?

Generally speaking you can't use LDB plugins to perform secure actions, because LDB wasn't designed with secure execution in mind, and no LDB displays create secure objects. You will see some workarounds that work out of combat, by positioning an invisible secure button over the LDB object when hovered, for example, but they really are just that -- workarounds.

However, opening professions isn't a secure action, so if you're getting taint errors you're probably not doing it right, or possibly the taint isn't even related to your code.

[gmarco]

Hi Phanx,

Thanks for your answer.

the code is simple and the relevant part is:

dataobj.OnClick = function(self, button)  
 
    if button == "MiddleButton" then
        ToggleSpellBook(BOOKTYPE_PROFESSION)
        return
    end
 
-- and so on

If I call the profession with middle button and then I try to use fishing, archeology or fire camp I got the following error (in the attach window ... sorry is in italian but you get the idea :-)

Other profession works well, but I am a little bit confused about this

P.s.
I am not in combat ...

Thanks for any input

[Phanx]

Oh, I misunderstood what you wanted to do... I thought you actually wanted to open the tradeskill window for a specific profession. For what you're trying to do, I couldn't find a good way to toggle the spellbook from insecure code in ~10 minutes of testing, so you're probably going to have to do one of those out-of-combat workarounds:

local clicker
local function HideClicker()
          if not clicker then return end
          clicker:ClearAllPoints()
          clicker:Hide()
end

dataobj.OnEnter = function(self)
     if InCombatLockdown() then return end

     if not clicker then
          clicker = CreateFrame("Button", nil, UIParent, "SecureActionButtonTemplate")
          clicker:RegisterForClicks("AnyUp")
          clicker:SetAttribute("type", "macro")
          clicker:SetAttribute("macrotext", "/click [btn:3] SpellbookMicroButton")
          clicker:RegisterEvent("PLAYER_REGEN_DISABLED")
          clicker:SetScript("OnEvent", HideClicker)
          clicker:SetScript("OnLeave", HideClicker)
          self:HookScript("OnHide", HideClicker)
     end

     clicker:ClearAllPoints()
     clicker:SetAllPoints(self)
     clicker:SetFrameStrata("DIALOG")
     clicker:Show()
end

dataobj.OnLeave = HideClicker

Note that this will also hijack your tooltip, so if you need a tooltip, you'll have to set OnEnter/OnLeave scripts on the clicker to show/hide a tooltip. If you want to do other things on left/right click, you'll have to modify the clicker's macrotext attribute.

[gmarco]

Hi Phanx,

thanks so much for your code.

I really have to take some time to study it better.

If I have understood:
- it creates a frame button that activate when you hovering on the ldb text.
- when I press the middle button it execute the macro defined

The first problem which I have to investigate further is ...
- when you define the macro for the middle button you know surely which is the macro cmd.

clicker:SetAttribute("macrotext", "/click [btn:3] SpellbookMicroButton")

But if I choose the left/right button for casting the primary / secondary profession it is difficult to write the macro line in advance because I have to find which ones they are :-)

I have a code like this:

local prof1,prof2=GetProfessions()
 
--  Select based on button pressed
    local name, tex, offset, _
    if button == "LeftButton" and prof1 then
        name, tex, _, _, _, offset = GetProfessionInfo(prof1)
    elseif button == "RightButton" and prof2 then
        name, tex, _, _, _, offset = GetProfessionInfo(prof2)
    else
        return
    end
 
--  Open tradeskill
    if not Restricted[tex] then         --   Don't run if no tradeskill window
        CastSpell(offset+1,BOOKTYPE_PROFESSION)
    else
        print(prgname .. " Error: " .. name .. " has no tradeskill window")
    end

Is it right to intercept the left/right mouse button and call a function that evaluate that code above ?

Something like:
clicker:SetScript("OnClick", MyLeftRightMouseFunc)

BTW: I try to rewrite all and see what happens :-)


When I succeded in finishing this first part I'll look at the missing tooltip :-)

Really thanks Phanx and Happy New Year.

[Phanx]

Yes, you've understood correctly.

The first problem isn't really a problem, since you can change the attribute at will, as long as you're out of combat. I'd avoid an OnClick script, but you can either just deal with it when you show the button:

     local macrotext = "/click [btn:3] SpellbookMicroButton"
     local a, b = GetProfessions()
     if a then
          macrotext = macrotect .. "\n/cast [btn:1] " .. GetProfessionInfo(a)
     end
     if b then
          macrotext = macrotect .. "\n/cast [btn:2] " .. GetProfessionInfo(b)
     end
     clicker:SetAttribute("macrotext", macrotext)
     clicker:ClearAllPoints()
     clicker:SetAllPoints(self)
     clicker:SetFrameStrata("DIALOG")
     clicker:Show()

... or set a PreClick script on it:

     self:HookScript("OnHide", HideClicker)
     clicker:SetScript("PreClick", function(self, button)
          if button == "MiddleButton" then
               return self:SetAttribute("macrotext", "/click SpellbookMicroButton")
          end
          local a, b = GetProfessions()
          if a and button == "LeftButton" then
               return self:SetAttribute("macrotext", "/cast " .. GetProfessionInfo(a))
          elseif b and button == "RightButton" then
               return self:SetAttribute("macrotext", "/cast " .. GetProfessionInfo(b))
          end
          -- something else happened, do nothing
          self:SetAttribute("macrotext", "")
     end)

... or even register for the SKILL_LINES_CHANGED event (not 100% on the name offhand) and set the attribute in response to it, using conditionals like in the first method above.