Reverse code

[kruma]

Hi!
Help me someone with code. Need reverse when missing buff indicator=show, when have buffs indicator hide

local indicators = {}
local buffs = {}
local_, class = UnitClass("player");
 
if ( class == "DRUID" ) then
buffs = {["Mark of the Wild"] = true}
end
if (class == "PRIEST" ) then
buffs = {["Power Word: Fortitude"] = true}
end
if (class == "MAGE" ) then
buffs = {["Arcane Brilliance"] = true}
end
if (class == "MONK" ) then
buffs = {
["Legacy of the White Tiger"] = true,
["Legacy of the Emperor"] = true
}
end
if (class == "DEATHKNIGHT" ) then
buffs = {["Horn of Winter"] = true}
end
if (class == "PALADIN" ) then
buffs = {
["Blessing of Kings"] = true,
["Blessing of Might"] = true
}
end
if (class == "WARLOCK" ) then
buffs = {["Dark Intent"] = true}
end
if (class == "WARRIOR" ) then
buffs = {
["Battle Shout"] = true,
["Commanding Shout"] = true
}
end
 
 
 
local function getIndicator(frame)
local indicator = indicators[frame:GetName()]
if not indicator then
indicator = CreateFrame("Button", nil, frame, "CompactAuraTemplate")
indicator:ClearAllPoints()
indicator:SetPoint("TOPRIGHT", frame, "TOPRIGHT", -3, -2)
indicator:SetSize(22, 22)
indicator:SetAlpha(0.6)
indicators[frame:GetName()] = indicator
end
return indicator
end
 
local function updateBuffs(frame)
if not frame:IsVisible() then return end
 
local indicator = getIndicator(frame)
local buffName = nil
for i = 1, 40 do
local _, _, _, _, _, d, _, ut, _, sc, s, c = UnitBuff(frame.displayedUnit, i);
buffName = UnitBuff(frame.displayedUnit, i);
if not buffName then break end
if buffs[buffName] and ( ut == "player" or ut == "pet" ) then
indicator:SetSize(frame.buffFrames[1]:GetSize()) -- scale
CompactUnitFrame_UtilSetBuff(indicator, frame.displayedUnit, i, nil);
return
end
end
indicator:Hide()
end
hooksecurefunc("CompactUnitFrame_UpdateBuffs", updateBuffs)

[SDPhantom]

There's a lot of places in this code that needs improvement. First of all, you shouldn't be looking for buffs by name. This will only work on one locale (client language) and not others. You should use SpellIDs instead.

Also, storing pointers by frame name will oftentimes get you into trouble as not all frames are named. This will make you run into "index by nil" errors when this happens. You should reference by the frame pointer itself. This is completely unique and is never nil.



Overall, the problem with an addon like this is the fact that buffs that modify the same stat type override each other. This may lead to two or more players fighting over whether or not their buff is up because they keep overriding each other. This is where having consolidated buffs on is helpful so you can tell what stat types are being buffed and remember what your buff does as part of knowing your class.

Anyway, here's a much better implementation of your code. Doing what you're describing, performing the inverse of showing/hiding the frame, is practically impossible in design. This is because a few of the classes have to choose which buff they activate which are mutually exclusive.

local IndicatorLookup={};
local BuffList={
--  Death Knight
    [57330]=true;--     Horn of Winter
 
--  Druid
    [1126]=true;--      Mark of the Wild
 
--  Mage
    [1459]=true;--      Arcane Brilliance
    [61316]=true;--     Dalaran Brilliance
 
--  Monk
    [115921]=true;--    Legacy of the Emperor
    [116781]=true;--    Legacy of the White Tiger
 
--  Paladin
    [19740]=true;--     Blessing of Might
    [20217]=true;--     Blessing of Kings
 
--  Priest
    [21562]=true;--     Power Word: Fortitude
 
--  Warlock
    [109773]=true;--    Dark Intent
 
--  Warrior
    [6673]=true;--      Battle Shout
    [469]=true;--       Commanding Shout
};
 
hooksecurefunc("CompactUnitFrame_UpdateBuffs",function(self)
    if not self:IsVisible() then return; end
 
    local unit,index=self.displayedUnit,1;--    Prepare variables for loop
    repeat
        local _,_,_,_,_,_,_,caster,_,_,spellid=UnitBuff(unit,index);--  Grab buffs cast by us
        if spellid then--   Buff exists?
            if (caster=="player" or caster=="pet" or caster=="vehicle") and BuffList[spellid] then break; end-- If we found our buff, break out of loop
            index=index+1;--    Increment index
        else
            index=nil;--    Else clear index
        end
    until not spellid-- Stop if no more buffs
 
--  At this point, Index will hold our found buff, 
    local frame=IndicatorLookup[self];
    if not frame then
--      If we didn't find our buff, then don't bother creating a frame
        if not index then return; end
 
        frame=CreateFrame("Button",nil,self,"CompactAuraTemplate");
        frame:ClearAllPoints();
        frame:SetPoint("TOPRIGHT",-3,-2);
        frame:SetSize(self.buffFrames[1]:GetSize());
        frame:SetAlpha(0.6);
        IndicatorLookup[self]=frame;
    end
 
    if index then CompactUnitFrame_UtilSetBuff(frame,unit,index,"PLAYER"); end--    Apply buff found to template
    frame:SetShown(index and true or false);--  Typecast to boolean
end);

[kruma]

Doing what you're describing, performing the inverse of showing/hiding the frame, is practically impossible in design

Is it possible to show/hide buffs only casted by me? Executed code show all bufflist http://imgur.com/QVUJ4Sq
maybe if the point buffs casted by me(player) can be inverted(if miss then show else hide)?

[SDPhantom]

Updated lines 37 and 39. The "PLAYER" filter wasn't doing what I thought it would. It was filtering buffs they cast and not ours.

Anyway, as I explained before, it's easy to show which buff we cast on a player. Design-wise, how do you want to implement multiple buff options in a "buff missing" indicator? Do you want to show all buff options, taking up more room on the UnitFrame?

For example, a Warrior can use either Battle Shout or Commanding Shout to buff the raid. Which of these do you want to show if neither of them have been applied? Do you want both of them to show up at the same time? Wouldn't it be much easier if we have the indicator show if they have our buff instead?

[kruma]

Originally Posted by SDPhantom Updated lines 37 and 39. The "PLAYER" filter wasn't doing what I thought it would. It was filtering buffs they cast and not ours. Anyway, as I explained before, it's easy to show which buff we cast on a player. Design-wise, how do you want to implement multiple buff options in a "buff missing" indicator? Do you want to show all buff options, taking up more room on the UnitFrame? For example, a Warrior can use either Battle Shout or Commanding Shout to buff the raid. Which of these do you want to show if neither of them have been applied? Do you want both of them to show up at the same time? Wouldn't it be much easier if we have the indicator show if they have our buff instead?

i have icon created by addon tellmewhen settings - http://imgur.com/td423TD
can you help me rewrite code what need to show
if missing (buff=idspell and buff(casted by me)) then show indicator attached to raid frames

[SDPhantom]

So you just want a static icon shown regardless of what buff spell(s) are missing? If that's the case, then here's a modified version that does just that. Though I don't find the idea of disassociation to make much sense.

local IndicatorLookup={};
local BuffList={
--  Death Knight
    [57330]=true;--     Horn of Winter
 
--  Druid
    [1126]=true;--      Mark of the Wild
 
--  Mage
    [1459]=true;--      Arcane Brilliance
    [61316]=true;--     Dalaran Brilliance
 
--  Monk
    [115921]=true;--    Legacy of the Emperor
    [116781]=true;--    Legacy of the White Tiger
 
--  Paladin
    [19740]=true;--     Blessing of Might
    [20217]=true;--     Blessing of Kings
 
--  Priest
    [21562]=true;--     Power Word: Fortitude
 
--  Warlock
    [109773]=true;--    Dark Intent
 
--  Warrior
    [6673]=true;--      Battle Shout
    [469]=true;--       Commanding Shout
};
 
local Icon; do
    local ClassIcons={
        DEATHKNIGHT =57330;--   Horn of Winter
        DRUID       =1126;--    Mark of the Wild
        MAGE        =1459;--    Arcane Brilliance
        MONK        =115921;--  Legacy of the Emperor
        PALADIN     =19740;--   Blessing of Might
        PRIEST      =21562;--   Power Word: Fortitude
        WARLOCK     =109773;--  Dark Intent
        WARRIOR     =6673;--    Battle Shout
    };
 
--  Set class-based icon
    local Buff=ClassIcons[select(2,UnitClass("player"))];
    Icon=Buff and GetSpellTexture(Buff);
end
 
hooksecurefunc("CompactUnitFrame_UpdateBuffs",function(self)
    if not self:IsVisible() then return; end
 
    local unit,index=self.displayedUnit,1;--    Prepare variables for loop
    repeat
        local _,_,_,_,_,_,_,caster,_,_,spellid=UnitBuff(unit,index);--  Grab buffs cast by us
        if spellid then--   Buff exists?
            if (caster=="player" or caster=="pet" or caster=="vehicle") and BuffList[spellid] then break; end-- If we found our buff, break out of loop
            index=index+1;--    Increment index
        else
            index=nil;--    Else clear index
        end
    until not spellid-- Stop if no more buffs
 
--  At this point, Index will hold our found buff, 
    local tex=IndicatorLookup[self];
    if not tex then
--      If we found a buff, then don't bother creating a frame
        if not index then return; end
 
        tex=self:CreateTexture(nil,"OVERLAY");
        tex:SetPoint("TOPRIGHT",-3,-2);
        tex:SetSize(self.buffFrames[1]:GetSize());
        tex:SetTexture(Icon);
        tex:SetAlpha(0.6);
        IndicatorLookup[self]=tex;
    end
 
    tex:SetShown(not index);
end);

Note: all the spells in Legion have been switched around, so the spell IDs will need to be updated when it goes live.

[kruma]

Thanks great work, it`s working properly. One moment only, is it possible attach

    local Icon="Interface\\Icons\\Ability_monk_legacyoftheemperor";-- GetSpellTexture(19740)

to player class
for example if (player_class=monk) then Icon="Interface\\Icons\\Ability_monk_legacyoftheemperor"
all icons

monk - Ability_monk_legacyoftheemperor
druid - Spell_nature_regeneration
mage - spell_holy_magicalsentry
paladin - Spell_holy_greaterblessingofkings
priest - spell_holy_wordfortitude
warlock - spell_warlock_focusshadow

the reason why i need show indicator when buff missing to keep track when my big buffs was purged. It helping me rebuff my arena mates

[SDPhantom]

Updated the previous post to select a buff icon based on class.

[kruma]

biggest thanks SDPhantom for help