Thread Tools Display Modes
06-16-09, 04:24 PM   #1
Vis
A Pyroguard Emberseer
 
Vis's Avatar
Join Date: Mar 2009
Posts: 1,827
Cooldown/debuff timers

I have a slight confusion on the way the debuff (I think) timers work in the latest Dev version. I understand that the duration of spell effects will show on the action bars representing how long the debuff lasts. My question is should this apply to helpful debuff spells also? In this case, I'm referring specifically to Paladin Judgement spells.

An example: I load up Seal of Righteousness (30 minute duration, displays fine), and start attacking a mob. I cast Judgement of Light (http://www.wowhead.com/?spell=20271), I see the debuff on the mob, my Action Bar icon shows the cooldown specifically for the spell itself, not the duration of the debuff on the mob. If in the same fight, I cast Hammer of Justice (http://www.wowhead.com/?spell=853), I can see the debuff duration on the Action bar.

Am I confusing myself about how the debuff timers are supposed to work? Or is it because the debuff that the Judgement spell causes to be on the mob is actually a helpful one to me?

Here's a couple screenie's to illustrate how it appears also. Action Button 1 is Hammer of Justice, and Action Button 5 is Judgement of Light.
Attached Thumbnails
Click image for larger version

Name:	WoWScrnShot_061609_010007.jpg
Views:	697
Size:	431.5 KB
ID:	2915  Click image for larger version

Name:	WoWScrnShot_061609_005946.jpg
Views:	654
Size:	444.7 KB
ID:	2916  
 
06-16-09, 05:19 PM   #2
Xrystal
nUI Maintainer
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 5,892
The color of the first button is different from the second one.

The first is in fact telling you that not only is the debuff in active ( also shows in debuff window in the hud ) but its cooldown is still active too ( shows in cooldown window in the hud ). The current timing on this button is actually the debuff timer. Once the debuff runs out it will display the cooldown timer.

The second button however doesn't ensue a debuff but in stead showing a cooldown timer. But, if I remember my pally info rightly, if you select yourself when it is active it will show as a buff timer on yourself.

That is a weakness to this feature unfortunately. If its a buff to yourself or anyone else it will only show a timer when the person you have targetted has the buff. Otherwise it will only show the cooldown. The debuff similarly will only show the debuff timer when you have the target with the debuff active. Seeing as you would not normally untarget a mob mid fight that you don't often not see the debuff timer.

Hmm, the second image actually doesn't look right .. the debuff is showing on the target and on the debuff window but not actually showing on the button. Could it be because the cooldown just expired and it has got confused ? The first image looks to me to make sense with the correct timing on debuffs and cooldowns.
__________________

Last edited by Xrystal : 06-16-09 at 05:25 PM.
 
06-16-09, 05:36 PM   #3
Vis
A Pyroguard Emberseer
 
Vis's Avatar
Join Date: Mar 2009
Posts: 1,827
That's why I posted the 2nd image also. The first image shows that the Hammer spell is correctly showing the duration of the debuff on the mob. The 2nd image is showing the debuff on the mob in the far right list, but is not showing that the spell has 10 secs remaining on the mob. I wasn't sure if this was due to it not actually being a harmful debuff on the mob. IE: Those particular spells, Judgement of light/wisdom do not cause any DOT effect on the mob, instead they give a helpful buff to any friendly attacker. I hit the mob, I get hp, mana etc.

That's why I'm a bit confused, lol. Is there a limitation based on whether the spell cast is helpful/harmful?
 
06-16-09, 06:39 PM   #4
Xrystal
nUI Maintainer
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 5,892
Sounds like it. But if it is treating it like a debuff on the aura bars it should treat it as a debuff on the debuff bar in the hud. But if it is a limitation in the blizz code then that would explain the flaw. I'll try and test some things out on my pally tomorrow and see if I get a similar problem.
__________________
 
06-16-09, 10:09 PM   #5
neuralassassin
A Scalebane Royal Guard
 
neuralassassin's Avatar
Join Date: Sep 2008
Posts: 423
I would think the debuff for judgements should work because it is infact a debuff. hmmmm well have to wait for scott to chime in here though Im not sure if its something he can change on this end or like crystal said a stupid Blizz thing
__________________

 
06-16-09, 11:19 PM   #6
Vis
A Pyroguard Emberseer
 
Vis's Avatar
Join Date: Mar 2009
Posts: 1,827
My money is on "stupid Blizz thing"
 
06-17-09, 04:16 AM   #7
spiel2001
nUI's Author
 
spiel2001's Avatar
AddOn Author - Click to view addons
Join Date: Jun 2008
Posts: 7,724
Unfortunately, this is a quirk of the Pally battle system and how the action bar timers work. nUI figures out which action is active on the target by matching the name of the action to the name of the aura as I have yet to have found a workable way to do it without keeping a complicated spell database (which I do not ever intend to do because that's exactly the kind of thing that permanently breaks addons when Bliz makes majoy patches)

So... the problem is that your action button is "Seal of Light" but the aura is a judgment, not a seal... names don't match, so no timer.

Another example where this happens is protection warriors and their devastate spell which casts sunder on the target... names don't match, so the player does not get a timer for the sunder debuff.

This is something I want to find a fix for, but it has to be a programmatic solution, not database driven, before I'll implement it.
__________________

What people don't get is that I am, ultimately, an artist at heart.
My brush has two colors, 1 and 0, and my canvas is made of silicon.



Official nUI Web Site: http://www.nUIaddon.com
Official nUI Support Forum: http://forums.nUIaddon.com
My day job: http://www.presidio.com/
 
06-17-09, 10:25 AM   #8
Vis
A Pyroguard Emberseer
 
Vis's Avatar
Join Date: Mar 2009
Posts: 1,827
Originally Posted by spiel2001 View Post
So... the problem is that your action button is "Seal of Light" but the aura is a judgment, not a seal... names don't match, so no timer.

Another example where this happens is protection warriors and their devastate spell which casts sunder on the target... names don't match, so the player does not get a timer for the sunder debuff.

I think I may have confused you by my original explanation. In the case of Paladins at least, all of the Seal spells cast a personal 30 minute buff. In the 2nd screenshot, the actual spell cast is "Judgement of Light" which places a debuff on the target in the same name. All of the "Judgement" type spells do the same thing.

I fully understand not wanting to create a database that would most likely be a breaking point whenever Blizz does patches though.
 
06-17-09, 10:36 AM   #9
spiel2001
nUI's Author
 
spiel2001's Avatar
AddOn Author - Click to view addons
Join Date: Jun 2008
Posts: 7,724
No -- I understood exactly what you were saying -- I have a lvl50 ret pally I play (well, I haven't played him in months, but I did at least level him ~lol~)

The problem is that the action button does not say "Judgment of Light" -- It says "Judgment" and which judgment it is depends on which seal was active when you cast it. The problem is that the aura that's active on the target is neither "Seal of Light" (which would cause the timer to appear on the seal action button) or "Judgment" (which would cause it to appear on the judgment action button)

It's a complicated system unfortunately... nUI has to call GetEffectiveAction() to find out what the actually applicable action of the button is (it can change based on which action page is active, whether or not you're shapeshifted, stealth or in an alternate stance, mind controlling (possessing) a player/mob and/or mounted on a vehicle.

Once I know the effective action, then I have to figure out which spell that action is, then look at the target and see if there's an aura active on the target with the same spell name. If there is, then I can query the aura to find out how much longer the spell will be active before it expires and that's the number that gets displayed.

If I cannot make the connection between the effective action on the action bar and the active auras on the target, then there's no way for me to determine how much longer the spell will be active.

Since "Judgment" =/= "Judgment of Light" I can't make that determination programmatically. I would have to have a database of spell names and match those to aura names and that database would have to support all of the languages nUI supports... so, as you can see, the problem starts to explode in complexity pretty quickly.

EDIT: The same is true for the warrior example I gave... the "effective action" on his "Devastate" action button is a number. I call GetActionInfo( effectiveAction ) to get the name of the action in the localized language -- which is "Devastate" -- then I look at the target to see if there's a "Devastate" spell active on the target... only the spell that gets cast on the target by the "Devastate" action is actually "Sunder" -- so even though sunder is active and should be displaying a counter on the devastate action button, no timer shows. Same as the Judgment button on a pally... the aura that appears on the target is not the same name as the action that caused it.
__________________

What people don't get is that I am, ultimately, an artist at heart.
My brush has two colors, 1 and 0, and my canvas is made of silicon.



Official nUI Web Site: http://www.nUIaddon.com
Official nUI Support Forum: http://forums.nUIaddon.com
My day job: http://www.presidio.com/

Last edited by spiel2001 : 06-17-09 at 10:41 AM.
 
06-17-09, 10:54 AM   #10
Vis
A Pyroguard Emberseer
 
Vis's Avatar
Join Date: Mar 2009
Posts: 1,827
Paladin Judgements were changed some time ago. The judgement type is no longer based off of what seal you have active

Pallies have 3 Judgements now, there is no longer a single Judgement only key. Here's how it's laid out

Judgement of Light http://www.wowhead.com/?spell=20271
Judgement of Wisdom http://www.wowhead.com/?spell=53408
Judgement of Justice http://www.wowhead.com/?spell=53407

They work completely independantly of what Seal is active.

EDIT: As long as you have *Any* seal active, you can cast any of these 3 judgements, but they do operate on the same global cooldown timer for the spell.

Last edited by Vis : 06-17-09 at 10:57 AM.
 
06-17-09, 11:03 AM   #11
spiel2001
nUI's Author
 
spiel2001's Avatar
AddOn Author - Click to view addons
Join Date: Jun 2008
Posts: 7,724
Hmmm... so when you mouse over the Judgment icon on your action bar, does it say "Judgment of Light" as the title of the action in the tooltip? The "name" of the action has to be the same as the name of the aura on the target for nUI to match them up.

PS: Wow... I guess it's been a really long time since I played my pally then... I probably won't know how to play him anymore ~lol~ But, I will break him out of his mothballs and see if I can figure out what's going on.
__________________

What people don't get is that I am, ultimately, an artist at heart.
My brush has two colors, 1 and 0, and my canvas is made of silicon.



Official nUI Web Site: http://www.nUIaddon.com
Official nUI Support Forum: http://forums.nUIaddon.com
My day job: http://www.presidio.com/
 
06-17-09, 11:09 AM   #12
Vis
A Pyroguard Emberseer
 
Vis's Avatar
Join Date: Mar 2009
Posts: 1,827
It does say the name on the tooltip. You'll have fun with Pallies now with all the changes...just don't forget to redistribute your Talent points, and no need to stack any spellpower for any spec besides Holy. It's all based off of strength for Ret and Prot
Attached Thumbnails
Click image for larger version

Name:	WoWScrnShot_061709_130709.jpg
Views:	602
Size:	329.5 KB
ID:	2918  
 
06-17-09, 12:30 PM   #13
spiel2001
nUI's Author
 
spiel2001's Avatar
AddOn Author - Click to view addons
Join Date: Jun 2008
Posts: 7,724
Woohoo! I like chat channel 8! ~lol~

Okay... gonna have to look into this... if the action button spell name and the target aura name are the same, it should be showing a counter. Guess I'll have to drag Ranghen out of his dry dock and see what this is about.
__________________

What people don't get is that I am, ultimately, an artist at heart.
My brush has two colors, 1 and 0, and my canvas is made of silicon.



Official nUI Web Site: http://www.nUIaddon.com
Official nUI Support Forum: http://forums.nUIaddon.com
My day job: http://www.presidio.com/
 
06-17-09, 03:01 PM   #14
Xrystal
nUI Maintainer
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 5,892
Rofl, guess I should have checked this a few hours back instead of playing sims Didn't get round to testing this on my pally cos I thought the problem had been found... oh well.
__________________
 
06-17-09, 03:03 PM   #15
Vis
A Pyroguard Emberseer
 
Vis's Avatar
Join Date: Mar 2009
Posts: 1,827
Originally Posted by spiel2001 View Post
Woohoo! I like chat channel 8! ~lol~
hehe, yeah. It's the best chat channel
 
06-17-09, 03:18 PM   #16
Xrystal
nUI Maintainer
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 5,892
Is it possible that the 10 sec cooldown timer is taking over ? Just find it coincidental that it has a 10 sec cooldown and that is the time slot that is used to determine the change in color.
__________________
 
06-17-09, 03:47 PM   #17
Xrystal
nUI Maintainer
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 5,892
Okay think I spotted something Scott, whether its the right area is another matter

I added some debug code in nuiButton.lua to test the tests being made and I spotted a flaw as you will see from the screen shot.

In the spell book there is no Rank associated with the Judgements. But the debuff automatically notes it as Rank 1. Therein they do not match. However, on the players auras themselves Divine Protection, Righteous Fury and Seal of Righteousness are similarly non ranked but work fine.


Code:
if not overlay.spellStatus.remains then
   aura_info = unit_info.aura_info and unit_info.aura_info.debuff_list or nil;
   if aura_info then 
       for i=1,#aura_info do
           aura = aura_info[i];
           -- Debug Code
           if ( aura.name == overlay.spellStatus.name ) then
               print("Aura Name : " .. aura.name);
               print("End Time : " .. aura.end_time);
               print("Proc Time : " .. proc_time);
               print("Caster : " .. aura.caster);
               print("Rank : " .. aura.rank);
               print("Overlay Rank : " .. overlay.spellStatus.rank);
          end
          -- Debug Code
          if  aura.end_time
          and aura.end_time > proc_time
          and aura.name == overlay.spellStatus.name
          and aura.rank == overlay.spellStatus.rank		
          and aura.caster == "player"
          then 
               overlay.spellStatus.remains = aura.end_time - proc_time;
               overlay.spellStatus.color   = overlay.is_cdc and { r=0.75, g=0.05, b=1 } or { r=0, g=1, b=1 };
               break;
          end
      end
   end
end
Attached Thumbnails
Click image for larger version

Name:	WoWScrnShot_061709_224228.jpg
Views:	601
Size:	413.9 KB
ID:	2919  
__________________

Last edited by Xrystal : 06-17-09 at 04:00 PM.
 
06-17-09, 04:59 PM   #18
spiel2001
nUI's Author
 
spiel2001's Avatar
AddOn Author - Click to view addons
Join Date: Jun 2008
Posts: 7,724
I'm not sure I would call it a "flaw" but it is definitely the source of the problem. Interesting that it doesn't have a rank in the spell book but is given a rank in the auras. In any event, I suppose that the rank test could actually be removed since we know the spell is being cast by the player, it really doesn't matter what the rank is unless someone had the same spell on their action bar multiple times (different ranks with different mana requirements)... but that should be very rare in practice.
__________________

What people don't get is that I am, ultimately, an artist at heart.
My brush has two colors, 1 and 0, and my canvas is made of silicon.



Official nUI Web Site: http://www.nUIaddon.com
Official nUI Support Forum: http://forums.nUIaddon.com
My day job: http://www.presidio.com/
 
06-17-09, 06:56 PM   #19
Vis
A Pyroguard Emberseer
 
Vis's Avatar
Join Date: Mar 2009
Posts: 1,827
Originally Posted by Xrystal View Post
In the spell book there is no Rank associated with the Judgements.
Out of curiousity, did you tick off the box in the spellbook to "show all ranks"? Otherwise, I would think it only shows a rank when you mouseover it, just like the tooltip on the action bar.
 
06-17-09, 09:51 PM   #20
Xrystal
nUI Maintainer
 
Xrystal's Avatar
Premium Member
AddOn Author - Click to view addons
Join Date: Feb 2006
Posts: 5,892
Originally Posted by Vis View Post
Out of curiousity, did you tick off the box in the spellbook to "show all ranks"? Otherwise, I would think it only shows a rank when you mouseover it, just like the tooltip on the action bar.
Yep tried that to double check .. only one ever shows regardless of that box.
__________________
 
 

WoWInterface » Featured Projects » nUI, MozzFullWorldMap and PartySpotter » Support » nUI: Technical Support » Cooldown/debuff timers

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

vB code is On
Smilies are On
[IMG] code is On
HTML code is Off