Roll Your Own Fixes for 5.041

[Rythal]

To Fix Quest Log breaking after doing a daily:

Change Line 7496 to:

daS1=format(QUEST_LOG_DAILY_COUNT_TEMPLATE,daD1,"*")

----
To fix dungeon eye missing:

Change Line 25269 to:

local mON={"NXMiniMapBut","GameTimeFrame","TimeManagerClockButton","MiniMapWorldMapButton","MiniMapMailFrame","MiniMapTracking","MiniMapVoiceChatFrame","QueueStatusMinimapButton","MiniMapInstanceDifficulty",}

----

To fix the world map fading out of existance when you mouse out:

Change Line 11248 to:

frm.tex1:SetVertexColor(1,1,1,self.BaA)

----

To fix the LUA errors on world map hovering over some zones from achievements being removed (wetlands, duskwood etc)

After Line 6795 (should be "if alw or not don then") Add

if GetAchievementNumCriteria(a) > 0 then

After Line 6799(should be "return format("%s%s %d/%d",col2,nam,cnt,nee)") Add

end

----

To fix the green blob wintergrasp currently is on the map

Change Line 24396 to

self.ZoO["lakewintergrasp"]["lakewintergrasp"]="0,0,1024,768"

[jovenyoung]

Thanks!

I might add since line numbers are referenced and notepad doesn't have them, that people probably should download a program like notepad++ that supports line numbers.

[taeon]

Rythal,

You are a god among men.

These a-holes basically screwed you and you are still fixing their glitches lol.

I say bail and let them suffer.

[Rythal]

It's just not in me to do that... at least I only posted how to fix the bugs instead of fixing them and releasing it :P

[mjumnito]

Originally Posted by Rythal It's just not in me to do that... at least I only posted how to fix the bugs instead of fixing them and releasing it :P

this post along with the fixes just proves that your heart was in the right place with the fan update.

[Michaelgal]

Originally Posted by Rythal It's just not in me to do that... at least I only posted how to fix the bugs instead of fixing them and releasing it :P

You are the best. We respect you.

[jarda128]

If i was an official developer of carbonite,i would accept help of Rythal to place his fixes in official update ...
and maybe another help with him too...
Rythal seems to be very skilled fixing bugs so why refusehis help
just my opinion ...

JK

[Meganbtoo]

Originally Posted by Rythal It's just not in me to do that... at least I only posted how to fix the bugs instead of fixing them and releasing it :P

I no longer use Carbonite but you are a star Rythal. When you create your map addon will you post the details here so we can get it and donate to you, for your great work here and the one part of Carbonsh..e that is irreplaceable?

[Shoogar]

Originally Posted by Rythal It's just not in me to do that... at least I only posted how to fix the bugs instead of fixing them and releasing it :P

Hey Rythal, thanks for the great fixes, I am still using yours rather than the "official" update.

Why not download some free patch software, fix and update everything, then post a link to the patch software and release a patch?

That way you aren't releasing anyone else's code, but at the same time making a "good" version of Carbonite available.

Just a thought....

[Dr Sasa]

-- Carbonite Copyright 2007-2009 Carbon Based Creations, LLC

original 2007-2012

i think we have to hold it.

[Rythal]

Originally Posted by Shoogar Hey Rythal, thanks for the great fixes, I am still using yours rather than the "official" update. Why not download some free patch software, fix and update everything, then post a link to the patch software and release a patch? That way you aren't releasing anyone else's code, but at the same time making a "good" version of Carbonite available. Just a thought....

I could do that, but
a) most people would get lost if I tried explaining how to use patch / diff, or would not like having to install new software.
b) every version of carbonite is different, so a patch for 5.041 would fail in every chunk for 5.042. Every time they did an update i'd have to find where the functions moved to then redo every change.

[shadow_wolf_30]

thanks for the heads up on how to fix the quest log error. it works good again

[backlash666]

So what your saying (without really saying) is that in the last 3 days, since they last released the crud version, they couldn't be bothered updating it with 6 lines of code????

Ok I get the fact that they don't play WoW anymore. That's OK.

What I don't get is their unwillingness to make an effort, yes I know they came at the 13th hour and brought it out (broken) but they weren't around before hand, they haven't been reading their own forums, they were apparently unaware of MoP's patch release, which meant they haven't been paying attention to anything WoW related, let alone their own add on/forum.

I don't like the fact that Rythal was shunned for being the only person to step up and do what the original authors should have done in the first place and what he continually tries to do ( Like roll your own fixes lol). And before anyone starts, I do appreciate all the work the OA's have done with Carbonite, I have used it for many years, and donated in the past. I also agree that they own their code, it is theirs! I just don't agree with the way they have handled things since. I mean here's the quick version of what I understand went on.

Bliz released MOP Patch,
Everyone's addons went psycho,
Most addons were nearly fixed from day 1,
Carbonite OA's were nowhere to be seen, not even a "Sorry we're late, but we're on it!"
Rythal (After numerous attempts to contact OA's by others.) decided to fix Carbonite for the masses. And lets face it, we are quite a User Base.
After a few bug fix versions everyone is happy (mostly)
Along came the OA's, very late, who then throws out an unfinished (official) version, and cracks Rythal on the back of the head with the naughty stick for his troubles.
Now people who wrongly assumed the (Official) version would work properly, have replaced Rythals (working) version with it, and are now boned.
Rythal continues to try to help at risk of another crack with the naughty stick.

If you feel I have missed anything in this brief overview then I'm sure you'll let me know. Edits will be in bold after you have corrected me.

@Rythal

I assume by your posting that you make these roll your own fixes, free to use, without copyright?? If you could please clarify this? That way the OA's have no excuse for waiting another day before removing finger from bum and getting the hell on with it? Or does that sound unfair? Again, I'm sure you'll all let me know.



PS Spelling mistakes are due to a keyboard with no lettering left on it Lol.

[JimJoBlue]

Originally Posted by backlash666 So what your saying (without really saying) is that in the last 3 days, since they last released the crud version, they couldn't be bothered updating it with 6 lines of code???? Ok I get the fact that they don't play WoW anymore. That's OK. What I don't get is their unwillingness to make an effort, yes I know they came at the 13th hour and brought it out (broken) but they weren't around before hand, they haven't been reading their own forums, they were apparently unaware of MoP's patch release, which meant they haven't been paying attention to anything WoW related, let alone their own add on/forum. I don't like the fact that Rythal was shunned for being the only person to step up and do what the original authors should have done in the first place and what he continually tries to do ( Like roll your own fixes lol). And before anyone starts, I do appreciate all the work the OA's have done with Carbonite, I have used it for many years, and donated in the past. I also agree that they own their code, it is theirs! I just don't agree with the way they have handled things since. I mean here's the quick version of what I understand went on. Bliz released MOP Patch, Everyone's addons went psycho, Most addons were nearly fixed from day 1, Carbonite OA's were nowhere to be seen, not even a "Sorry we're late, but we're on it!" Rythal (After numerous attempts to contact OA's) decided to fix Carbonite for the masses. And lets face it, we are quite a User Base. After a few bug fix versions everyone is happy (mostly) Along came the OA's, very late, who then throws out an unfinished (official) version, and cracks Rythal on the back of the head with the naughty stick for his troubles. Now people who wrongly assumed the (Official) version would work properly, have replaced Rythals (working) version with it, and are now boned. Rythal continues to try to help at risk of another crack with the naughty stick. If you feel I have missed anything in this brief overview then I'm sure you'll let me know. @Rythal I assume by your posting that you make these roll your own fixes, free to use, without copyright?? If you could please clarify this? That way the OA's have no excuse for waiting another day before removing finger from bum and getting the hell on with it? Or does that sound unfair? Again, I'm sure you'll all let me know. PS Spelling mistakes are due to a keyboard with no lettering left on it Lol.

That's how I have been reading the situation.. Except one small thing. (in bold)
I remember reading a post by Rythal, saying it was not him that has contacted the OA's. But someone who knew them.

Apart from that I will not comment on the drama that is taking place here...

[schizophrena]

Originally Posted by backlash666 Rythal (After numerous attempts to contact OA's) decided to fix Carbonite for the masses. And lets face it, we are quite a User Base. @Rythal I assume by your posting that you make these roll your own fixes, free to use, without copyright?? If you could please clarify this? That way the OA's have no excuse for waiting another day before removing finger from bum and getting the hell on with it? Or does that sound unfair? Again, I'm sure you'll all let me know.

First point I have quoted above - Rythal has said himself that he personally never contacted the OA's because others said they had tried. Not that it specifically diminishes him at all, but a clarification point (and I understand why he wouldn't).

Second, lots of people make suggestions on code replacement, I know Jeffrey is one I've seen in the forums for a while as well. Also, you assume that the OA's have access and time every day to get on these forums, file through lots of posts and then fix the codes - all very quickly, not something I assume. I think we could see more timely responses if the posts that happened, now that the OA's are back, are problems and fixes posted by others. Granted, I'm guilty of adding to the issue seeing how I respond to these messages - but I like to help give timely feedback, though it isn't official by any means.

This does give one good point however, I love this thread for what it was intended (or I believe it was intended) a place to report bugs and people to post quick fixes. Hopefully they can be found and incorporated quickly. Thank you again Rythal for your work!

[shadow78]

Originally Posted by schizophrena This does give one good point however, I love this thread for what it was intended (or I believe it was intended) a place to report bugs and people to post quick fixes. Hopefully they can be found and incorporated quickly. Thank you again Rythal for your work!

This might help faatal out with finding bug's and fixing carbonite.
Have to say I'm a little upset how I respond to the quick post he did but with the little time he has to update I understand.
maybe the people on the forums can give faatal help with finding the bug's and posting the fix also if they know the coding for it.
I'm hoping this will help carbonite out and faatal.
But I would like to see Rythal part of team if faatal will allow it.
that would also help faatal out alot.. due to his RL stuff.

Please help faatal out.
Plus hear the plea's of the member's of the forums faatal.
If you need the help just Ask... As I think many will help you keep Carbonite alive.

[Zanariah]

Thank you so much for the info on the fixes. Everything worked great. Only problem I am still having is a large black circle in the middle of Dalaran and Shattrath. Not sure if I did something wrong or if that is a separate issue.

[Rythal]

Originally Posted by Zanariah Thank you so much for the info on the fixes. Everything worked great. Only problem I am still having is a large black circle in the middle of Dalaran and Shattrath. Not sure if I did something wrong or if that is a separate issue.

That's an unrepairable bug introduced with the new patch. Any area that is "indoors" but still mountable (dalaran, undercity, cleft of shadows, caverns of time) causes the map to do that if it's transparent at all... there is no sure fire way to detect when it will happen. In mine it was fixed by docking / solid if it was a known bugged area, we will have to wait and see how they handle it and just live with it for now

[nexusguard]

Originally Posted by backlash666 So what your saying (without really saying) is that in the last 3 days, since they last released the crud version, they couldn't be bothered updating it with 6 lines of code???? Ok I get the fact that they don't play WoW anymore. That's OK. What I don't get is their unwillingness to make an effort, yes I know they came at the 13th hour and brought it out (broken) but they weren't around before hand, they haven't been reading their own forums, they were apparently unaware of MoP's patch release, which meant they haven't been paying attention to anything WoW related, let alone their own add on/forum. I don't like the fact that Rythal was shunned for being the only person to step up and do what the original authors should have done in the first place and what he continually tries to do ( Like roll your own fixes lol). And before anyone starts, I do appreciate all the work the OA's have done with Carbonite, I have used it for many years, and donated in the past. I also agree that they own their code, it is theirs! I just don't agree with the way they have handled things since. I mean here's the quick version of what I understand went on. Bliz released MOP Patch, Everyone's addons went psycho, Most addons were nearly fixed from day 1, Carbonite OA's were nowhere to be seen, not even a "Sorry we're late, but we're on it!" Rythal (After numerous attempts to contact OA's by others.) decided to fix Carbonite for the masses. And lets face it, we are quite a User Base. After a few bug fix versions everyone is happy (mostly) Along came the OA's, very late, who then throws out an unfinished (official) version, and cracks Rythal on the back of the head with the naughty stick for his troubles. Now people who wrongly assumed the (Official) version would work properly, have replaced Rythals (working) version with it, and are now boned. Rythal continues to try to help at risk of another crack with the naughty stick. If you feel I have missed anything in this brief overview then I'm sure you'll let me know. Edits will be in bold after you have corrected me. @Rythal I assume by your posting that you make these roll your own fixes, free to use, without copyright?? If you could please clarify this? That way the OA's have no excuse for waiting another day before removing finger from bum and getting the hell on with it? Or does that sound unfair? Again, I'm sure you'll all let me know. PS Spelling mistakes are due to a keyboard with no lettering left on it Lol.

.....

OMG i luv how you can simplify things ... i wrote a post and well wasnt as simple as you ... i hate how my brains works sometimes but you summed everything up and i have been reading the posts since the patch of 5.04 came out my roomie wont play without a working carbonite... people rely on it alot cause blizzards version of a smaller map for while out and a bout well really doesnt stack up or compare to carbonites map, among their also attempt for a quest tracker, wonder what else blizz will put in without letting the UI be scaled the way the user wants ...
but back to the things here ... i updated and did the official and noticed i was running 15-20 fps before i updated carbonite and when i updated it my fps dropped to 5fps to 1fps at times ... so theres an issue ...

[backlash666]

Originally Posted by nexusguard ..... OMG i luv how you can simplify things ...

What can I say ???? I'm a simple guy lol

I just wanted to get a, clear cut, quick overview out there, so peeps that didn't have the whole story, now have some sort of idea.

I know a lot of people have said that the OA's should take Rythal onto the team, in my view if I was Rythal, after the way he was treated when OA's came back (and hit him with the naughty stick n all) and they then turned round and asked him to join, my response would politely be along the lines of "Hell No, ya whining baby!" And I'm sure some will agree. Now I know some peeps will take this as a message of disrespect, this is not the case, I have great respect for what the OA's have done in the past. Just not for the way they have behaved in recent days.

I know this is kinda Hijacking the original topic so I'll try n shut up now