Seal Tag help

[nin]

Hey fellow wowi'ers!

I used to use a tag for monitoring if i was lazy and forgot to have my seal activated.

Now when they changed the seals to stancebar this obviously does not work anymore because it doesn't seem to give me an actual buff i assume? not very good at coding im afraid so im reaching out if anyone could point me in the right direction to make my tag work.

oUF.Tags.Methods["seal"] = function(unit)
        if(not UnitAura(unit, spells["Seal of Insight"]) and not UnitAura(unit, spells["Seal of truth"])) then
            return "|cffE0E0E0NO SEAL|r"
        end
    end
    oUF.Tags.Events["seal"] = "UNIT_AURA"

Thanks

[Tim]

http://www.wowwiki.com/API_GetShapeshiftForm
http://www.wowwiki.com/API_GetShapeshiftFormInfo

There's all the information you would need to fiddle around with the stance stuff.

Here's something untested...

    oUF.Tags.Methods["seal"] = function(unit)
            local nStance = GetShapeshiftForm()
            if not nStance then
                return "|cffE0E0E0NO SEAL|r"
            end
        end
        oUF.Tags.Events["seal"] = "UPDATE_SHAPESHIFT_FORMS"

I'm not sure when UPDATE_SHAPESHIFT_FORMS fires but you may have to also add ACTIVE_TALENT_GROUP_CHANGED to the events as well.

[nin]

Thanks a bunch!

oUF.Tags.Methods["seal"] = function(unit)
     local nStance = GetShapeshiftForm() ~= 3
     if nStance then
     return "|cffFFAB00No Seal|r"
     end
     end
     oUF.Tags.Events["seal"] = "UNIT_AURA UPDATE_SHAPESHIFT_FORM"

Unit_aura, GetShapeshiftForm() ~= 3, and using UPDATE_SHAPESHIFT_FORM and not UPDATE_SHAPESHIFT_FORMS made it working.

Result when i don't have seal of insight activated!

[Rainrider]

You don't need UNIT_AURA and it fires a lot. You maybe do need UPDATE_SHAPESHIFT_FORMS because it fires after login even if you don't have an active seal (stance) (that's not interesting as oUF will update your tag OnShow) and for the case where you (un)learn a stance that replaces your currently active stance as it then deactivates without firing UPDATE_SHAPESHIFT_FORM (this happens when you (un)learn Aspect of the Iron Hawk on a hunter, don't know if there is such a case for paladins).

Apart from that, you have to add the two events to oUF.Tags.SharedEvents as they fire only for the player and are thus unitless (don't have arg1 set to a unitid).

So your code would have to look something like this:

oUF.Tags.Methods["seal"] = function(unit)
    local nStance = GetShapeshiftForm() ~= 3
    if nStance then
        return "|cffFFAB00No Seal|r"
    end
end
oUF.Tags.Events["seal"] = "UPDATE_SHAPESHIFT_FORMS UPDATE_SHAPESHIFT_FORM"
oUF.Tags.SharedEvents.UPDATE_SHAPESHIFT_FORM = true
oUF.Tags.SharedEvents.UPDATE_SHAPESHIFT_FORMS = true

Alternatively you could use just UNIT_AURA to update the tag (as you currently do, as you do not add UPDATE_SHAPESHIFT_FORM to the SharedEvents table), because it fires when you change your seal (even if you don't get a visible buff for this), but this would be more expensive I believe as oUF only updates your tag if the frame, on which the tag is and the unit, which the event has fired for, are the same. UNIT_AURA fires a lot in a raid, so oUF would have to make this decision quite often (maybe support for the new RegisterUnitEvent would alleviate this). UPDATE_SHAPESHIFT_FORM is also fired when you cast certain spells, don't know why, so I can't tell for sure which one is the better method. Using both UNIT_AURA and UPDATE_SHAPESHIFT_FORM is certainly a waste.

[nin]

Thanks for the info Rainrider!

Is using a tag like this a really bad way to track this. in terms of efficiency?

Your tag worked great, i tried unit_aura just because it was the only thing i got working when trying, note to self is not to try coding at 7 in the morning.

One issue i just realized if i want to use this with offspec is that i need to assign the tag to my mainspec somehow, since prot and ret get more seals than holy.

Im guessing i can use GetSpecialization() somewhere?

Sleeptime.. i'll play around with it more later!

Thanks for the help and info, i appreciate it!

EDIT

Trying this now, and it makes it only work when im in holyspec.

oUF.Tags.Methods["seal"] = function(unit)
    local spec = GetSpecialization() == 1
    local nStance = GetShapeshiftForm() ~= 3
    if nStance and spec then
        return "|cffFFAB00No Seal|r"
    end
end
oUF.Tags.Events["seal"] = "UPDATE_SHAPESHIFT_FORMS UPDATE_SHAPESHIFT_FORM"
oUF.Tags.SharedEvents.UPDATE_SHAPESHIFT_FORM = true
oUF.Tags.SharedEvents.UPDATE_SHAPESHIFT_FORMS = true

[Rainrider]

Using a tag for this is not bad in term of efficiency. You could squeeze out some more cpu time by increasing memory usage when you declare a local handle for the API functions that are called often. I don't think that's needed in your case as I believe this won't be noticeable.

If you only want to be warned that you forgot Seal of Insight when holy spec'd, then your code is ok.

[Phanx]

On a somewhat-related note, you don't need to create a variable assignment to store a function's return value if you're only going to use that value once. Compare:

	local spec = GetSpecialization() == 1
	local nStance = GetShapeshiftForm() ~= 3
	if nStance and spec then
		return "|cffFFAB00No Seal|r"
	end

	if GetSpecialization() == 1 and GetShapeshiftForm() ~= 3 then
		return "|cffFFAB00No Seal|r"
	end

[nin]

Great, thanks so much guys!