Safest way to move default player&target unitframe?

[Layback_]

Hi all,

For this time, I'm here to ask a question regarding unit frames.

Basically it seems like the following script won't work in .lua file.

PlayerFrame:ClearAllPoints();
PlayerFrame:SetPoint("LEFT", UIParent, "LEFT");

TargetFrame:ClearAllPoints();
TargetFrame:SetPoint("RIGHT", UIParent, "RIGHT");

I have been told that this is because some default Blizzard functions run after this addon is being called(?).

So, I have tried to add the following lines of code at the end:

PlayerFrame.SetPoint = function() end;

TargetFrame.SetPoint = function() end;

However, the problem with this attempt would be that it is going to taint frames when I enter or leave the vehicle.

So, the next thing that I have tried was to hook "PlayerFrame_ToPlayerArt" function(?) which seemed to work fine, but it also had a problem with entering or leaving a vehicle.

I would like to know what would be the best way to maintain unit frame's position via .lua file.

Could I ask some advice regarding this?

Thank you.

[Resike]

I can poin you to this thread:
http://www.wowinterface.com/forums/s...ht=move+target

[Layback_]

Originally Posted by Resike I can poin you to this thread: http://www.wowinterface.com/forums/s...ht=move+target

Hi Resike,

I just have tested that method and it seems to work well for PlayerFrame, but does not seem to work for TargetFrame

local moving;

hooksecurefunc(PlayerFrame, "SetPoint", function(self)
	if moving then
        return;
    end

    moving = true;
    self:SetMovable(true);
    self:SetUserPlaced(true);
    self:ClearAllPoints();
    self:SetPoint("RIGHT", UIParent, "CENTER", -100, -100);
    self:SetMovable(false);
    moving = nil;
end);

hooksecurefunc(TargetFrame, "SetPoint", function(self)
	if moving then
        return;
    end

    moving = true;
    self:SetMovable(true);
    self:SetUserPlaced(true);
    self:ClearAllPoints();
    self:SetPoint("LEFT", UIParent, "CENTER", 100, -100);
    self:SetMovable(false);
    moving = nil;
end);

[Lombra]

Just do this and run it on PLAYER_LOGIN or something.

PlayerFrame:ClearAllPoints();
PlayerFrame:SetPoint("LEFT", UIParent, "LEFT");
PlayerFrame:SetUserPlaced(true);

TargetFrame:ClearAllPoints();
TargetFrame:SetPoint("RIGHT", UIParent, "RIGHT");
TargetFrame:SetUserPlaced(true);

[Layback_]

Originally Posted by Lombra Just do this and run it on PLAYER_LOGIN or something. PlayerFrame:ClearAllPoints(); PlayerFrame:SetPoint("LEFT", UIParent, "LEFT"); PlayerFrame:SetUserPlaced(true); TargetFrame:ClearAllPoints(); TargetFrame:SetPoint("RIGHT", UIParent, "RIGHT"); TargetFrame:SetUserPlaced(true);

I tried this as well, but the problem is that this method will permanently position the frame at its new position via calling SetUserPlaced function.

I would like the frames to be moved to new position only when the addon is enabled.

[Resike]

Originally Posted by Layback_ I tried this as well, but the problem is that this method will permanently position the frame at its new position via calling SetUserPlaced function. I would like the frames to be moved to new position only when the addon is enabled.

You can't really do that securely.

[Lombra]

Probably can do SetUserPlaced(false) on PLAYER_LOGOUT, then.

[Layback_]

Hi, Resike, Leatrix and Lombra,

So, overall it would be like the following:

UFPosition:RegisterEvent("VARIABLES_LOADED");
UFPosition:RegisterEvent("PLAYER_LOGOUT");
 
function UFPosition:OnEvent(event, arg1)
    if event == "VARIABLES_LOADED" then
        PlayerFrame:ClearAllPoints();
        PlayerFrame:SetPoint("RIGHT", UIParent, "CENTER", -100, -200);
        PlayerFrame:SetUserPlaced(true);
 
        TargetFrame:ClearAllPoints();
        TargetFrame:SetPoint("LEFT", UIParent, "CENTER", 100, -200);
        TargetFrame:SetUserPlaced(true);
    elseif event == "PLAYER_LOGOUT" then
        PlayerFrame:SetUserPlaced(false);
 
        TargetFrame:SetUserPlaced(false);
    end
end
 
UFPosition:SetScript("OnEvent", UFPosition.OnEvent);

Please let me know or correct me if I am missing something!


BTW... where did all those syntax highlight go D:

[Lombra]

Looks good.

Syntax highlighting is [highlight="Lua"]

[Layback_]

Originally Posted by Lombra Looks good. Syntax highlighting is [highlight="Lua"]

Sweet!

Thank you for your help