Don't load if you don't need to

[hipjipp]

Hi, would just like to know a few things;

1. How do i not load an addon depending on if the char has a skill or not?
2. How do restrict text output depending on the skill of the char (and how do i make the background change size depending on it).

Would love to know.

Thanks in advance, Hipjipp

[Coldfury]

Originally Posted by hipjipp Hi, would just like to know a few things; How do i not load an addon depending on if the char has a skill or not? How do restrict text output depending on the skill of the char (and how do i make the background change size depending on it). Would love to know. Thanks in advance, Hipjipp

to load based on something you simply add

if (not playerhasspell("spellname")) then return end

at the top of the file. ull need to find the correct function tho.

exemple to load based on class:
local playerclass = select(2, UnitClass"player")
if(playerclass ~= "HUNTER") then return end

[Shirik]

Originally Posted by Coldfury local playerclass = select(2, UnitClass"player") if(playerclass ~= "HUNTER") then return end

You are harming yourself if you use select() where you don't need to. A call to select() is slower than simply taking what you need. You would be better off with

local _, playerclass = UnitClass("player")
if (playerclass ~= "HUNTER") then return; end

[Seerah]

I'm sure it depends on context. Also, if you want the second return, but not the first, third, or fourth, etc.

This is what WoW Programming says in regards to dummy variables (_, playerclass) or using select()

The underscore identifier has become somewhat of a de-facto standard when you need to throw away the result of a function call simply because it's easy to type, and most likely not already in use, but it's considered bad practice. Instead of using the underscore as a dummy variable, it's better to give each variable a meaningful name, and only use those that are necessary.

Does it make a difference with something this small? I have seen both methods for this particular case be used. In my addon, I have tried both and didn't notice a difference.

[zespri]

The underscore thingy is a matter of preference. I personally can't see why it can be considered bad practice. You are basically indicating that the variable has no meaning or use for you. Would it be better to try and give a meaningful name to a meaningless variable? On my opinion, hardly so.

[Slakah]

I would use AddonLoader and place:

## LoadManagers: AddonLoader
## X-LoadOn-Events: PLAYER_LOGIN
## X-LoadOn-PLAYER_LOGIN: if GetSpellInfo(spellid) then LoadAddon("MyAddon") end

in the toc.

The only thing you need to remember is that the Addon will be loaded after "PLAYER_LOGIN" so you will not be able to use that event.

[hipjipp]

i couldnt get the "playerhasspell" thing to work.. as i need my addon to load/not load depending on if i have herbalism or not. I'd prefer not to use addon loader, might be the only way though.. : <

Hope you'll keep posting, i love you guys!