API version 5: changes and discussion - Page 5

Goldpaw · 10-14-10, 06:47 AM

@neverg

Change

Code:

_G[bar..'Background']:SetAllPoints(bar)

to

Code:

_G[bar..'Background']:SetAllPoints(_G[bar])

?

Not sure if that causes it, but that was the only thing that struck me when browsing through the code fast.

Dawn · 10-14-10, 07:15 AM

*very constructive comment incoming*

I hate this patch.

Sueisfine · 10-14-10, 07:49 AM

Originally Posted by Goldpaw

Not sure I agree with this. The people in the linked thread use GetScreenHeight() to get the size of their screen, but that is the wrong way, since GetScreenHeight() is affected by UIscale. Meaning that you won't always get the actual screen height.

Hmmm, I think there was some kind of misunderstanding here

When I said "(...)to have the same effect as setting "uiscale" to "768/<your resolution height>" prior to 4.0.1(...)" what I meant was:
- I play at 1680x1050 so, prior to 4.0.1, I used to do "/console uiscale 768/1050" so that 1-pixel is "worth" 1-pixel (a.k.a. pixel-perfection). Exactly what your code does.
- Now with 4.0.1, it seems you can achieve the same effect as above by simply unchecking the "uiscale" option in the in-game settings (according to the thread I linked).

My intention was simply to give a heads-up since I only found out about this myself this morning. So sorry if my comment was confusing :S

haste · 10-14-10, 11:30 AM

Originally Posted by Rostok

You should use 1.5.2

And there's not much code changed with the Factory you should take a look at some other layout, it's really not difficult to have your layout using it.
For the frame name, i give a name too and all my frames (i think so, didn't test raid) work like it should. So this has nothing to do with it.
You should have a pastey ready when you have a problem, it's so much easier when you have the code to help debugging it ^^

oUF generates name for you based on the style and unit if you don't specify one.

Originally Posted by ForeverTheGM

Regarding portraits:

Are there any workarounds for this? I don't want to disable portraits for my party and I need the visibility conditions, so that it displays when in a 5-man raid.

What am I to do?

Wait for Blizzard to fix it. =/

Originally Posted by Sueisfine

Hello there.

First of all thank you haste for all the hard work on 1.5.x /bow

I'm also in the process of migrating my personal layout to 1.5.x and so far I managed to fix most of the stuff but I'm running into a couple of issues and am wondering if someone can point me in the right direction:

1) Right-Click a player buff to cancel it: it isn't working atm, it throws an error popup in the game. any ideas of what I can do to fix this?

2) Concerning 'oUF-initialConfigFunction': I understand what you have to do if you want to use local variables inside the string (haste's example on first page). But is it also possible to call a local function inside the string? I mean, some function defined before the "SpawnHeader" call? If so, how can we do it?

Thank you very much in advance !!!

@neverg: I ran into the same issue you mentioned (frames not visible) and in my case the problem was the "initial-*' attributes that I was using to define the frames' size. I simply replaced those by ":GetWidth()" and ":GetHeight()" calls and it solved it for me. <pt>ja agora, sou portugues tb por isso se quiseres podemos depois discutir algumas cenas de codigo por pm ou assim

</pt>

@people having issues with 1-pixel borders showing fuzzy after 4.0.1: according to http://www.wowinterface.com/forums/s...t=31813&page=4 it seems they changed the way the game's "uiscale" feature works. It seems now you have to disable it (i.e., uncheck the box in the in-game settings) in order to have the same effect as setting "uiscale" to "768/<your resolution height>" prior to 4.0.1. Just a heads up for those interested!

1) Use the SecureAuraHeader to do it, it's not an easy-piece of code to work with tho'.

2) No, you'll have to define it in that string. (or as a string in an attribute, which you can run through self:GetParent():Run('attributeName'), but that will have restrictions you won't like).

Originally Posted by Goldpaw

Couldn't find anything about it here, so I'll mention it:

The cooldown spirals on auras on the party frames flicker as well. Only the cooldown spirals though, not the auras themselves.

I'm guessing this bug is related to the RegisterAttributeDrive bug that causes portraits to flicker?

Yes it's related to RegisterAttributeDriver.

haste · 10-14-10, 11:32 AM

Also, I intended this thread mainly for discussion around the actual oUF API and changes made to it, not your layouts

.

neverg · 10-14-10, 11:41 AM

Originally Posted by haste

Also, I intended this thread mainly for discussion around the actual oUF API and changes made to it, not your layouts

.

Where can I see what is the Quest Icon and Phase Icon? I saw oUF has modules for it now, but dunno what to do with them or what they do. Any hint?

yj589794 · 10-14-10, 11:48 AM

Originally Posted by neverg

Where can I see what is the Quest Icon and Phase Icon? I saw oUF has modules for it now, but dunno what to do with them or what they do. Any hint?

http://github.com/haste/oUF/wiki/element---quest-icon
http://github.com/haste/oUF/wiki/element---phase-icon

The gist script seems to be broken on github at the moment, so the example code can be seen here:
QuestIcon
PhaseIcon

As far as their purpose.... The PhaseIcon is displayed whenever the group member is not in the same phase as the player. The QuestIcon is a little trickier, some mobs have this flag set to display the icon but I am unsure what meaning it has.

neverg · 10-14-10, 12:26 PM

Originally Posted by yj589794

http://github.com/haste/oUF/wiki/element---quest-icon
http://github.com/haste/oUF/wiki/element---phase-icon

The gist script seems to be broken on github at the moment, so the example code can be seen here:
QuestIcon
PhaseIcon

As far as their purpose.... The PhaseIcon is displayed whenever the group member is not in the same phase as the player. The QuestIcon is a little trickier, some mobs have this flag set to display the icon but I am unsure what meaning it has.

Thanks for the clarification.

Another thing, I've tested .disallowVehicleSwap = true and it's not working.

I use it on player and pet styles so when entering a vehicle the Player Frame keeps my Char and the Pet becomes the vehicle.

Anyone experienced same thing?

yj589794 · 10-14-10, 12:30 PM

Originally Posted by neverg

Thanks for the clarification.

Another thing, I've tested .disallowVehicleSwap = true and it's not working.

I use it on player and pet styles so when entering a vehicle the Player Frame keeps my Char and the Pet becomes the vehicle.

Anyone experienced same thing?

Try reading the first post again :-)

neverg · 10-14-10, 12:45 PM

Originally Posted by yj589794

Try reading the first post again :-)

I'm very sorry, forget that. That sucks, I've read the first post before but forgot it somehow. It wasn't returning any error so thought it was a bug.

Thanks again, yj.

Talyrius · 10-14-10, 03:04 PM

Originally Posted by haste

Wait for Blizzard to fix it. =/

Is there any way that we can speed that process along? I could make a post about it on the Cataclysm's UI & Macros Forum, but I wouldn't know what to say to get the attention of Blizzard's UI developers.

haste · 10-14-10, 03:08 PM

Originally Posted by ForeverTheGM

Is there any way that we can speed that process along? I could make a post about it on the Cataclysm's UI & Macros Forum, but I wouldn't know what to say to get the attention of Blizzard's UI developers.

Already notified the person who wrote the code

.

Dawn · 10-14-10, 04:49 PM

Omg, haste is part of the matrix! *spins paranoid conspiracy theories*

Aftermathhqt · 10-15-10, 03:51 PM

Originally Posted by Goldpaw

I have a different problem with portraits on party frames; they flicker.

Constant flickering for no apparent reason at all. I also have portraits on player/target frames, and they don't flicker. So far it appears to only be an issue with the party frames. Not sure if it this also happens on raid/arena frames.

The code I use to display it is very straight forward, no hokus pokus that can explain the behavior I'm getting;

Code:

      local Portrait = CreateFrame( "PlayerModel", nil, self );
      Portrait:SetPoint("TOP", self, "TOP", 0, 0);
      Portrait:SetPoint("BOTTOM", self, "BOTTOM", 0, 0);
      Portrait:SetPoint("RIGHT", self, "LEFT", self:GetHeight(), 0);
      Portrait:SetPoint("LEFT", self, "LEFT", 0, 0);

      self.Portrait = Portrait;

Is this something you're aware of or am I the only one experiencing this?

EDIT:
The portraits aren't merely flickering, they appear to be resetting themselves constantly. The animation constantly restarts, several times each second.

i have the same problem, how do i fix this?

zork · 10-15-10, 04:19 PM

Since I finally have overcome my actionbar problems by rewriting the whole mod I have now time to finish the last part left in my interface. The new 4.0.1 unitframes, so gonna give some response on that next week when I get a closer look at the code.

Any 1.5.x layout uploaded yet?