Mounting event

[Exawatt]

My girlfriend and I quest together all the time, and she's quite fond of /follow. This addon I'm making for her is supposed to display a "Mount Me" button when I begin to mount up while she's following me. It also selects the correct mount (i.e. flying or ground). For some reason I can't seem to get the UNIT_SPELLCAST_START to fire, and I can't figure out why. I've tried UNIT_SPELLCAST_SEND as well, with no luck. I do manage to get the UNIT_SPELLCAST_SUCCEEDED event to fire, but it comes three seconds after I want this addon to display itself.

The window displays fine, and the mounts are selected properly. The only problem is the event notification.

--Determine Correct Mount
local ground, flying
for i=1,GetNumCompanions("MOUNT") do
    local _, creatureName = GetCompanionInfo("MOUNT", i)
    if( creatureName == "Dreadsteed" ) then
        ground = i
    end
    if( creatureName == "Green Wind Rider" ) then
        flying = i
    end
end
 
--Ground Mounting Function
local function MountGround()
    CallCompanion("MOUNT", ground)
    FollowHelper:Hide()
end
 
--Flying Mounting Button
local function MountFlying()
    CallCompanion("MOUNT", flying)
    FollowHelper:Hide()
end
 
--Boolean "Following" flag
local FH_isFollowing = false
 
--Event function
local function FollowHelper_EventHandler(self, event, ...)
    if( event == "UNIT_SPELLCAST_START" and arg1 == "Chillah" ) then
        if( arg2 == "Swift Zhevra" ) then
            mountButton:SetScript("OnClick", MountGround)
            FollowHelper:Show()
        elseif( arg2 == "Blue Wind Rider" ) then
            mountButton:SetScript("OnClick", MountFlying)
            FollowHelper:Show()
        end
 
    elseif( event == "AUTOFOLLOW_BEGIN" and arg1 == "Chillah" ) then
        FH_isFollowing = true
        
    elseif( event == "AUTOFOLLOW_END" ) then
        FH_isFollowing = false
    end
end
 
--Create frames and such
local frame = CreateFrame("Frame", "FollowHelper")
frame:SetFrameStrata("HIGH")
frame:ClearAllPoints()
frame:SetPoint("CENTER", UIParent, "CENTER")
frame:SetWidth(75)
frame:SetHeight(50)
frame:RegisterEvent("UNIT_SPELLCAST_START")
frame:RegisterEvent("AUTOFOLLOW_BEGIN")
frame:RegisterEvent("AUTOFOLLOW_END")
frame:SetScript("OnEvent", FollowHelper_EventHandler)
frame:SetBackdrop({bgFile = "Interface/Tooltips/UI-Tooltip-Background", 
                   edgeFile = "Interface/Tooltips/UI-Tooltip-Border", 
                   tile = true, tileSize = 16, edgeSize = 16, 
                   insets = { left = 4, right = 4, top = 4, bottom = 4 }})
 
--Create "Mount Me!" button
local mountButton = CreateFrame("Button", "FH_MountButton", FollowHelper, "UIPanelButtonTemplate")
mountButton:SetWidth(75)
mountButton:SetHeight(25)
mountButton:ClearAllPoints()
mountButton:SetPoint("TOPLEFT", FollowHelper, "TOPLEFT")
mountButton:SetText("Mount me!")
 
--Create "Do Nothing." button
local cancelButton = CreateFrame("Button", "FH_CancelButton", FollowHelper, "UIPanelButtonTemplate")
cancelButton:SetWidth(75)
cancelButton:SetHeight(25)
cancelButton:ClearAllPoints()
cancelButton:SetPoint("TOPLEFT", FollowHelper, "TOPLEFT", 0, -25)
cancelButton:SetText("Do Nothing.")
cancelButton:SetScript("OnClick", function() FollowHelper:Hide() end)

[kraftman]

I think all gf's should have a "Mount Me!" button

More seriously though, have you printed arg1 and arg2 to check they are what you think they are? I think the first argument is the unit ("target") rather than the unitname.

Also its better to use the variables passed in ... than the globals.

eg

local arg1, arg2 = ...

Hope this helps!

[tsadok]

I got my troll a hawkstrider and wanted him to say stuff when he mounted. I registered a frame to all events and got nothing when I mounted, so I suspect there isn't a specific mounting event, strange as that may seem. One thing I didn’t get round to trying was periodically testing for the mount buff (or these days, events).

If it's just between you two, you could attach a script to your mount macro like:

/script SendAddonMessage("Gf&me", "Ground", "WHISPER", "Gfsname")
and her client could pick that up.

[Exawatt]

Originally Posted by kraftman I think all gf's should have a "Mount Me!" button

It was originally going to say "Ryan is mounting" (then give options to mount), but now I'm going to have it toss in a randomly-occuring message to "Mount Ryan!", just for that gem.

Originally Posted by kraftman More seriously though, have you printed arg1 and arg2 to check they are what you think they are? I think the first argument is the unit ("target") rather than the unitname. Also its better to use the variables passed in ... than the globals.

I had it as the variables previously, but it didn't really matter: The addon wasn't hitting that point, since the event wasn't firing (at all) when I mounted up. They were changed as a last resort to get it working

Originally Posted by tsadok If it's just between you two, you could attach a script to your mount macro like: /script SendAddonMessage("Gf&me", "Ground", "WHISPER", "Gfsname") and her client could pick that up.

Didn't think of that, but it makes it work all the same. Thanks.


Though my addon is working now, I'd still like to know why the original didn't work. If anyone could shed some light on the UNIT_SPELLCAST_START and/or UNIT_SPELLCAST_SEND events, that'd be appreciated.

[EDIT] Oh, and if anyone was interested; here's the finished addon (sans my own tweaks):

FollowMounter.lua

--Settings
local FH_FavGround = "Dreadsteed" --Ground mount to choose
local FH_FavFlying = "Green Wind Rider" --Flying mount to choose

--Determine Correct Mount Positions
local FH_ground, FH_flying
for i=1,GetNumCompanions("MOUNT") do
	local _, creatureName = GetCompanionInfo("MOUNT", i)
	if( creatureName == FH_FavGround ) then
		FH_ground = i
	end
	if( creatureName == FH_FavFlying ) then
		FH_flying = i
	end
end

--Ground Mounting Function
local function FH_MountGround()
	CallCompanion("MOUNT", FH_ground)
	FollowHelper:Hide()
end

--Flying Mounting Function
local function FH_MountFlying()
	CallCompanion("MOUNT", FH_flying)
	FollowHelper:Hide()
end

local FH_isFollowing = false --Boolean "Following" flag
FH_Who = "" --Player you will be following

--Event function
local function FollowHelper_EventHandler(self, event, ...)
	if( event == "CHAT_MSG_ADDON" ) then
		local prefix, message, channel, sender = ...
		if( FH_isFollowing and prefix == "FH" and channel == "WHISPER" and sender == FH_Who ) then
			if( message == "ground" ) then
				--CallCompanion("MOUNT", FH_ground) --uncomment for automount
					--will not work if the person you are following quickly stops moving and mounts,
					--since you will still be moving for a second
				--comment out next two lines for automount
				FH_MountButton:SetScript("OnClick", FH_MountGround)
				FollowHelper:Show()
			elseif( message == "flying" ) then
				--CallCompanion("MOUNT", FH_flying) --uncomment for automount (see note above)
				--comment out next two lines for automount
				FH_MountButton:SetScript("OnClick", FH_MountFlying)
				FollowHelper:Show()
			end
		end
		
	elseif( event == "AUTOFOLLOW_BEGIN" ) then
		FH_Who = (...)
		FH_isFollowing = true
		
	elseif( event == "AUTOFOLLOW_END" ) then
		FH_isFollowing = false
	end
end

--Create frames and such
local f = CreateFrame("Frame", "FollowHelper")
f:SetFrameStrata("HIGH")
f:ClearAllPoints()
f:SetPoint("CENTER", UIParent, "CENTER")
f:SetWidth(85)
f:SetHeight(60)
f:RegisterEvent("CHAT_MSG_ADDON")
f:RegisterEvent("AUTOFOLLOW_BEGIN")
f:RegisterEvent("AUTOFOLLOW_END")
f:SetScript("OnEvent", FollowHelper_EventHandler)
f:SetBackdrop({bgFile = "Interface/Tooltips/UI-Tooltip-Background", 
                   edgeFile = "Interface/Tooltips/UI-Tooltip-Border", 
                   tile = true, tileSize = 16, edgeSize = 16, 
                   insets = { left = 4, right = 4, top = 4, bottom = 4 }})
f:Hide()

--Create "Mount Me!" button
local b = CreateFrame("Button", "FH_MountButton", FollowHelper, "UIPanelButtonTemplate")
b:SetWidth(75)
b:SetHeight(25)
b:ClearAllPoints()
b:SetPoint("TOPLEFT", FollowHelper, "TOPLEFT", 5, -5)
b:SetText("Mount me!")

--Create "Do Nothing." button
b = CreateFrame("Button", "FH_CancelButton", FollowHelper, "UIPanelButtonTemplate")
b:SetWidth(75)
b:SetHeight(25)
b:ClearAllPoints()
b:SetPoint("TOPLEFT", FollowHelper, "TOPLEFT", 5, -30)
b:SetText("Do nothing.")
b:SetScript("OnClick", function() FollowHelper:Hide() end)

The person being followed uses this instead of their normal mounts:

/script if(not IsMounted()) then CallCompanion("MOUNT", MOUNT_POSITION_INT) SendAddonMessage("FH", ("flying" or "ground"), "WHISPER", ("PERSON_FOLLOWING_YOU") else Dismount() end

[tsadok]

I looked at UNIT_SPELLCAST_START and it returned "player" as the first argument when I mounted, so that could be your problem.

Also, using arg1 etc. is deprecated or obsolete. If it still works, arg1 may have been referring to the event frame, and arg3 might have been the unit.

[Exawatt]

Originally Posted by tsadok I looked at UNIT_SPELLCAST_START and it returned "player" as the first argument when I mounted, so that could be your problem.

I wasn't getting it to fire at all. The code in the first post has another check made on "arg1" in the same if conditional, but it was separate in tests. The main problem was the event wasn't showing up (at all).

I wasn't looking for my own event, though. Rather, character A begins mounting, and character B is waiting for the event to fire.

[Auren]

I've been trying to get a code similar to this to work.
I need it to detect when casting a mount on a char thats in my group and tell me.
Sadly I have the same problem as you.
Also cant get the addon you posted to work either

[Exawatt]

Originally Posted by Auren Also cant get the addon you posted to work either

Well the version I'm using now uses method tsadok proposed. The person mounting up changes their mount action into a macro which includes sending an addon message, then the AddOn frame listens for that message. If you wanted it to work with a group, change a couple of things:

local function MyAddon_EventHandler(self, event, ...)
  local prefix, message, channel, sender = ...
  if( prefix == "MA" and channel == "PARTY" ) then
    DEFAULT_CHAT_FRAME:AddMessage(sender.." is summoning their "..message.." mount.")
  end
end

local f = CreateFrame("Frame", "MyAddon")
f:RegisterEvent("CHAT_MSG_ADDON")
f:SetScript("OnEvent", MyAddon_EventHandler)

Then have your party members use the following macro instead of their mounts:

/script if(not IsMounted()) then CallCompanion("MOUNT", %MOUNT_POSITION_INT%) SendAddonMessage("MA", %"flying" or "ground"%, "PARTY") else Dismount() end

That is, if you always play with the same people... Otherwise we're back at square 1.

Maybe the event is busted?

[Amethyst]

Maybe COMPANION_UPDATE might do it? It's new as of 3.0

[Exawatt]

Originally Posted by Amethyst Maybe COMPANION_UPDATE might do it? It's new as of 3.0

That only has one argument (which only says "MOUNT") and it fires when the mount appears (end of casting), as well as when the mount is unsummoned (but does not differentiate between the two). There's no way to tell the difference between air and ground, or if the other person is mounting or unmounting.

It does seem to always fire, though, which is more than the others have been doing.

[Crowfeather]

Originally Posted by Exawatt That only has one argument (which only says "MOUNT") and it fires when the mount appears (end of casting), as well as when the mount is unsummoned (but does not differentiate between the two). There's no way to tell the difference between air and ground, or if the other person is mounting or unmounting. It does seem to always fire, though, which is more than the others have been doing.

The problem for me wasn´t that it didn´t always fire (it did for me) but that it doesn´t seem to differentiate between yourself and others (dis)mounting (got spammed with the event in dalaran) and - even more important - it fires before IsMounted() registers the player as beeing mounted. In combination with the lack of knowledge if if fired because someone mounted or dismounted makes the event rather worthless. I solved my problem by just polling IsMounted() at every OnUpdate() which feels rather clumsy. If anyone knows a better solution I´m all ears.