MasterLoot order

[Phanx]

Here we go. The issue on Magtheridon was caused by the bag; fixed by accounting for item types not in the sorting list. Also added another layer of sorting by quality, so greens aren't sorted as equippable items. Used it on a full clear of Black Temple without errors.

[ConstanT1ne32]

Thanks!

Ill post if I find anything else

[ConstanT1ne32]

loot from boss was not appearing at all, did appear after a few /reloadui

ps. same error pops on every time i loot.

1x Butsu\butsu-2.1.1.lua:141: attempt to index local 'color' (a nil value)
Butsu\butsu-2.1.1.lua:141: in function `?'
Butsu\butsu-2.1.1.lua:35: in function <Butsu\butsu.lua:34>

Locals:
self = Butsu {
0 = <userdata>
LOOT_CLOSED = <function> defined @Butsu\butsu.lua:220
LOOT_OPENED = <function> defined @Butsu\butsu.lua:79
LoadPosition = <function> defined @Butsu\butsu.lua:254
OPEN_MASTER_LOOT_LIST = <function> defined @Butsu\butsu.lua:230
UPDATE_MASTER_LOOT_LIST = <function> defined @Butsu\butsu.lua:235
title = <unnamed> {
}
AnchorSlots = <function> defined @Butsu\slots.lua:145
LOOT_SLOT_CLEARED = <function> defined @Butsu\butsu.lua:209
UpdateWidth = <function> defined @Butsu\slots.lua:131
SavePosition = <function> defined @Butsu\butsu.lua:245
}
event = "LOOT_OPENED"

[Phanx]

Which boss? What was the loot?

[ConstanT1ne32]

I think my loot master means on every boss and everytime. Im actually traveling so I cant check it myself until next week. I asked him to give more info when it lua pops.

[ConstanT1ne32]

Yeah so its all of BRF, including trash, grey items and so on.

[Phanx]

Well, based on the error message you gave, the error is caused by something in the loot table reporting an invalid quality value (gray, common, rare, etc.) and I find it really hard to believe that every single trash mob in BRF is dropping bugged items, so it would really be helpful to know what items are actually dropping when the error occurs.

[Talyrius]

GetLootSlotInfo can, occasionally, return a nil quality. After closing the loot window and reopening it, the correct quality value is then returned.

A quick fix would be to replace line 140 with:

			local color = ITEM_QUALITY_COLORS[quality or -1]

[ConstanT1ne32]

ill try that and get more info about error.

[ConstanT1ne32]

in BRF LFR

1x Butsu\butsu-2.1.1.lua:148: attempt to compare number with nil Butsu\butsu-2.1.1.lua:148: in function `?' Butsu\butsu-2.1.1.lua:35: in function <Butsu\butsu.lua:34> [c]: in function `TurnOrActionStop' [string "turnoraction"]:4: in function <[string "turnoraction"]:1> Locals: self = Butsu { 0 = <userdata> LOOT_CLOSED = <function> defined @Butsu\butsu.lua:220 LOOT_OPENED = <function> defined @Butsu\butsu.lua:79 LoadPosition = <function> defined @Butsu\butsu.lua:254 OPEN_MASTER_LOOT_LIST = <function> defined @Butsu\butsu.lua:230 UPDATE_MASTER_LOOT_LIST = <function> defined @Butsu\butsu.lua:235 title = <unnamed> { } AnchorSlots = <function> defined @Butsu\slots.lua:145 LOOT_SLOT_CLEARED = <function> defined @Butsu\butsu.lua:209 UpdateWidth = <function> defined @Butsu\slots.lua:131 SavePosition = <function> defined @Butsu\butsu.lua:245 } event = "LOOT_OPENED"

[Phanx]

And that error indicates the loot reported no quantity... I think maybe there's something wrong with your (or your friend's) WoW installation. Neither of those sections (comparing quantity, comparing quality) have been changed from the original Butsu code, and I've never seen any such errors in many years of using the addon.

If you can't fix your installation (open the Battle.net launcher, select WoW, click the "Options" dropdown right under the big WoW logo, select "Scan & Repair") I guess you can just band-aid it the same way Talyrius suggested band-aiding the missing quality....

Line 148:

			if(quantity and quantity > 1) then
				slot.count:SetText(quantity)
				slot.count:Show()