Nameplates

[Dridzt]

Originally Posted by Maul Not entirely, I turned the taint log off and still had issues until I narrowed down my crash issue to modifying a custom gametooltip (like used for tooltip scanning). I eliminated the modifications as well as the :GetRegion() calls on the custom tooltip and only then did the crashes stop. And I still crash on a /reload occasionally with the taint log off.

You can add WorldFrame:GetChildren() to the list of things that hard crash the beta client (build 15882)

(typical for nameplate addons looking for nameplates)

Note: Pulled these posts from MoP beta topic as they're no longer MoP specific. - Haleth

[ballagarba]

Originally Posted by Dridzt You can add WorldFrame:GetChildren() to the list of things that hard crash the beta client (build 15882) (typical for nameplate addons looking for nameplates)

In case you didn't know: http://www.wowinterface.com/forums/s...9&postcount=30

[Haleth]

You still need to use WorldFrame:GetChildren() to actually iterate through potential frames. Then you can check them by name.

It would be much better if we could hook into the function that creates nameplates, but we don't have access to it.

[p3lim]

Originally Posted by Haleth You still need to use WorldFrame:GetChildren() to actually iterate through potential frames. Then you can check them by name.

Actually...

local index = 1
 
local addon = CreateFrame('Frame')
addon:SetScript('OnUpdate', function()
    while _G['NamePlate' .. index] do
        local frame = _G['NamePlate' .. index]
 
        -- do whatever
 
        index = index + 1
    end
end)
addon:Show()

[Dridzt]

Originally Posted by p3lim Actually...

That's a simple and clever workaround for the bug actually,
might have to poach it for a couple addons that I've had to keep disabled in beta.

Edit: Scratch that, a while loop won't work sadly, nameplate frames are reused for one so you don't always have a nice collection of sequential frames from 1 to n.
Even if we did have that, it would still need to wrap around to index 1 when it exits the while loop.
It's food for thought definitely...

And another function that hard crashes the client (no addons present) GetDestinationReforgeStats() (build 15882)

[p3lim]

Originally Posted by Dridzt That's a simple and clever workaround for the bug actually, might have to poach it for a couple addons that I've had to keep disabled in beta. Edit: Scratch that, a while loop won't work sadly, nameplate frames are reused for one so you don't always have a nice collection of sequential frames from 1 to n. Even if we did have that, it would still need to wrap around to index 1 when it exits the while loop. It's food for thought definitely...

local function Update(self)
    -- do whatever
end
 
local index = 1
 
local addon = CreateFrame('Frame')
addon:SetScript('OnUpdate', function()
    while _G['NamePlate' .. index] do
        local frame = _G['NamePlate' .. index]
        frame:HookScript('OnShow', Update)
 
        Update(frame)
 
        index = index + 1
    end
end)
addon:Show()

[Haleth]

Okay, p3lim, that's clever. Should be quite a bit more efficient

[villiv]

really helpful thread. thank you for sharing this.

since all we like efficiency, do CVars-checking will help as well? or useless thoughts?

local f = CreateFrame('Frame')
local a = f:CreateAnimationGroup()
a:CreateAnimation():SetDuration(1/3)
a:SetLooping('REPEAT')
a:SetScript('OnLoop', function ()
  -- LF Nameplates
end)
 
local cvars = {
    nameplateShowFriends = true, nameplateShowFriendlyPets = true, nameplateShowFriendlyGuardians = true, nameplateShowFriendlyTotems = true,
    nameplateShowEnemies = true, nameplateShowEnemyPets = true, nameplateShowEnemyGuardians = true, nameplateShowEnemyTotems = true,
}
 
local function check ()
    for cvar in next, cvars do if ( GetCVarBool(cvar) ) then return a:Play() end end
    return a:Stop()
end
 
hooksecurefunc('SetCVar', function (cvar) if ( cvars[cvar] ) then return check() end end)