GetTradeSkillReagentInfo freezes client

[Telarin]

Ok, I am trying to do what should be a relatively simple task, which is iterate through a set of tradeskill reagents, and calculate some information based off them. Here is what I have:

The variable "i" is an index that goes through each TradeSkill line, excluding headers.

numReagent = GetTradeSkillNumReagents(i)
for r = 1, numReagents do
  local reagentLink = GetTradeSkillReagentItemLink(i,r);
  local _,_,reagentCount = GetTradeSkillReagentInfo(i,r);
end

This little bit of code locks the client up completely, and I have to do an "End Task" from the Task Manager. If I comment out the second line inside the loop (local _,_,reagentcount = GetTradeSkillReagentInfo(i,r); ), then the code runs through within a few seconds, and there are no problems.

Any idea what might be causing this to happen? Any idea if there are any workarounds for this problem that will allow me to get the reagentCount for a particular Trade Skill Reagent?

[Torhal]

I'm wondering why you need to look up the reagent's itemlink, when you're not using it at all inside the loop, and using it outside of the loop is impossible since it's been declared as local.

As to your problem: This may be due to the fact that you're not accounting for all of the return values - you're catching three of four. They are:

reagentName, reagentTexture, reagentCount, playerReagentCount = GetTradeSkillReagentInfo(tradeSkillRecipeId, reagentId);

[Telarin]

I actually am using all of the values that I have retrieved there. However, everything except those two lines of code is currently commented out in order to narrow down the problem function.

Apparently it has something to do with calling GetTradeSkillReagentItemLink and GetTradeSkillReagentInfo so close together with the same indexes. I worked around it by calling GetTradeSkillReagentInfo first, then calling GetItemInfo with the reagent name returned by GetTradeSkillReagentInfo. Not exactly elegant, but it seems to work without freezing the client.

[Telarin]

Nevermind, the GetItemInfo method does not work as well as it first appeared, since it returns nil for any reagents that aren't currently in the clients item cache.

[Telarin]

Ok, basically what was happening is that this code was triggered by the TRADESKILL_UPDATE event. If there was already an update in progress, and WoW fired a second update, things went horribly wrong. I simply added some basic locking code so that it could only run the updates one at a time.

essentially:

if (isLocked) return; end
isLocked = true;
-- update code here
isLocked = false;

This seems to have solved the issue.