default unitframes healthtext script help

[zin99]

hi,

first of all: my lua knowledge isn't very advanced, i try to learn but eventually don'T know how to handle this problem, that's why i came here to ask for your help.

i picked up a script at arenajunkies (yeah i know, a lot of them are poorly coded) that reduces the health and power text on statusbars of the unitframes to only their current values (e.g. 150k instead of 150k/150k).

this script used an OnUpdate function which made it consume nearly 5 times as much cpu cycles as the entire rest of my ui, and i wanted to make more performance friendly.

i tried to achieve this in two ways ways but none of them really worked - first i read an article about how to throttle an OnUpdate function but i wasn't able to properly adapt it to this script and then i looked at code code of thek unitframes, where the healthtext is entirely updated based on certain events.

this is what i came up with but it's far from good - when mouseovering the frame or even every 2 or 3 tenth of second it randomly switches back to the default display of the text string. i hope some can take some time and look at this code, thanks in advance.

local CurrentValues = CreateFrame("Frame")

CurrentValues:RegisterEvent("UNIT_HEALTH");
CurrentValues:RegisterEvent("PLAYER_ENTERING_WORLD");
CurrentValues:RegisterEvent("PLAYER_TARGET_CHANGED");
CurrentValues:RegisterEvent("PLAYER_FOCUS_CHANGED");

local function HPMP(self, event, ...)

                local PlayerHealth = UnitHealth("player")
                local PlayerMana = UnitMana("player")
                
                local TargetHealth = UnitHealth("target")
                local TargetMana = UnitMana("target")
                
                local FocusHealth = UnitHealth("focus")
                local FocusMana = UnitMana("focus")
                
                
                PlayerFrameHealthBar.TextString:SetText(TextStatusBar_CapDisplayOfNumericValue(PlayerHealth))
                PlayerFrameManaBar.TextString:SetText(TextStatusBar_CapDisplayOfNumericValue(PlayerMana))
                
                TargetFrameHealthBar.TextString:SetText(TextStatusBar_CapDisplayOfNumericValue(TargetHealth))
                TargetFrameManaBar.TextString:SetText(TextStatusBar_CapDisplayOfNumericValue(TargetMana))
                
                FocusFrameHealthBar.TextString:SetText(TextStatusBar_CapDisplayOfNumericValue(FocusHealth))
                FocusFrameManaBar.TextString:SetText(TextStatusBar_CapDisplayOfNumericValue(FocusMana))
end
CurrentValues:SetScript("OnEvent", HPMP);

[Phanx]

Something like this would probably work better:

--  Make a list of all the text strings you want to affect:
local textStrings = {
    PlayerFrameHealthBar.TextString,
    PlayerFrameManaBar.TextString,
    TargetFrameHealthBar.TextString,
    TargetFrameManaBar.TextString,
    FocusFrameHealthBar.TextString,
    FocusFrameManaBar.TextString,
}
 
--  Post-hook the function that updates the text on the health and mana
--  bars. This causes your function to be run every time the original
--  function runs, after the original function, so you can overwrite
--  changes made by the original function.
hooksecurefunc("TextStatusBar_UpdateTextStringWithValues", function(statusFrame, textString, value, valueMin, valueMax)
    -- Check to see if this text string is one you want to change:
    if not textStrings[textString] then
        --  You don't care about this text string, so quit:
        return
    end
 
    --  Get the new text to show on the bar:
    local newText = TextStatusBar_CapDisplayOfNumericValue(value)
 
    --  Set the contents of the text string to that text:
    textString:SetText(newText)
end)

[zin99]

thanks a lot phanx, i really appreciate your help. it seems to work perfectly right now

[zin99]

actually i was wrong, and it wouldnt work (maybe i just implemented your code wrong, in generally expect the error to more likely be on my side concerning anything with lua ) but i found something.

obviously i found the default code for the textstring function on wowprogramming and tweaked it:

function TextStatusBar_UpdateTextStringWithValues(statusFrame, textString, value, valueMin, valueMax)
	if ( ( tonumber(valueMax) ~= valueMax or valueMax > 0 ) and not ( statusFrame.pauseUpdates ) ) then
		statusFrame:Show();
		if ( value and valueMax > 0 and ( GetCVarBool("statusTextPercentage") or statusFrame.showPercentage ) and not statusFrame.showNumeric) then
			if ( value == 0 and statusFrame.zeroText ) then
				textString:SetText(statusFrame.zeroText);
				statusFrame.isZero = 1;
				textString:Show();
				return;
			end
			value = tostring(math.ceil((value / valueMax) * 100)) .. "%";
			if ( statusFrame.prefix and (statusFrame.alwaysPrefix or not (statusFrame.cvar and GetCVar(statusFrame.cvar) == "1" and statusFrame.textLockable) ) ) then
				textString:SetText(statusFrame.prefix .. " " .. value);
			else
				textString:SetText(value);
			end
		elseif ( value == 0 and statusFrame.zeroText ) then
			textString:SetText(statusFrame.zeroText);
			statusFrame.isZero = 1;
			textString:Show();
			return;
		else
			statusFrame.isZero = nil;
			if ( statusFrame.capNumericDisplay ) then
				value = TextStatusBar_CapDisplayOfNumericValue(value);
				valueMax = TextStatusBar_CapDisplayOfNumericValue(valueMax);
			end
			if ( statusFrame.prefix and (statusFrame.alwaysPrefix or not (statusFrame.cvar and GetCVar(statusFrame.cvar) == "1" and statusFrame.textLockable) ) ) then
				textString:SetText(statusFrame.prefix.." "..value.." / "..valueMax);
			else
				textString:SetText(value);
-- ORIGINAL:		textString:SetText(value.." / "..valueMax);
			end
		end
		
		if ( (statusFrame.cvar and GetCVar(statusFrame.cvar) == "1" and statusFrame.textLockable) or statusFrame.forceShow ) then
			textString:Show();
		elseif ( statusFrame.lockShow > 0 and (not statusFrame.forceHideText) ) then
			textString:Show();
		else
			textString:Hide();
		end
	else
		textString:Hide();
		textString:SetText("");
		if ( not statusFrame.alwaysShow ) then
			statusFrame:Hide();
		else
			statusFrame:SetValue(0);
		end
	end
end

it works, but my question now is:
is there any downside of having this functions in a seperate custom lua file (obv. additionaly to the place where they are located normally). performance seems fine, like 0.05 cpu cycles/sec.

[Phanx]

Well, simply replacing a function is always more efficient, performance-wise, than post-hooking it, since only one function (yours) runs instead of two (the original plus yours). There are some situational disadvantages, though.

First, replacing functions breaks other addons that have already hooked the function, because their hooks were attached to the original function, and there's no way to transfer that attachment to your new function. If you're only using the code for yourself, it's not a big deal, but it's something to keep in mind.

Second, replacing functions, or insecurely hooking them, introduces taint. If the function, or any values it returns, or anything it touches while running, is used by a secure frame, you can break functionality this way.

[zin99]

again thanx for being so patient and explaining stuff to a beginner phanx.

i think i'll leave it as it is for now, since i couldnt get the post hook function to work. so far i did not experience any lua errors und reduced the overall cpu load the script had in the beginning by roughly 2000%.

it's really interesting how such small pieces of code, when poorly written, can impact performance. in this case it even "outcycled" my extremely complex pve tell me when setup.