Detecting if instance is finished

[jlnugnez]

Hello!

I'm writing an addon and trying to detect if an instance is finished.

Right now I can detect in LFG instances the event: LFG_COMPLETION_REWARD

But that event is only thrown when in a LFG party (not a party you create by yourself) and only if there is a reward (for example, if you do the Headless Horseman instance twice in a day, you only get that event the 1st time).

I imagine I could create a table with the last boss of each instance and when he dies I could register it as the end of the instance... but seems a "dirty" way of doing it... there must be somesort of event thrown that I can catch and detect it.

Has anyone had this problem or is there a developer reading this thread that can give a hand?

Thanks!!

[Talyrius]

To my knowledge, there is no event fired for completing a dungeon in a manually formed party. You can use /eventtrace a few seconds prior to killing the final boss to make sure.

Iterating through a table containing boss GUID's when something dies is probably going to be your only option.

[jlnugnez]

Originally Posted by ForeverTheGM To my knowledge, there is no event fired for completing a dungeon in a manually formed party. You can use /eventtrace a few seconds prior to killing the final boss to make sure. Iterating through a table containing boss GUID's when something dies is probably going to be your only option.

I'm checking /eventtrace but the amount of events thrown in those couple of seconds is enormous. Havent seen any event that may be useful, that is why I thought about asking...

Not being able to manage it in "normal" groups would be ok for the moment... but the "headless horseman" instance worries me, as it is a LFG instance but with no reward at certain times

[Vlad]

My man, in LFD you got an event that fires when the dungeon end boss dies, but otherwise you don't really know unless you track the combat log deaths... I made an addon a while ago LFDRating (back when you played with people from ~4-5 other realms) to keep some sort of karma system going on, in any case I had to detect boss deaths too and the only way I found was finding their deaths in the combatlog.

[Dridzt]

End-boss GUIDs (you can find a comprehensive list of all bosses - not just end in LibBossIDs-1.0) and checking those at C_L_E_U|UNIT_DIED would cover 90% of cases.

The other 10% are when the end boss changes depending on instance level / heroic mode (eg. Deadmines, SFK etc)
and when the end boss doesn't actually die but instead flees and spawns a lootbox or whatever alternative mechanic
(eg. LK in 5man, Mal'ganis in culling of Stratholme etc)
These would need to be detected by monitoring boss yell or emote for the specific end-trigger.

That's the only way to cover all your bases afaik.

[jlnugnez]

Originally Posted by Vladinator My man, in LFD you got an event that fires when the dungeon end boss dies, but otherwise you don't really know unless you track the combat log deaths... I made an addon a while ago LFDRating (back when you played with people from ~4-5 other realms) to keep some sort of karma system going on, in any case I had to detect boss deaths too and the only way I found was finding their deaths in the combatlog.

Hehehe, didn't know your addon existed, otherwise I'd started there! Its a good thing anyway, I needed to start from scratch to learn more, my programming skills are very rusty.

That's what I'm doing, keeping some rating of random LFD dungeons as I'm tired of getting quitters and people I'd rather have in the ignore list. Getting the instance start is easy, but the end is becoming tricky. I don't get that having the LFG_COMPLETION_REWARD, I guess that there's also some sort of end-dungeon event in for guild experience in guild-dungeon runs, and probably some others... those event's are thrown only under some circumstances and there's nothing that marks the end of the instance every time.

[jlnugnez]

Originally Posted by Dridzt End-boss GUIDs (you can find a comprehensive list of all bosses - not just end in LibBossIDs-1.0) and checking those at C_L_E_U|UNIT_DIED would cover 90% of cases. The other 10% are when the end boss changes depending on instance level / heroic mode (eg. Deadmines, SFK etc) and when the end boss doesn't actually die but instead flees and spawns a lootbox or whatever alternative mechanic (eg. LK in 5man, Mal'ganis in culling of Stratholme etc) These would need to be detected by monitoring boss yell or emote for the specific end-trigger. That's the only way to cover all your bases afaik.

Thanks! In the end it's a little more cumbersome but with LibBossIDs I guess it can be solved easily...

Hmm, maybe a "InstanceEndLib" could be useful for someone else too... if I manage to finish my addon I'll encapsulate that functionality in a library.