macro switch by sacrified (or summoned) pet

[démamik]

Hi

I would like to switch a macro when I sacrifice (or summon) my voidwalker because with the grimoire of sacrifice I must use "command demon" instead of "Shadow Bulwark" so I can't use this macro with my others pets/sacrifice ...

Thanks

[SDPhantom]

From my testing, using /cast Command Demon after sacrificing a Voidwalker uses Shadow Bulwark anyway. I think it's safe to say that command will work on any ability granted by sacrifice.

[démamik]

I know that, it's my problem...

It will be more explicit by example

My first macro was:
/cast Shadow Bulwark
/cast Unending Resolve

but shadow bulwark doesn't work when I sacrifice the voidwalker

So my actual macro:
/cast [pet:voidwalker]Shadow Bulwark
/cast [no pet] Command Demon
/cast Unending Resolve

but I don't want to use spell lock or seduce when I use Unending Resolve...

[SDPhantom]

/cast [pet:voidwalker] Shadow Bulwark should only activate when you have your Voidwalker out, not sacrificed. Note, the condition may still turn out true until your demon's corpse despawns. Also the spell seems to continue pointing to the ability on your now dead Voidwalker instead of the one you were just granted. It seems going through Control Demon is the only way to access the ability sacrifice grants you.

[démamik]

thanks to translate me, maybe someone have a solution?

Note, that's not related to my problem but you could avoid the despawn duration problem with a sacrifice macro:
/cast Grimoire of Sacrifice
/script PetDismiss()

[SDPhantom]

Originally Posted by démamik thanks to translate me, maybe someone have a solution?

It's how the game handles the demon and player-given abilities, there's no way around it.

Originally Posted by démamik Note, that's not related to my problem but you could avoid the despawn duration problem with a sacrifice macro: /cast Grimoire of Sacrifice /script PetDismiss()

It doesn't really bother me anyway.

[démamik]

is there something that prevents an addon to switch a macro with events summon/sacrifice?

[d87]

It should be "nopet", without a space. Other than that your macro should work.

[démamik]

Sorry for this mistake and apologize for not being clear about what I'm looking for...

I know these marco "works" but they doesn't respond to my needs.

I want a macro that cast shadow bulwark when I have my voidwalker up AND when I sacrifice it BUT that doesn't cast others demon abilities when I have summoned or sacrificed another one.

And actually, the only way to do it is to switch the macro when I summon/sacrifice another demon, so maybe there's an addon to fix that...

Note: a macro that could change another macro will do the trick too
Note2: something that only works out of combat should be convenient enough

[d87]

local f = CreateFrame("Frame")

local function MacroEdit(name, body)
    if not InCombatLockdown() then
	   local macroid = GetMacroIndexByName(name)
	   EditMacro(macroid, name, 1, body, 1)
    end
end

f:RegisterEvent("PLAYER_LOGIN");
f:RegisterEvent("PLAYER_REGEN_ENABLED");
f:RegisterEvent("SPELLS_CHANGED");
f:SetScript("OnEvent", function()
    local name, _, tex = GetSpellInfo(119898)
    if tex == "Interface\\Icons\\Spell_Shadow_AntiShadow" then -- idk how else to check which pet was sacrificed
        MacroEdit("YourMacroName", [[/say macrotext1 ]])
    else
        MacroEdit("YourMacroName", [[/say macrotext2 ]])
    end
end)

Something like that, I haven't tried it myself tho... Also you should create macro named "YourMacroName" beforehand

[démamik]

Thank you very much! It looks like what I'm looking for

I will try it when I have more time and give you returns.

[SDPhantom]

The problem with trying to have an addon deal with macros is Blizzard locks them when you're in combat. Trying to get around this throws up taint errors. This is the reason I was trying to stick with macro conditionals. I know I'm picky when it comes to addon code I develop. If for any reason, an addon isn't able to function 100% of the time (in and out of combat), I don't release it.



If you're going to try to have it use the Voidwalker's ability instead when it's up, you can have it written with one /cast command instead of two. The following macro command has your Voidwalker use Shadow Bulwark if it's out and alive, otherwise, it forces Control Demon to cast on yourself. This means Control Demon will only cast successfully if the spell can target the player. This can only happen with Shadow Bulwark and Singe Magic. There's also a safety mechanism built into the first condition to prevent Control Demon to be used if any demon other than your Voidwalker is out. The command will just fail silently.

/cast [pet,@pet,nodead] Shadow Bulwark; [@player] Command Demon

[démamik]

Thanks SDPHantom, the @player is a good trick and I misunderstood the behavior of Shadow Bulwark without sacrifice...
So my final macro is:

#showtooltip Unending Resolve
/cast [@player,nopet] Command Demon
/cast Unending Resolve

It will also cast cauterize master when I sacrifice my imp but that shouldn't be a problem.

@d87:
Sorry there will be no use this time for your code, but it's very instructional, and maybe I will use some parts of it for another macro idea... So, thanks again.