Help with ModifiedClick bindings

[fRodzet]

Greetings,

-- create a table which contains the index you'd like to show in your tooltip
local supportedIndexType = {
    item = true,
    achievement = true,
    quest = true,
    unit = true,
    enchant = true,
    spell = true,
    talent = true,
    glyph = true,
    }
-- create a function which contains the scripts necessary to display the tooltip we need
local function ChatlinkTooltip_Show(self, linkData)
    local linkType = string.match(linkData, "(.-):")
        if supportedIndexType[linkType] then
            GameTooltip:SetOwner(self, "ANCHOR_CURSOR")
            GameTooltip:SetHyperlink(linkData)
            GameTooltip:Show()
        end 
end
 
for frameType = 1, NUM_CHAT_WINDOWS do
    local chatType = _G["ChatFrame" .. frameType]
        chatType:HookScript("OnHyperLinkEnter", ChatlinkTooltip_Show)
        chatType:HookScript("OnHyperLinkLeave", GameTooltip_Hide)   
end

This is my lua code so far, i then added a ModifiedClick binding to the bindings.xml:

<Bindings>
    <ModifiedClick action="COMPAREITEMS" default="SHIFT"/>
</Bindings>

But it doesn't work the proper way, i know that i miss something in my lua code to make it show properly.

If i hold down shift before i enter the link in the chat, the tooltip for both the one in chat and the one i have equipped shows.. However, if i'm at my link and i click shift, nothing happends. How can i make this possible, thanks?

[Phanx]

ItemRefTooltip:SetScript("OnTooltipSetItem", function(self, ...)
	if IsShiftKeyDown() then
		GameTooltip_ShowCompareItem(self, 1)
		self.comparing = true
	else
		self.comparing = nil
	end
end)

According to the code in tekKompare, you also need to have some extra hooks to prevent issues, since the ItemRefTooltip isn't really designed to work with compare tooltips:

ItemRefTooltip:SetScript("OnEnter", nil)
ItemRefTooltip:SetScript("OnLeave", nil)
ItemRefTooltip:SetScript("OnDragStart", function(self)
	ItemRefShoppingTooltip1:Hide()
	ItemRefShoppingTooltip2:Hide()
	ItemRefShoppingTooltip3:Hide()
	self:StartMoving()
end)
ItemRefTooltip:SetScript("OnDragStop", function(self)
	self:StopMovingOrSizing()
	ValidateFramePosition(self)
	if self.comparing then
		GameTooltip_ShowCompareItem(self, 1)
	end
end)

[Seerah]

If you hold shift while clicking on an item link in chat, there are new compare tips that will appear with it. They are called ItemRefShoppingTooltip1-3.

/edit: maybe I misunderstood - but I'll leave this here, since many people don't realize this is in the game

[Phanx]

He said the compare tooltips show up with Shift when hovering -- that's the behavior you're thinking of, Seerah. The problem he's having is getting them to show up with the tooltip that appears when you click on a link in chat -- that's the ItemRefTooltip, which doesn't support comparing by default.

[Seerah]

No, when you shift-click an item link in chat now, you get the compare tips attached to the regular itemreftooltip open on your screen. I found this recently when updating TipTop and added them to the addon to be skinned. They weren't in the game previously.