PTR BUG AnimationGroups

[zork]

I just tested it on the PTR and confirm that there is a bug with animationgroup rotations.

Preface:
I use the animation system to rotate textures and/or frames that have textures attached.
The rotation settings I'm using are: SetDegrees(360), SetLooping("REPEAT")
That makes the textures rotate infinitely.

Bug description:
When using rectangles the bug becomes clearly visible. The animation will fade every 90° or 180° and repop after another (but hidden) rotation of 90° or 180° depending on setting of SetDegrees.
What I found out so far is that SetDegrees is causing the bug.
If I'm using any value <= 90° it will work. But as soon as I go above 90° there will be a time where the animation will be faded. Duration and direction has no effect.
Using 360 degreens will make the animation fade for 180° while 180° will be visible.
Using any value between 90 and 360 will make the animation be visible for 90°.

This bug makes rotating frames infinitely impossible. At least for textures that do not repeat themself every 90°.
It will work for rings, and stuff but not for rectangles and such. (Galaxies in my case)

Testmod to show the bug: http://www.wowinterface.com/download...meRotater.html
SVN: http://code.google.com/p/rothui/sour.../rFrameRotater

Screenshots:
http://www.abload.de/img/wowscrnshot_100811_175cojz.jpg
http://www.abload.de/img/wowscrnshot_100811_175zpj8.jpg

[Saiket]

Rotation:SetRadians also causes this. It looks like rotating textures upside down is what makes them disappear. Even if you run multiple smaller rotations at once and they flip the texture over at some point, it will disappear then too.

Have you posted this to the PTR Bug Report forum yet?

[zork]

I think I tracked it down to a bug in the math functions. Textures disappear when using this:

function RotateTexture(self, degrees)
    local angle = math.rad(degrees)
    local cos, sin = math.cos(angle), math.sin(angle)
    self:SetTexCoord((sin - cos), -(cos + sin), -cos, -sin, sin, -cos, 0, 0)
end

Maybe some of the math functions are bugged.

Using 90° steps still works, so here is my workaround using an onFinshed script that rotates the texture 90° by hand and restart the animation. Works perfectly for me. But my rotateTexture function is using predefined values. Nothing that gets calculated.



Full solution

-- cfg
 
  local db = {
    [1] = {
      frame = {
        parent = UIParent,
        width = 100,
        height = 100,
        scale = 1,
        alpha = 0.5,
        level = 0,
        pos = { a1 = "CENTER", x = -120, y = -120, },
      },
      texture = {
        file = "Interface\\AddOns\\rFramerotater\\media\\rectangle",
        color = { r = 255/255, g = 255/255, b = 0/255, },
        blendmode = "BLEND", --ADD or BLEND
      },
      anim = {
        rotateframe = true, --rotateframe, if false rotates the texture only
        duration = 10, --how long should the rotation need to finish 360°
        direction = 0, --0 = counter-clockwise, 1 = clockwise
      },
    },
  }
 
  -- functions
 
  local ULx, ULy, LLx, LLy, URx, URy, LRx, LRy = 0,0,0,1,1,0,1,1
 
  local rotateTexture = function(self, degrees)
    if degrees == 0 then
      self:SetTexCoord(ULx, ULy, LLx, LLy, URx, URy, LRx, LRy) --0°
    elseif degrees == 90 then
      self:SetTexCoord(LLx, LLy, LRx, LRy, ULx, ULy, URx, URy) --90°
    elseif degrees == 180 then
      self:SetTexCoord(LRx, LRy, URx, URy, LLx, LLy, ULx, ULy) --180°
    elseif degrees == 270 then
      self:SetTexCoord(URx, URy, ULx, ULy, LRx, LRy, LLx, LLy) --270°
    end
  end
 
  function init(id)
 
    --config
    local cfg = db[id]
 
    --frame
    local h = CreateFrame("Frame",nil,cfg.frame.parent)
    h:SetHeight(cfg.frame.height)
    h:SetWidth(cfg.frame.width)
    h:SetPoint(cfg.frame.pos.a1,cfg.frame.pos.x,cfg.frame.pos.y)
    h:SetScale(cfg.frame.scale)
    h:SetAlpha(cfg.frame.alpha)
    h:SetFrameLevel(cfg.frame.level)
    --h.time = GetTime()
 
    --texture
    local t = h:CreateTexture(nil,"BACKGROUND")
    t:SetAllPoints(h)
    t:SetTexture(cfg.texture.file)
    t:SetBlendMode(cfg.texture.blendmode)
    t:SetVertexColor(cfg.texture.color.r,cfg.texture.color.g,cfg.texture.color.b)
    h.t = t
 
    --animation object
    local o = t
    if cfg.anim.rotateframe then
      o = h --frame is object to animate
    end
 
    --animationgroup
    local ag = o:CreateAnimationGroup()
    ag.t = t --keep reference to texture
    ag.direction = cfg.anim.direction
    ag.count = 0
 
    --animation
    local a1 = ag:CreateAnimation("Rotation")
    if cfg.anim.direction == 0 then
      a1:SetDegrees(90)
    else
      a1:SetDegrees(-90)
    end
    a1:SetDuration(cfg.anim.duration/(360/90))
    ag.a1 = a1
 
    --onfinished
    ag:SetScript("OnFinished", function(ag)
      if ag.direction == 0 then
        ag.count = ag.count-1
        if ag.count < 0 then ag.count = 3 end
      else
        ag.count = ag.count+1
        if ag.count > 3 then ag.count = 0 end
      end
      rotateTexture(ag.t,90*ag.count)
      ag:Play()
    end)
 
    --play
    ag:Play()
 
  end
 
  local a = CreateFrame("Frame")
  a:RegisterEvent("PLAYER_LOGIN")
  a:SetScript("OnEvent", function (self,event,...)
    for i,v in ipairs(db) do
      init(i)
    end
  end)

[Saiket]

Originally Posted by zork function RotateTexture(self, degrees)     local angle = math.rad(degrees)     local cos, sin = math.cos(angle), math.sin(angle)     self:SetTexCoord((sin - cos), -(cos + sin), -cos, -sin, sin, -cos, 0, 0) end Maybe some of the math functions are bugged.

This function worked fine for me. It rotates the image around the bottom-right corner of the texture region instead of its center though. Here's a version that rotates properly around the center of the texture:

--- Applies an affine transformation to this texture.
local function ApplyTransform( self, A, B, C, D, E, F )
  local Det = A * E - B * D;
  if ( Det == 0 ) then
    return self:Hide(); -- Scaled infinitely small
  end
  local AF, BF, CD, CE = A * F, B * F, C * D, C * E;
  
  local ULx, ULy = ( BF - CE ) / Det, ( CD - AF ) / Det;
  local LLx, LLy = ( BF - CE - B ) / Det, ( CD - AF + A ) / Det;
  local URx, URy = ( BF - CE + E ) / Det, ( CD - AF - D ) / Det;
  local LRx, LRy = ( BF - CE + E - B ) / Det, ( CD - AF - D + A ) / Det;
  
  -- Bounds to prevent "TexCoord out of range" errors
  if ( ULx < -1e4 ) then ULx = -1e4; elseif ( ULx > 1e4 ) then ULx = 1e4; end
  if ( ULy < -1e4 ) then ULy = -1e4; elseif ( ULy > 1e4 ) then ULy = 1e4; end
  if ( LLx < -1e4 ) then LLx = -1e4; elseif ( LLx > 1e4 ) then LLx = 1e4; end
  if ( LLy < -1e4 ) then LLy = -1e4; elseif ( LLy > 1e4 ) then LLy = 1e4; end
  if ( URx < -1e4 ) then URx = -1e4; elseif ( URx > 1e4 ) then URx = 1e4; end
  if ( URy < -1e4 ) then URy = -1e4; elseif ( URy > 1e4 ) then URy = 1e4; end
  if ( LRx < -1e4 ) then LRx = -1e4; elseif ( LRx > 1e4 ) then LRx = 1e4; end
  if ( LRy < -1e4 ) then LRy = -1e4; elseif ( LRy > 1e4 ) then LRy = 1e4; end
  
  self:Show();
  return self:SetTexCoord( ULx, ULy, LLx, LLy, URx, URy, LRx, LRy );
end
--- Rotates this texture around its center by Angle.
local function RotateTexture( self, Angle )
  local Cos, Sin = math.cos( Angle ), math.sin( Angle );
  ApplyTransform( self,
    Cos, Sin, ( Cos + Sin ) * -0.5 + 0.5,
    -Sin, Cos, ( Cos - Sin ) * -0.5 + 0.5
  );
end
--- Slowly rotates this frame's texture.
local function OnUpdate ( self, Elapsed )
  self.Elapsed = self.Elapsed + Elapsed;
  return RotateTexture( self.Texture, math.pi * self.Elapsed );
end
 
 
local Frame = CreateFrame( "Frame" );
Frame.Texture = Frame:CreateTexture();
Frame.Elapsed = 0;
 
Frame:SetSize( 128, 128 );
Frame:SetPoint( "CENTER" );
Frame.Texture:SetAllPoints();
Frame.Texture:SetTexture( [[Interface\MacroFrame\MacroFrame-Icon]] );
Frame:SetScript( "OnUpdate", OnUpdate );

Only the animation system's rotations are bugged; Lua's math library and SetTexCoord seem fine.

[zork]

Maybe they messed some of the SetTexCoord calculations. That can get pretty disturbing quickly.

[Iza]

Hi,
I'm having the same issue with my custom statusbars. It seems like if you set texture left and right or top and bottom coordinates to the same values (or even very close values) the opacity value of that texture seems to get binary (???), so values of 0 - 0.99 make the texture completely transparent and setting it to 1 completely opaque. That will persist even if you set texture coordinates to different values after. My statusbars always get values in range of 0-100, so code was like this:

	tBar["SetValue"] = function(self, aValue)
		if ((aValue or -1) < 0) then
			aValue = 0;
		elseif (aValue > 100) then
			aValue = 100;
		end

		self["value"] = aValue;
		aValue = aValue * 0.01;
		if (self["isInverted"]) then
			aValue = 1 - aValue;
		end

		if (1 == self["txOrient"]) then -- VUHDO_STATUSBAR_LEFT_TO_RIGHT
			self["texture"]:SetTexCoord(0, aValue, 0, 1);
			self["texture"]:SetPoint("BOTTOMRIGHT", self, "BOTTOMRIGHT", (aValue - 1) * self:GetWidth(), 0);

		elseif (2 == self["txOrient"]) then -- VUHDO_STATUSBAR_RIGHT_TO_LEFT
			self["texture"]:SetTexCoord(1 - aValue, 1, 0, 1);
			self["texture"]:SetPoint("BOTTOMLEFT", self, "BOTTOMLEFT", (1 - aValue) * self:GetWidth(), 0);

		elseif (3 == self["txOrient"]) then -- VUHDO_STATUSBAR_BOTTOM_TO_TOP
			self["texture"]:SetTexCoord(0, 1, 1 - aValue, 1);
			self["texture"]:SetPoint("TOPLEFT", self, "TOPLEFT", 0, (aValue - 1) * self:GetHeight());

		else --if (VUHDO_STATUSBAR_TOP_TO_BOTTOM == self["txOrient"]) then
			self["texture"]:SetTexCoord(0, 1, 0, aValue);
			self["texture"]:SetPoint("BOTTOMLEFT", self, "BOTTOMLEFT", 0, (1 - aValue) * self:GetHeight());
		end
	end

All I did was limiting the values so texture coordinate deltas wouldn't shrink below 0.00001 (tried out a bit):

	tBar["SetValue"] = function(self, aValue)
		if ((aValue or -1) < 0.001) then
			aValue = 0.001;
		elseif (aValue > 100) then
			aValue = 100;
		end

		self["value"] = aValue;
		aValue = aValue * 0.01;
		if (self["isInverted"]) then
			aValue = 1.00001 - aValue;
		end
...

and this did the trick for me...

Cheers,
Iza

[zork]

Bug has been fixed. Closed.