stun addon help

[vivi168]

hello, i'm trying to improve the already existing addon stunbar that normaly only support one spell :

name, rank, icon, count, dispelType, duration, expires, caster, isStealable, shouldConsolidate, spellID = UnitAura("target", "Cheap Shot", nil, "HARMFUL|TARGET")

i did this :

http://codeviewer.org/view/code:189c

but i'm having some problem with line 81

i think those are the bugs : when i cast cheap shot, the stunbar is executed twice or more, when there is already an harmful spell (not necessarily one of the five predefined stuns) on the target, the stunbar doesn't appear.

when it works, it works fine (but that's not very often)

can you help me with detecting the predefined stun spells that are running on the target ?

thanks

[kraftman]

1. Make sure your functions are local unless they really need to be global, creating a global function called "OnUpdate" is a bad idea.

2. Check out how the function UnitAura actually works: if you give it a spell name, it will tell you whether the spell is on the target or not, if you give it an index it will return the info for that index. In the case of the code you linked, you are always providing an index of 1, so it will query the first buff only, which is why the bar only works when the first buff is the stun.

[vivi168]

is there a mean to check every debuff on the target, and then check if one of them is among the stun pre-listed ?

[kraftman]

Originally Posted by vivi168 is there a mean to check every debuff on the target, and then check if one of them is among the stun pre-listed ?

yup, just do a for loop changing the value of i inside UnitAura each time, for example:

for i = 1, 16 do
local name = UnitAura("target", i)
if name == "name of buff i want to check" then
--do stuff i want to do
end
end

[vivi168]

that doesn't work, the bar doesn't appear.

[kraftman]

Originally Posted by vivi168 that doesn't work, the bar doesn't appear.

well it was just an example. can you post your new lua file?

[vivi168]

there : http://codeviewer.org/view/code:18a5

[daylesan]

if (expires == nil) then
   sbBarStatus:SetValue(0)
   sbBar:Hide()
 end

If I'm reading this right, the above is why you can't see the bar. The variable expires is nil because, being a local, it doesn't carry over into your OnUpdate function.

[vivi168]

even if i make expire non local, it's still doesn't work.