Got a problem comparing strings

SignOfDoom · 04-16-11, 12:24 PM

Hi
My AddOn does compare an yell message with a database of pre defined strings. The problem is that while fighting Anraphet, for example, the first yell, the long one, doesnt work, but hte other are working. Rajh on the other hand doesnt work at all and I dont have any idea why.
I dont get any LUA-Error if this occurs.

lua Code:

function bsp_hoo(bsp_stringcheck,bsp_datayeller)
 
    local bsp_datasoundfile
 
    if bsp_datayeller == "Anraphet" then
    print("ana")
        if bsp_stringcheck == L.anraphet[1] then
            bsp_datasoundfile=bsp_Database.anraphet[1]
        elseif bsp_stringcheck == L.anraphet[2] then
            bsp_datasoundfile=bsp_Database.anraphet[2]
        elseif bsp_stringcheck == L.anraphet[3] then
            bsp_datasoundfile=bsp_Database.anraphet[3]
        elseif bsp_stringcheck == L.anraphet[4] then
            bsp_datasoundfile=bsp_Database.anraphet[4]
        elseif bsp_stringcheck == L.anraphet[5] then
            bsp_datasoundfile=bsp_Database.anraphet[5]
        elseif bsp_stringcheck == L.anraphet[6] then
            bsp_datasoundfile=bsp_Database.anraphet[6]
        elseif bsp_stringcheck == L.anraphet[7] then
            bsp_datasoundfile=bsp_Database.anraphet[7]
        end
    elseif bsp_datayeller == "Rajh" then
        print("rajh")
        if bsp_stringcheck == L.rajh[1] then
            bsp_datasoundfile=bsp_Database.rajh[1]
        elseif bsp_stringcheck == L.rajh[2] then
            bsp_datasoundfile=bsp_Database.rajh[2]
        elseif bsp_stringcheck == L.rajh[3] then
            bsp_datasoundfile=bsp_Database.rajh[3]
        elseif bsp_stringcheck == L.rajh[4] then
            bsp_datasoundfile=bsp_Database.rajh[4]
        elseif bsp_stringcheck == L.rajh[5] then
            bsp_datasoundfile=bsp_Database.rajh[5]
 
        end
        end
    return bsp_datasoundfile;
end

This is the code wich choses what bsp_datasoundfile should contain.
I can see "ana" or "rajh" everytime one of them yells. but "bsp_datasoundfile" is nil

predefined:

lua Code:

--Part1
if not L then
    L={}
end
L.anraphet={
    [1]="Anraphet unit shutting down...";
    [2]="Purge of unauthorized entities commencing.";
    [3]="This unit has been activated outside normal operating protocols. Downloading new operational parameters. Download complete. Full unit self defense routines are now active. Destruction of foreign units in this system shall now commence.";
    [4]="Target Annihilated.";
    [5]="Purge Complete.";
    [6]="Alphabeams activated. Target tracking commencing.";
    [7]="Omega Stance activated. Annihilation of foreign unit is now imminent.";
};
L.rajh={
    [1]="Blazing rays of light, take me!";
    [2]="Defilers! Wretches! Fiends! Begone from here!";
    [3]="Can you feel it? The blessed warmth of the sun?";
    [4]="I send you to your deity.";
    [5]="I take this life as an offering!";
};
--Part 2
if not bsp_Database then
    bsp_Database={}
end
    bsp_Database.rajh={
        [1]="Sound\\Creature\\Rajh\\VO_HO_Rajh_Death01.ogg";
        [1]="Sound\\Creature\\Rajh\\VO_HO_Rajh_Engage01.ogg";
        [1]="Sound\\Creature\\Rajh\\VO_HO_Rajh_Event01.ogg";
        [1]="Sound\\Creature\\Rajh\\VO_HO_Rajh_Slay01.ogg";
        [1]="Sound\\Creature\\Rajh\\VO_HO_Rajh_Slay02.ogg";
    };
    bsp_Database.anraphet={
        [1]="Sound\\Creature\\Anraphet\\VO_HO_Anraphet_Death01.ogg";
        [2]="Sound\\Creature\\Anraphet\\VO_HO_Anraphet_Engage01.ogg";
        [3]="Sound\\Creature\\Anraphet\\VO_HO_Anraphet_Intro01.ogg";
        [4]="Sound\\Creature\\Anraphet\\VO_HO_Anraphet_Slay01.ogg";
        [5]="Sound\\Creature\\Anraphet\\VO_HO_Anraphet_Slay02.ogg";
        [6]="Sound\\Creature\\Anraphet\\VO_HO_Anraphet_Special01.ogg";
        [7]="Sound\\Creature\\Anraphet\\VO_HO_Anraphet_Special02.ogg";
        };

I checked everything double but cant sill find any mistake. I hope someone has an idea.

SDPhantom · 04-16-11, 02:30 PM

The first block of code, I don't see any problem with. From what you're describing, it's matching the mob, but none of the messages. Possible things to check would be spelling or spacing. The first few times you're checking a message against a stored string, you'll run into a few problems trying to get them to match so it'll work.

To clean it up a bit and possibly to expand, you should look into looping the check.

lua Code:

function bsp_hoo(msg,mob)
    mob=mob:lower();--  Change to a case-insensitive form
    if not bsp_Database[mob] or not L[mob] then return nil; end--   No data for mob
 
    for i,j in ipairs(L[mob]) do--  Loop through mob messages
        if msg==j then
            return bsp_Database[mob][i];--  Return with sound file
        end
    end
end

The second block of code, I'm noticing that all the keys for "Rajh" are all 1. To make it a little easier, if all the keys are sequential, you don't need to define them. Just make sure the order matches and they'll get the correct keys.

For example, these produce the same result.

lua Code:

tbl={
    [1]="a";
    [2]="b";
};

lua Code:

tbl={
    "a";
    "b";
};

Also, be mindful of other addons running as well that might interfere with your code. I would suggest breaking away from the L namespace and work with your own. This table is commonly used in Ace addons for localizations and changing the common format for your own may break other addons or cause yours to break due to conflicts.

SignOfDoom · 04-16-11, 02:36 PM

i didnt noticed that rajh had only "1s". I also thought about building in a for loop, but i think my way will be enough for the mooment. but this does not cause the problem.
i would just hear the same sound for every yell
this is the code wich uses these functions:

lua Code:

--File 1
bsp_prefix = "[BossSpeech]: "
local bsp_yellmessage
local bsp_yeller
local bsp_soundfilepath
 
--SLASH_clitracker1= "/bsp"
--SLASH_clitracker2= "/bsp"
 
local bsp_frame = CreateFrame("Frame")
bsp_frame:RegisterEvent("CHAT_MSG_MONSTER_YELL")
bsp_frame:RegisterEvent("ADDON_LOADED")
 
--SlashCmdList["clitracker"] = function(msg)
 
--end
 
local function bsp_onyell(bsp_yellmessage,bsp_yeller)
    --print("onyell")
    --print(bsp_yeller)
    --print(bsp_yellmessage)
    bsp_soundfilepath=bsp_getfromdata(bsp_yeller,bsp_yellmessage)
    print(bsp_soundfilepath)
    if bsp_soundfilepath ~= nil then
        --print(bsp_soundfilepath)
        PlaySoundFile(bsp_soundfilepath, "Master")
        bsp_soundfilepath = nil
        --print(bsp_soundfilepath)
    end
    --print("fertig")
end
 
local function bsp_handler(self, event, ...)
    --print("yell1")
    if event == "CHAT_MSG_MONSTER_YELL" then
        --print("yell")
        bsp_onyell((select(1,...)),(select(2,...)))
    elseif event == "ADDON_LOADED" then
        if select(1,...) == "BossSpeech" then
        end
    end
end
 
bsp_frame:SetScript("OnEvent", bsp_handler)

lua Code:

--File 2
function bsp_getfromdata(bsp_databaseryeller,bsp_datayellmessage)
    
    --------
    --CATA
    --------
    if GetRealZoneText() == "Blackrock Caverns" then
    --  print("richtige zone")
        bsp_datapath=bsp_brc(bsp_datayellmessage,bsp_databaseryeller)
    elseif  GetRealZoneText() == "Grim Batol" then
        bsp_datapath=bsp_gb(bsp_datayellmessage,bsp_databaseryeller)
    elseif  GetRealZoneText() == "Halls of Origination" then
        bsp_datapath=bsp_hoo(bsp_datayellmessage,bsp_databaseryeller)
--  elseif  GetRealZoneText() == "Lost City of the Tol'vir" then
--      bsp_datapath=bsp_lcott(bsp_datayellmessage,bsp_databaseryeller)
--  elseif  GetRealZoneText() == "Shadowfang Keep" then
--      bsp_datapath=bsp_sfk(bsp_datayellmessage,bsp_databaseryeller)
--  elseif  GetRealZoneText() == "The Deadmines" then
--      bsp_datapath=bsp_dm(bsp_datayellmessage,bsp_databaseryeller)
--  elseif  GetRealZoneText() == "The Stonecore" then
--      bsp_datapath=bsp_score(bsp_datayellmessage,bsp_databaseryeller)
--  elseif  GetRealZoneText() == "The Vortex Pinnacle" then
--      bsp_datapath=bsp_vortex(bsp_datayellmessage,bsp_databaseryeller)
--  elseif  GetRealZoneText() == "Throne of the Tides" then
--      bsp_datapath=bsp_tides(bsp_datayellmessage,bsp_databaseryeller)
    end
    
    --------"Hellfire Ramparts"
    --BC
    --------
    if GetRealZoneText() == "Hellfire Ramparts" then
    --  print("richtige zone")
        bsp_datapath=bsp_hfr(bsp_datayellmessage,bsp_databaseryeller)
    end
    return bsp_datapath;
end

I also sometimes get a problem in line 31. so that my addon doesnt scan for yells in hellfire ramparts. i doubleckecked the spelling. I also wrote an addon that saves all yells that are made, so i am sure the spelling is right

daylesan · 04-16-11, 02:55 PM

May i suggest a simpler code structure:

Lua Code:

L = {}
L["anraphet"] = {
     ["Anraphet unit shutting down..."] = "Sound\\Creature\\Anraphet\\VO_HO_Anraphet_Death01.ogg",
     ["Purge of unauthorized entities commencing."] = "Sound\\Creature\\Anraphet\\VO_HO_Anraphet_Engage01.ogg",
}
L["rajh"] = {
    -- similar stuff as above
}

The sound files can then be accessed as follows

Lua Code:

function bsp_hoo(bsp_stringcheck,bsp_datayeller)
     return L.bsp_datayeller.bsp_stringcheck
end

Though the function probably isn't even necessary anymore.

Edit: changed the L.rahj to L["rajh"] since it has to be a string.

SignOfDoom · 04-16-11, 05:03 PM

I still dont know what caused this problem but after i minimized the code (tanks to daylesan) everything i tested till now works.
Does someone know if there is a maximum lengh of a tabke key?

SDPhantom · 04-16-11, 05:45 PM

Originally Posted by SignOfDoom

Does someone know if there is a maximum lengh of a tabke key?

There shouldn't be.

Here's what I have so far:

localization.lua

lua Code:

local name,addon=...;
local locale=GetLocale();
 
if locale=="enGB" then
--  Example: Setup for British client
else
--  Default to US client
    addon.MobLocale={
        ["Halls of Origination"]={
            ["Anraphet"]={
                ["Anraphet unit shutting down..."]=
                    "Sound\\Creature\\Anraphet\\VO_HO_Anraphet_Death01.ogg";
                ["Purge of unauthorized entities commencing."]=
                    "Sound\\Creature\\Anraphet\\VO_HO_Anraphet_Engage01.ogg";
                ["This unit has been activated outside normal operating protocols. Downloading new operational parameters. Download complete. Full unit self defense routines are now active. Destruction of foreign units in this system shall now commence."]=
                    "Sound\\Creature\\Anraphet\\VO_HO_Anraphet_Intro01.ogg";
                ["Target Annihilated."]=
                    "Sound\\Creature\\Anraphet\\VO_HO_Anraphet_Slay01.ogg";
                ["Purge Complete."]=
                    "Sound\\Creature\\Anraphet\\VO_HO_Anraphet_Slay02.ogg";
                ["Alphabeams activated. Target tracking commencing."]=
                    "Sound\\Creature\\Anraphet\\VO_HO_Anraphet_Special01.ogg";
                ["Omega Stance activated. Annihilation of foreign unit is now imminent."]=
                    "Sound\\Creature\\Anraphet\\VO_HO_Anraphet_Special02.ogg";
            };
            ["Rajh"]={
                ["Blazing rays of light, take me!"]=
                    "Sound\\Creature\\Rajh\\VO_HO_Rajh_Death01.ogg";
                ["Defilers! Wretches! Fiends! Begone from here!"]=
                    "Sound\\Creature\\Rajh\\VO_HO_Rajh_Engage01.ogg";
                ["Can you feel it? The blessed warmth of the sun?"]=
                    "Sound\\Creature\\Rajh\\VO_HO_Rajh_Event01.ogg";
                ["I send you to your deity."]=
                    "Sound\\Creature\\Rajh\\VO_HO_Rajh_Slay01.ogg";
                ["I take this life as an offering!"]=
                    "Sound\\Creature\\Rajh\\VO_HO_Rajh_Slay02.ogg";
            };
        };
    }
end

bsp.lua

lua Code:

local name,addon=...;
local title=select(2,GetAddOnInfo(name));-- Localized title if set in ToC
 
local frame=CreateFrame("Frame");
frame:RegisterEvent("CHAT_MSG_MONSTER_YELL");
frame:SetScript("OnEvent",function(self,event,...)
--  You can add more events if you wish
    if event=="CHAT_MSG_MONSTER_YELL" then
        local zone,msg,mob=GetRealZoneText(),...;-- Note "..." will fill both msg and mob as long as it's last in the list
 
--      Table existance needs to be checked in this order or attempt to index nil error can be thrown
        if addon.MobLocale[zone] and addon.MobLocale[zone][mob] and addon.MobLocale[zone][mob][msg] then
            PlaySoundFile(addon.MobLocale[zone][mob][msg]);--   Play Sound
        end
    end
end);

This should work as long as all the strings match up.
Make sure you load localization.lua before bsp.lua.
This code has no global footprint and uses the shared table WoW creates specifically for your addon

SignOfDoom · 04-16-11, 06:07 PM

Originally Posted by SDPhantom

There shouldn't be.

Here's what I have so far:

localization.lua

lua Code:

local name,addon=...;
local locale=GetLocale();
 
if locale=="enGB" then
--  Example: Setup for British client
else
--  Default to US client
    addon.MobLocale={
        ["Halls of Origination"]={
            ["Anraphet"]={
                ["Anraphet unit shutting down..."]=
                    "Sound\\Creature\\Anraphet\\VO_HO_Anraphet_Death01.ogg";
                ["Purge of unauthorized entities commencing."]=
                    "Sound\\Creature\\Anraphet\\VO_HO_Anraphet_Engage01.ogg";
                ["This unit has been activated outside normal operating protocols. Downloading new operational parameters. Download complete. Full unit self defense routines are now active. Destruction of foreign units in this system shall now commence."]=
                    "Sound\\Creature\\Anraphet\\VO_HO_Anraphet_Intro01.ogg";
                ["Target Annihilated."]=
                    "Sound\\Creature\\Anraphet\\VO_HO_Anraphet_Slay01.ogg";
                ["Purge Complete."]=
                    "Sound\\Creature\\Anraphet\\VO_HO_Anraphet_Slay02.ogg";
                ["Alphabeams activated. Target tracking commencing."]=
                    "Sound\\Creature\\Anraphet\\VO_HO_Anraphet_Special01.ogg";
                ["Omega Stance activated. Annihilation of foreign unit is now imminent."]=
                    "Sound\\Creature\\Anraphet\\VO_HO_Anraphet_Special02.ogg";
            };
            ["Rajh"]={
                ["Blazing rays of light, take me!"]=
                    "Sound\\Creature\\Rajh\\VO_HO_Rajh_Death01.ogg";
                ["Defilers! Wretches! Fiends! Begone from here!"]=
                    "Sound\\Creature\\Rajh\\VO_HO_Rajh_Engage01.ogg";
                ["Can you feel it? The blessed warmth of the sun?"]=
                    "Sound\\Creature\\Rajh\\VO_HO_Rajh_Event01.ogg";
                ["I send you to your deity."]=
                    "Sound\\Creature\\Rajh\\VO_HO_Rajh_Slay01.ogg";
                ["I take this life as an offering!"]=
                    "Sound\\Creature\\Rajh\\VO_HO_Rajh_Slay02.ogg";
            };
        };
    }
end

bsp.lua

lua Code:

local name,addon=...;
local title=select(2,GetAddOnInfo(name));-- Localized title if set in ToC
 
local frame=CreateFrame("Frame");
frame:RegisterEvent("CHAT_MSG_MONSTER_YELL");
frame:SetScript("OnEvent",function(self,event,...)
--  You can add more events if you wish
    if event=="CHAT_MSG_MONSTER_YELL" then
        local zone,msg,mob=GetRealZoneText(),...;-- Note "..." will fill both msg and mob as long as it's last in the list
 
--      Table existance needs to be checked in this order or attempt to index nil error can be thrown
        if addon.MobLocale[zone] and addon.MobLocale[zone][mob] and addon.MobLocale[zone][mob][msg] then
            PlaySoundFile(addon.MobLocale[zone][mob][msg]);--   Play Sound
        end
    end
end);

This should work as long as all the strings match up.
Make sure you load localization.lua before bsp.lua.
This code has no global footprint and uses the shared table WoW creates specifically for your addon

Thanks for your help. I think everything works now.