Saving values to different tables in a loop.

Niketa · 07-31-13, 01:53 AM

I'm trying to go through each mount a player has and add that to a table "flying", "ground" or "aquatic" within the table "mounts". With the code I currently have it, it doesn't add them to a table.

However, if I take out the bit of code to add to ground or aquatic (the elseifs) and have it just add to the flying table it works just fine (and I don't think it's just the flying in particular, but rather I can only add to one sub-table rather than multiple ones).

Is there an error in my code or is it just not possible with this approach?

Lua Code:

local mounts = {}
    mounts.flying = {}
    mounts.ground = {}
    mounts.aquatic = {}
 
local amount = GetNumCompanions("mount")
 
local f, g, a = 1
 
for i = 1, amount do
    local creatureID, creatureName, creatureSpellID, icon, issummoned, mountType = GetCompanionInfo("mount",i)
    
    if mountType == 7 or mountType == 15 or mountType == 23 or mountType == 31 then
        mounts.flying[f] = {creatureID, creatureName, creatureSpellID, icon, issummoned, mountType}
        --print(mounts.flying[f][2])
        f = f + 1
    elseif mountType == 29 then
        mounts.ground[g] = {creatureID, creatureName, creatureSpellID, icon, issummoned, mountType}
        --print(mounts.ground[g][2])
        g = g + 1
    elseif mountType == 12 then
        mounts.aquatic[a] = {creatureID, creatureName, creatureSpellID, icon, issummoned, mountType}
        --print(mounts.aquatic[a][2])
        a = a + 1
    end
end

Malsomnus · 07-31-13, 02:19 AM

First thing that pops up for me is the line:

Lua Code:

local f, g, a = 1

Is it possible that what you meant to write is

Lua Code:

local f, g, a = 1, 1, 1

?

[Edit]
It really looks like lines 18, 20, 22 and 24 should complain about indexing/ arithmetic with nil values. Do you get these errors?
Anyway instead of managing indexes you can just use:

Lua Code:

table.insert (mounts.flying, {creatureID, creatureName, creatureSpellID, icon, issummoned, mountType})

Phanx · 07-31-13, 03:02 AM

tinsert is definitely the way to go here. Keeping track of the indices yourself is just masochistic.

Also, the mountType returned by GetCompanionInfo is a bitfield, not a decimal value, so rather than trying to account for all possible combinations, you should just use bit operators to check the specific flags you're interested in:

Code:

if bit.band(mountType, 0x8) ~= 0 then
    -- aquatic
elseif bit.band(mountType, 0x2) ~= 0 then
    -- flying
elseif bit.band(mountType, 0x1) ~= 0 then
   -- ground
end

The order is fairly important, as mounts can be flagged as flying and ground, for example; the above prioritizes any flight-capable mount as a flying mount, so it will only consider mounts to be ground mounts if they can't fly.

On a side note, you're creating your mounts table in the least efficient way possible. Instead of this:

Code:

local mounts = {}
    mounts.flying = {}
    mounts.ground = {}
    mounts.aquatic = {}

...do this:

Code:

local mounts = {
    flying = {},
    ground = {},
    aquatic = {}
}

Works out exactly the same, and doesn't cost all the extra lookups.

Niketa · 07-31-13, 04:12 PM

Thank you guys. Helpful as usual.

Niketa · 07-31-13, 11:49 PM

When I first log on the tables don't automatically populate and I have to /reload to get them to populate.

I've tried leaving the code outside of any event, tried PLAYER_LOGIN, PLAYER_ENTERING_WORLD and PLAYER_ALIVE.

Malsomnus · 08-01-13, 02:05 AM

Ah, I hate data that isn't available on PLAYER_ENTERING_WORLD. I've found myself several times putting such code in a function that gets called from OnUpdate after it counts a few seconds.
I'd love to hear if anybody knows a correct way of doing that

Phanx · 08-01-13, 02:20 AM

Post your entire code, please. Polling with an OnUpdate script is never the best way (or even a good way) to find out when some data becomes available.

Malsomnus · 08-01-13, 02:29 AM

Not polling, just waiting a few seconds. It seems to work consistently. I know it's horrible, I just haven't found any event that can actually tell me when certain data (e.g. my gear, my raid roster) is available, and it wouldn't surprise me if the same applies to mounts.

Niketa · 08-01-13, 07:14 AM

Lua Code:

SLASH_MOUNTAHOLIC1 = "/mountaholic"
 
function SlashCmdList.MOUNTAHOLIC(msg, editbox)
    if msg == "a" then -- aquatic
        Mountaholic_aquatic()
    elseif msg == "g" then -- ground
        Mountaholic_ground()
    elseif msg == "gf" then -- ground favorites
        Mountaholic_favground()
    elseif msg == "f" then -- flying
        Mountaholic_flying()
    elseif msg == "ff" then -- flying favorites
        Mountaholic_favflying()
    elseif msg == "v" then -- vendor
        Mountaholic_vendor()
    else
        InterfaceOptionsFrame_OpenToCategory(Mountaholic_Options)
    end
end
 
local mounts = {aquatic = {}, flying = {}, flyingf = {}, ground = {}, groundf = {}, vendor = {}}
local amount = GetNumCompanions("mount")
 
for i = 1, amount do
    local creatureID, creatureName, creatureSpellID, icon, issummoned, mountType = GetCompanionInfo("mount",i)
                        
    if creatureName == "Traveler's Tundra Mammoth" or creatureName == "Grand Expedition Yak" then
        tinsert(mounts.vendor, {i, creatureID, creatureName, creatureSpellID, icon, issummoned, mountType})
    end
                        
    if bit.band(mountType, 0x01) == 0 and bit.band(mountType, 0x02) == 0 and bit.band(mountType, 0x08) ~= 0 then
        tinsert(mounts.aquatic, {i, creatureID, creatureName, creatureSpellID, icon, issummoned, mountType})
    elseif bit.band(mountType, 0x02) ~= 0 then
        tinsert(mounts.flying, {i, creatureID, creatureName, creatureSpellID, icon, issummoned, mountType})
    elseif bit.band(mountType, 0x01) ~= 0 then
        tinsert(mounts.ground, {i, creatureID, creatureName, creatureSpellID, icon, issummoned, mountType})
    end
end
            
local sizea, sizef, sizeff, sizeg, sizegf, sizev = table.getn(mounts.aquatic), table.getn(mounts.flying), table.getn(mounts.flyingf), table.getn(mounts.ground), table.getn(mounts.groundf), table.getn(mounts.vendor)
 
 
function Mountaholic_aquatic() -- aquatic
    if not IsSwimming() then
        print("You can't use an aquatic mount here! Try this instead.")
        Mountaholic_flying()
    else
        local rand = mounts.aquatic[math.random(1, sizea)]
        CallCompanion("MOUNT",rand[1])
    end
end
 
function Mountaholic_flying() -- flying
    if not IsFlyableArea() then
        Mountaholic_ground()
    else
        local rand = mounts.flying[math.random(1, sizef)]
        CallCompanion("MOUNT",rand[1])
    end
end
 
function Mountaholic_ground() -- ground
    local rand = mounts.ground[math.random(1, sizeg)]
    CallCompanion("MOUNT",rand[1])
end
 
function Mountaholic_favflying() -- favorite flying
    if not IsFlyableArea() then
        Mountaholic_ground()
    elseif sizeff == 0 then
        print("You have no favorite flying mounts! Here, have a random one instead.")
        Mountaholic_flying()
    else    
        local rand = mounts.flyingf[math.random(1, sizeff)]
        CallCompanion("MOUNT",rand[1])
    end
end
 
function Mountaholic_favground() -- favorite ground
    if sizegf == 0 then
        print("You have no favorite ground mounts! Here, have a random one instead.")
        Mountaholic_ground()
    else    
        local rand = mounts.groundf[math.random(1, sizegf)]
        CallCompanion("MOUNT",rand[1])
    end
end
 
function Mountaholic_vendor() -- vendor
    local rand = mounts.vendor[math.random(1, sizev)]
    CallCompanion("MOUNT",rand[1])
end

myrroddin · 08-01-13, 07:41 AM

To work on clients other than English, use the CreatureID instead of the CreatureName. Also, there are two Mammoths, one per faction. Change the following code accordingly:

Lua Code:

local AllianceMammoth = 61425 -- Alliance version of Traveler's Tundra Mammoth
local HordeMammoth = 61447 -- Horde version of Traveler's Tundra Mammoth
local GrandExpedYak = 122708 -- Grand Expedition Yak
 
for i = 1, amount do -- should rename "amount" to "numMounts" for clarity...
    local creatureID, creatureName, creatureSpellID, icon, issummoned, mountType = GetCompanionInfo("mount", i)
    if creatureID == (AllianceMammoth or HordeMammoth or GrandExpedYak) then
        tinsert(mounts.vendor, {i, creatureID, creatureName, creatureSpellID, icon, issummoned, mountType})
    end
    
    -- rest of code
end

Phanx · 08-01-13, 05:02 PM

Based on the default UI's code, I would guess you should watch for COMPANION_LEARNED and COMPANION_UNLEARNED events to detect when the list of known mounts changes:

Code:

function MountJournal_OnLoad(self)
  self:RegisterEvent("COMPANION_LEARNED");
  self:RegisterEvent("COMPANION_UNLEARNED");
  self:RegisterEvent("COMPANION_UPDATE");
  self.ListScrollFrame.update = MountJournal_UpdateMountList;
  self.ListScrollFrame.scrollBar.doNotHide = true;
  HybridScrollFrame_CreateButtons(self.ListScrollFrame, "MountListButtonTemplate", 44, 0);
end
 
function MountJournal_OnEvent(self, event, ...)
  if ( event == "COMPANION_LEARNED" or event == "COMPANION_UNLEARNED" or event == "COMPANION_UPDATE" ) then
    local companionType = ...;
    if ( not companionType or companionType == "MOUNT" ) then
      if ( event ~= "COMPANION_UPDATE" ) then
        --Companion updates don't change who's on our list.
        MountJournal_DirtyList(self);
      end
      MountJournal_UpdateMountList();
      MountJournal_UpdateMountDisplay();
    end
  end
end

Niketa · 08-01-13, 09:52 PM

myrroddin, I followed your suggestion but you were watching creatureID when you defined the creatureSpellID so I switched that up.

Phanx, it looks like COMPANION_UPDATE did the trick to load them up when I first log in. Thanks.

Lua Code:

local events = CreateFrame("Frame")
local sizea, sizef, sizeff, sizeg, sizegf, sizev, mounts = nil, nil, nil, nil, nil, nil, nil
 
events:RegisterEvent("COMPANION_LEARNED")
events:RegisterEvent("COMPANION_UPDATE")
events:RegisterEvent("PLAYER_ENTERING_WORLD")
 
events:SetScript("OnEvent",function(self, event, ...)
    return self[event] and self[event](self, event, ...)
end)
 
function events:COMPANION_UPDATE(event, companionType)
    mounts = {aquatic = {}, flying = {}, flyingf = {}, ground = {}, groundf = {}, vendor = {}}
    local numMounts = GetNumCompanions("mount")
 
    for i = 1, numMounts do
        local creatureID, creatureName, creatureSpellID, icon, issummoned, mountType = GetCompanionInfo("mount",i)
        local AllianceMammoth, HordeMammoth, GrandExpedYak = 61425, 61447, 122708
                    
        if creatureSpellID == AllianceMammoth or creatureSpellID == HordeMammoth or creatureSpellID == GrandExpedYak then
            tinsert(mounts.vendor, {i, creatureID, creatureName, creatureSpellID, icon, issummoned, mountType})
        end
                                
        if bit.band(mountType, 0x01) == 0 and bit.band(mountType, 0x02) == 0 and bit.band(mountType, 0x08) ~= 0 then
            tinsert(mounts.aquatic, {i, creatureID, creatureName, creatureSpellID, icon, issummoned, mountType})
        elseif bit.band(mountType, 0x02) ~= 0 then
            tinsert(mounts.flying, {i, creatureID, creatureName, creatureSpellID, icon, issummoned, mountType})
        elseif bit.band(mountType, 0x01) ~= 0 then
            tinsert(mounts.ground, {i, creatureID, creatureName, creatureSpellID, icon, issummoned, mountType})
        end
    end
                    
    sizea, sizef, sizeff, sizeg, sizegf, sizev = table.getn(mounts.aquatic), table.getn(mounts.flying), table.getn(mounts.flyingf), table.getn(mounts.ground), table.getn(mounts.groundf), table.getn(mounts.vendor)
        
    self:UnregisterEvent("COMPANION_UPDATE")
end
 
events.PLAYER_ENTERING_WORLD = events.COMPANION_UPDATE

myrroddin · 08-02-13, 04:47 PM

Ah, I did not know I was looking up the creatureSpellID when I hit WowHead, sorry! One more suggestion: move the variable definition outside the for loop. Right now you are (re)defining the variables on every loop, creating unnecessary garbage collection and a great deal of inefficiency.

Lua Code:

local AllianceMammoth, HordeMammoth, GrandExpedYak = 61425, 61447, 122708
for i = 1, numMounts do
    if creatureSpellID == AllianceMammoth or creatureSpellID == HordeMammoth or creatureSpellID == GrandExpedYak then
        tinsert(mounts.vendor, {i, creatureID, creatureName, creatureSpellID, icon, issummoned, mountType})
    end
end

I am wondering about the chained or code. Right now, you have

Lua Code:

if creatureSpellID == AllianceMammoth or creatureSpellID == HordeMammoth or creatureSpellID == GrandExpedYak then
    -- code
end

Is this not the same thing (psuedocode to make it shorter)? I'm musing about Lua, and if it works this way.

Lua Code:

if var == 1 or 2 or 3 then
    -- code
end
 
-- same as
if var == 1 or var == 2 or var == 3 then
    -- code
end

semlar · 08-02-13, 04:53 PM

Originally Posted by myrroddin

Lua Code:

if var == 1 or 2 or 3 then
    -- code
end

This is like saying..

Lua Code:

if var == 1 then
  -- code
elseif 2 then
  -- code
elseif 3 then
  -- code
end

myrroddin · 08-02-13, 05:01 PM

Semlar, that is what I thought. It would return true if var was equal to 1 or 2 or 3. You shouldn't have to keep checking if var, if var, if var... That seems overly verbose.

The reason I asked is because with two choices, it works fine.

Lua Code:

-- would be true for 1 or 2
if var == 1 or 2 then
 
-- so why can't it work the same way for more than two choices?
if var == 1 or 2 or 3

semlar · 08-02-13, 05:11 PM

I think maybe I wasn't clear.

You can't do "if var == 1 or 2 or 3", it's not the same as "if var == 1 or var == 2 or var == 3", it will always return true because "if 2" will always evaluate to true.

Phanx · 08-02-13, 07:03 PM

Originally Posted by myrroddin

Right now you are (re)defining the variables on every loop, creating unnecessary garbage collection and a great deal of inefficiency.

Lua Code:

local AllianceMammoth, HordeMammoth, GrandExpedYak = 61425, 61447, 122708
for i = 1, numMounts do
    if creatureSpellID == AllianceMammoth or creatureSpellID == HordeMammoth or creatureSpellID == GrandExpedYak then
        tinsert(mounts.vendor, {i, creatureID, creatureName, creatureSpellID, icon, issummoned, mountType})
    end
end

Only the first line in the code you quoted creates variables that could be defined at the file level. The other 3 lines must be done inside the loop over all of the player's mounts, as all the variables it references do not exist outside the loop.

However, redefining 3 number values whenever COMPANION_UPDATE fires is hardly "a great deal of inefficiency", especially for the purposes of a beginner still trying to figure out the basic logic.

Phanx · 08-02-13, 07:06 PM

Originally Posted by semlar

You can't do "if var == 1 or 2 or 3", it's not the same as "if var == 1 or var == 2 or var == 3", it will always return true because "if 2" will always evaluate to true.

To clarify even further:

Code:

if var == 1 or 2 or 3 then
   -- do X
end

Is functionally identical to:

Code:

if var == 1 then
   -- do x
elseif 2 then
   -- do x
elseif 3 then
   -- do x
end

It is NOT the same as:

Code:

if var == 1 then
   -- do x
elseif var == 2 then
   -- do x
elseif var == 3 then
   -- do x
end

If you want to do that third thing in one go, you need to write it this way:

Code:

if var == 1 or var == 2 or var == 3 then
   -- do x
end

Niketa · 08-02-13, 10:35 PM

Actually he's right. The code he quoted was his correction. I had the mammoths defined *inside* the loop, meaning for each mount I kept defining the mammoths, not for each COMPANION_UPDATE. I've fixed that. Also the COMPANION_UPDATE should only ever run once when logging in... and that same code only ever gets run again on PLAYER_ENTERING_WORLD so really it shouldn't be happening all that often.

Btw, just want to say thank you all for the help. There aren't any real good tutorials for lua/WoW addons so having you guys here is very helpful. Hopefully eventually I'll start thinking of these things so you guys don't have to tell me. ><

myrroddin · 08-03-13, 02:20 AM

Niketa, glad you have it working!

Semlar and Phanx, thank you for the clarifications! I was looking for a syntactic shortcut where none exists. Strangely, I have has to validate if more than one var == something, but thus far in any code I've written have I had to validate one var against multiple values. Odd that, but now I know.