Fonts and ActionButtons

[p3lim]

For as long as I can remember, my actionbar skinning addon has had this issue where it doesn't want to replace the font on ActionButtonN on the first client startup.

Here is what I use:

local FONT = [[Interface\AddOns\MyAddon\font.ttf]]
for index = 1, NUM_ACTIONBAR_BUTTONS do
    _G['ActionButton' .. index .. 'HotKey']:SetFont(FONT, 8)
end

When I start the client and log in to a character, this will do nothing. Running :GetFont() shows the default font (ARIALN.ttf), size and flags.

This issue only occurs on ActionButtonN, it works fine on the other buttons I skin (MultiBarBottomLeftButtonN etc).

If I /reload or relog (logging out to the character screen then logging in on any character) it works fine.

I've also tried delaying this to PLAYER_LOGIN and other later events without success.

Delaying it with an OnUpdate script past login works, but I don't know how long I have to wait, and it is not a good solution.

Setting the font to any of the other built-in fonts (like FRIZQT__.ttf) works fine.



So, I'm not sure what's causing this or how to fix it.

[Duugu]

Are you doing something with the SPELLS_CHANGED Event that could be causing that? As this event fires in an early phase during login (before PLAYER_LOGIN and PLAYER_ENTERING_WORLD) but not during an UI reload (both actions do fire SPELLS_CHANGED after PLAYER_LOGIN and PLAYER_ENTERING_WORLD).

[p3lim]

Originally Posted by Duugu Are you doing something with the SPELLS_CHANGED Event that could be causing that? As this event fires in an early phase during login (before PLAYER_LOGIN and PLAYER_ENTERING_WORLD) but not during an UI reload (both actions do fire SPELLS_CHANGED after PLAYER_LOGIN and PLAYER_ENTERING_WORLD).

I have no clue what you mean by that.

[sticklord]

Sounds to me like the font doesn't exist when you run SetFont() maybe? Better to make sure now than later

[Resike]

Originally Posted by p3lim For as long as I can remember, my actionbar skinning addon has had this issue where it doesn't want to replace the font on ActionButtonN on the first client startup. Here is what I use: local FONT = [[Interface\AddOns\MyAddon\font.ttf]] for index = 1, NUM_ACTIONBAR_BUTTONS do _G['ActionButton' .. index .. 'HotKey']:SetFont(FONT, 8) end When I start the client and log in to a character, this will do nothing. Running :GetFont() shows the default font (ARIALN.ttf), size and flags. This issue only occurs on ActionButtonN, it works fine on the other buttons I skin (MultiBarBottomLeftButtonN etc). If I /reload or relog (logging out to the character screen then logging in on any character) it works fine. I've also tried delaying this to PLAYER_LOGIN and other later events without success. Delaying it with an OnUpdate script past login works, but I don't know how long I have to wait, and it is not a good solution. Setting the font to any of the other built-in fonts (like FRIZQT__.ttf) works fine. So, I'm not sure what's causing this or how to fix it.

Have you tried waiting till the ADDON_LOADED event, the game might load the custom fonts there.

[Duugu]

The events on login are:

ADDON_LOADED xxx
ADDON_LOADED xxx
ADDON_LOADED xxx
SPELLS_CHANGED
ADDON LOADED Blizzard_TimeManager
ADDON LOADED Blizzard_CombatLog
PLAYER_LOGIN
ADDON_Loaded Blizzard_CombatText
PLAYER_ENERING_WORLD
SPELLS_CHANGED

The events on reload are:

ADDON_LOADED xxx
ADDON_LOADED xxx
ADDON_LOADED xxx
ADDON LOADED Blizzard_TimeManager
ADDON LOADED Blizzard_CombatLog
PLAYER_LOGIN
ADDON_Loaded Blizzard_CombatText
PLAYER_ENERING_WORLD
SPELLS_CHANGED

So, maybe you're doing something on SPELLS_CHANGED that fails if this event is triggered during login (as PLAYER_LOGIN and PLAYER_ENERING_WORLD are not triggered at this point), but is ok on reload as there's no additional SPELLS_CHANGED before the player has entered the world?

[p3lim]

Originally Posted by sticklord Sounds to me like the font doesn't exist when you run SetFont() maybe? Better to make sure now than later

I set it on all the other buttons in the same way at the same time, and they work just fine.

Originally Posted by Resike Have you tried waiting till the ADDON_LOADED event, the game might load the custom fonts there.

I've tried doing it on load and on every event part of the loading process, none of them work, and, as I previously mentioned, using OnUpdate to delay it by X amount of seconds it works, but it's bad practice.

Originally Posted by Duugu The events on login are: .. snip

And no, I'm not doing anything at that point, or at any point for that matter. That piece of code is the only thing in that addon right now, and that addon is the only one I load (I'm really trying to eliminate every possibility).

[sticklord]

Hm. I haven't noticed this problem. I'm skinning every actionbutton on PLAYER_LOGIN and also hooking "ActionButton_UpdateHotkeys" to set the font if it isn't already, and to change the displayed hotkey. But if you just need this once per startup of the game, I guess this isnt much better than an onupdate script.

[Duugu]

I've tested it with a single addon containing

local FONT = [[Interface\AddOns\test\STROKEYB.ttf]]
for index = 1, NUM_ACTIONBAR_BUTTONS do
    _G['ActionButton' .. index .. 'HotKey']:SetFont(FONT, 20)
end

It's working on any scenario.

Does the problem persists with other fonts?

[ravagernl]

Unless you want to specifically target action button hotkeys, you can also change NumberFontNormalSmall instead:

local nfns, font, size
nfns = NumberFontNormalSmall
font, size = nfns:GetFont()
nfns:SetFont(font, size, 'OUTLINE')
nfns:SetShadowColor(0, 0, 0, 0)

That's CleanHotKey.

Or you can make it as simple as:

NumberFontNormalSmall:SetFont([[Interface\AddOns\MyAddon\font.ttf]], 8)

If the font is used elsewhere(ItemButtonTemplate, TargetDebuffFrameTemplate), I see that as an added bonus.

[p3lim]

I ended up reinstalling the game completely which seem to have fixed this.

[zork]

...what? That sounds odd.

I just wanted to post that I do the same in my button styler but delay the styling process until PLAYER_LOGIN. Never had any issues with it.