Frame show/hide in different function

Benalish · 12-16-12, 07:40 PM

In a function I created a frame called US_Frame1, and in this I created a checkbutton that shows or hides the frame. If I write the function in this way the frame is shown/hidden properly

Lua Code:

function SetEnabled(info, newValue)
UnitScanner_Settings["Bars"][self.CurrentBar]["enabled"] = newValue
if (newValue == true) then US_Frame1:Show()
else US_Frame1:Hide()
end
end

but if written in this manner does not work

Lua Code:

function SetEnabled(info, newValue)
UnitScanner_Settings["Bars"][self.CurrentBar]["enabled"] = newValue
local frm = "US_Frame" .. 1
if (newValue == true) then frm:Show()
else frm:Hide()
end
end

If I want show/hide the frame without writing the name (the frame to show/hide changes depending on the situation) how can I do?

suicidalkatt · 12-16-12, 07:48 PM

Please show your full code.

There are ways to optimize how you'd like to do this, but ultimately you'll want to use a function that passes the frame. Also, you'd definitely want to set that function to local and pass the 'self' frame whatever that may be. For example:

Lua Code:

local function SetEnabled(info, newValue, frame, self)
    UnitScanner_Settings["Bars"][self.CurrentBar]["enabled"] = newValue
    if frame and type(frame) == "table" then
        if (newValue == true) then frame:Show()
    else 
        frame:Hide()
    end
end

Alternatively you can use a indexed value on your checkbox button frame to indicate what frame to hide and assign it a general function and index itself.

Lua Code:

local function CheckboxOnClick(self)
    local enabled = self:GetChecked()
    local frame = _G[self.targetFrame] -- when creating the checkbox, you set this to the name of the frame you're wanting to hide.
    UnitScanner_Settings["Bars"][frame:GetName()]["enabled"] = enabled
    if enabled then
        frame:Show()
    else
        frame:Hide()
    end
end

Benalish · 12-16-12, 08:08 PM

The problem is that not a single frame that I would like to show or hide, but they are different. The frame that I want to hide is selected from a dropdown menu. The frames are created by this function

http://lua.nopaste.dk/p16108

and are shown/hidden by the function written above

Vrul · 12-16-12, 10:00 PM

Code:

function SetEnabled(info, newValue)
    UnitScanner_Settings["Bars"][self.CurrentBar]["enabled"] = newValue
    local frm = "US_Frame" .. 1
    if (newValue == true) then
        frm:Show()
    else
        frm:Hide()
    end
end

The reason that doesn't work is "frm" is assigned a string, you need to change it to get the actual object:

Code:

function SetEnabled(info, newValue)
    UnitScanner_Settings["Bars"][self.CurrentBar]["enabled"] = newValue
    local frm = _G["US_Frame" .. 1]
    if (newValue == true) then
        frm:Show()
    else
        frm:Hide()
    end
end

Choonstertwo · 12-24-12, 06:50 AM

On a side note, MoP added a Region:SetShown method, allowing you to replace this:

Code:

if conditions then
	frame:Show()
else
	frame:Hide()
end

With this:

Code:

frame:SetShown(conditions)

Where conditions is some expression like newValue == true.

I'm not sure whether SetShown accepts any true- or false-equivalent values like if statements do or only actual boolean true/false values.