Why did "Hero" stopped working?

the_agent_1 · 04-28-11, 03:43 AM

Hi guys! I'm sure not many of you know this addon:
http://wow.curse.com/downloads/wow-a...ails/hero.aspx

Me and my guildies are using it since... forever. Especially healers and tanks are quite taken and were really devastated when there was no msg and no "pling" sound anymore when cd's had been popped :-(

It's an quite old addon, but unitil 4.1 it worked totally fine and now it just stopped, not even a lua error pops up...
Unfortunately I'm not really into the lua stuff and I was wondering if anybody could take a look at the source code and find the probably super obvious flaw which prevents it from doing anything...

I'd really appreciate any kind of help... (maybe there's a 4.1 self fixing addons-thread or something like that? ^.^ usually there's just formating stuff they change)

Thanks in advance!

Dridzt · 04-28-11, 03:52 AM

4 Changes to Hero.lua needed.

Line numbers refer to the source from v2.01 on Curse.

Line 578

Code:

local eventType, hideCaster, sourceGUID, sourceName, sourceFlags, destGUID, destName, destFlags = select(2, ...)

Line 582

Code:

local _,spellName = select(10, ...)

Line 610

Code:

local _, spellName = select(10, ...)

Line 657

Code:

local _, spellName = select(10, ...)

Drycoded and untested but should work (I'm not using the addon myself)

the_agent_1 · 04-28-11, 09:32 AM

Thank you, sooo much! Consider yourself hero of the hour!!!
Works perfectly!

the_agent_1 · 04-28-11, 09:42 AM

One thing though, in case you can help me with that too...
For some reason instant spells that don't apply any kind of buff/debuff don't work... for example "Lay on Hands", any kind of taunts and stuff...
Any idea? ;-)

Cowmonster · 04-28-11, 10:32 AM

There are multiple types of sub-events in the unfiltered combatlog event. It is a separate sub-event for damage, heal, spell cast success, spell cast fail, interrupt, etc. I haven't looked at the source code, but if it doesn't play a sound or flash the screen or pop up some sort of other visual/audible alert then it probably just needs a few lines of code to tell it to do so in the case of another sub-event it was not previously coded to act upon.