Script help: Using /console screenshotFormat tga

[vereonix]

Hi, this is the first time I've tried to make an addon, and its been going fine until I tried to get this working:

/console screenshotFormat tga
/run TakeScreenshot()
/console screenshotFormat jpg

Of course this is it as in-game commands, but I can't seem to get it working as a script (and also these 3 lines don't work together in-game either, and I don't know why, as each on its own does).

TakeScreenshot() works in the script, but I can't figure out how to structure the others, as the in-game errors say expected "=" so I've tried:

screenshotFormat jpg()
screenshotFormat = jpg()
screenshotFormat = "jpg"()
SET screenshotFormat = "jpg"()

None of which seem to work :/

Also I should mention the parameters I've set for this to trigger work, as it works fine if I just have it set to take a screenshot, it is just the format changing.

[Resike]

Use this:

SetCVar("screenshotFormat", jpg) or SetCVar("screenshotFormat", tga)

Also you don't need to use the "/run" command from addons, just

TakeScreenshot()

[vereonix]

Hmmm

Originally Posted by Resike Use this: SetCVar("screenshotFormat ", jpg) or SetCVar("screenshotFormat ", tga)

Gives error "Couldn't find CVar named 'screenshotFormat '"

and yeah I know about the /run etc, that was just because I was testing them in game together.

[Phanx]

Originally Posted by Resike SetCVar("screenshotFormat ", jpg) or SetCVar("screenshotFormat ", tga)

You need quotes around the second arguments. As written, that code will look for variables named jpg or tga and pass their values to SetCVar -- which, unless you wrote local jpg = "jpg" before running that line, will most likely be nil because no variables by those names exist.

SetCVar("screenshotFormat", "jpg")

Originally Posted by vereonix Gives error "Couldn't find CVar named 'screenshotFormat '"

There is absolutely a CVar named "screenshotFormat". I'm looking at it in my Config.wtf file right now, and was able to /run SetCVar("screenshotFormat", "jpg") in-game without any issue. Fix the missing quotes as mentioned above, and then make sure you don't have a typo in the CVar name.

[Resike]

Originally Posted by Phanx You need quotes around the second arguments. As written, that code will look for variables named jpg or tga and pass their values to SetCVar -- which, unless you wrote local jpg = "jpg" before running that line, will most likely be nil because no variables by those names exist. SetCVar("screenshotFormat", "jpg")

Yeah i wasn't sure about that, since the config wtf is a plain text file, and i wasn't ingame either.

[p3lim]

Originally Posted by vereonix Hmmm Gives error "Couldn't find CVar named 'screenshotFormat '" and yeah I know about the /run etc, that was just because I was testing them in game together.

You have a space at the end, remove it.

[vereonix]

Originally Posted by p3lim You have a space at the end, remove it.

Ah yes, silly mistake thank you

and

Originally Posted by Phanx SetCVar("screenshotFormat", "jpg")

Now I get no errors, the ss is taken at the right time, but the format is jpg, just tested it without the change back to jpg code, and it seems to do the format code straight away, and only the ss when the IF is met, even though its all within the same section.

[Resike]

Try this one:

local event = CreateFrame("Frame", nil, UIParent)
event:RegisterEvent("SCREENSHOT_SUCCEEDED")
 
function TakeSSTga()
    SetCVar("screenshotFormat", "tga")
    TakeScreenshot()
end
 
local function ScreenShotOnEvent(self, event, ...)
    if event == "SCREENSHOT_SUCCEEDED" then
        SetCVar("screenshotFormat", "jpg")
    end
end
 
event:SetScript("OnEvent", ScreenShotOnEvent)