Help with filtering cooldown events.

[Brusalk]

Heya!

I've been stuck on this problem for a really long time now and I'm starting to get quite frustrated with this.

Basically, I want to (for ease of example) print to the chat frame when the following happens for a given spell:
1. Spell goes on cooldown (not GCD)
2. Spell's cooldown is reset (E. G: Mind Blast reset on Divine Insight proc)


I've been using the SPELL_COOLDOWN_UPDATE and SPELL_COOLDOWN_USABLE events to attempt to do this, but I can't get the cooldown reset part to function as I'd expect.

Does anyone have some code they've used in the past for this purpose, or know of an easy way to do this? I can share the code I have, but it's a bit complicated as it's for my real project and not this example functionality.

Thanks!
-Brusalk

[Phanx]

I don't have any code for you, but reset detection seems pretty straightforward... when the spell goes on cooldown, record the expected time the cooldown will finish. If it comes off cooldown before that time, it was reset by something. Granted, I don't do anything with cooldowns in any of my addons, but I can't think of any reason why that wouldn't work. If it doesn't, can you be more specific about what you've already tried, what worked, and what didn't?

[Brusalk]

Originally Posted by Phanx I don't have any code for you, but reset detection seems pretty straightforward... when the spell goes on cooldown, record the expected time the cooldown will finish. If it comes off cooldown before that time, it was reset by something. Granted, I don't do anything with cooldowns in any of my addons, but I can't think of any reason why that wouldn't work. If it doesn't, can you be more specific about what you've already tried, what worked, and what didn't?

Part of the problem is that it seems that COOLDOWN_USABLE doesn't always fire for a cooldown reset. I guess I may have to do an update script which is partially what I was trying to avoid.

We're raiding atm. I'll try and get some of my code readable/applicable to the example, or explain what I have after raid.

[semlar]

I don't know what SPELL_UPDATE_USABLE and SPELL_UPDATE_COOLDOWN actually represent, but NOTHING fires when a spell comes off of cooldown. There is no event you can watch for this.

Your options are either use an OnUpdate script or if you're only concerned about spells bound to action buttons you could probably get away with hooking the cooldown spinner being hidden before it completes.

Here's a not-that-small script that might help you with whatever it is you're doing.

local Cooldowns, RecentCasts = {}, {} -- [spellid] = endTime
local f = CreateFrame('frame')
f:SetScript('OnEvent', function(self, event, ...)
    if event == 'UNIT_SPELLCAST_SUCCEEDED' then
        local _, _, _, _, spellID = ...
        local baseCooldown = GetSpellBaseCooldown(spellID) or 0
        if baseCooldown > 0 then -- queue it up
            RecentCasts[spellID] = true
        end
    else
        local now = GetTime()
        for spellID, starTime in pairs(RecentCasts) do
            local start, duration = GetSpellCooldown(spellID)
            if duration > 2 then
                RecentCasts[spellID] = nil
                Cooldowns[spellID] = start + duration
            end
        end
    end
end)
f:RegisterEvent('UNIT_SPELLCAST_SUCCEEDED')
f:RegisterEvent('SPELL_UPDATE_COOLDOWN')
 
f:SetScript('OnUpdate', function()
    local now = GetTime()
    for spellID, endTime in pairs(Cooldowns) do
        if now >= endTime then -- cooldown finished normally
            Cooldowns[spellID] = nil
        else -- check if there's still a cooldown
            local start, duration = GetSpellCooldown(spellID)
            if now >= start + duration then -- cooldown finished sooner than expected
                Cooldowns[spellID] = nil
                print(spellID, (GetSpellLink(spellID)), 'had its cooldown reset?')
            end
        end
    end
end)

It watches for spell casts and puts them in a table to check on the next SPELL_UPDATE_COOLDOWN event, since the cooldown isn't available when UNIT_SPELLCAST_SUCCEEDED fires. Then it just loops through the cooldowns OnUpdate to see if they've ended early.

I thought it might be somewhat more efficient than just looping through the entire spellbook checking cooldown durations but I don't know, maybe you can come up with something better.

[Brusalk]

Originally Posted by semlar I don't know what SPELL_UPDATE_USABLE and SPELL_UPDATE_COOLDOWN actually represent, but NOTHING fires when a spell comes off of cooldown. There is no event you can watch for this. Your options are either use an OnUpdate script or if you're only concerned about spells bound to action buttons you could probably get away with hooking the cooldown spinner being hidden before it completes. Here's a not-that-small script that might help you with whatever it is you're doing. local Cooldowns, RecentCasts = {}, {} -- [spellid] = endTime local f = CreateFrame('frame') f:SetScript('OnEvent', function(self, event, ...)     if event == 'UNIT_SPELLCAST_SUCCEEDED' then         local _, _, _, _, spellID = ...         local baseCooldown = GetSpellBaseCooldown(spellID) or 0         if baseCooldown > 0 then -- queue it up             RecentCasts[spellID] = true         end     else         local now = GetTime()         for spellID, starTime in pairs(RecentCasts) do             local start, duration = GetSpellCooldown(spellID)             if duration > 2 then                 RecentCasts[spellID] = nil                 Cooldowns[spellID] = start + duration             end         end     end end) f:RegisterEvent('UNIT_SPELLCAST_SUCCEEDED') f:RegisterEvent('SPELL_UPDATE_COOLDOWN')   f:SetScript('OnUpdate', function()     local now = GetTime()     for spellID, endTime in pairs(Cooldowns) do         if now >= endTime then -- cooldown finished normally             Cooldowns[spellID] = nil         else -- check if there's still a cooldown             local start, duration = GetSpellCooldown(spellID)             if now >= start + duration then -- cooldown finished sooner than expected                 Cooldowns[spellID] = nil                 print(spellID, (GetSpellLink(spellID)), 'had its cooldown reset?')             end         end     end end) It watches for spell casts and puts them in a table to check on the next SPELL_UPDATE_COOLDOWN event, since the cooldown isn't available when UNIT_SPELLCAST_SUCCEEDED fires. Then it just loops through the cooldowns OnUpdate to see if they've ended early. I thought it might be somewhat more efficient than just looping through the entire spellbook checking cooldown durations but I don't know, maybe you can come up with something better.

I'll have to take a looksee a bit later on tonight.

I actually know the spellID to keep track of ahead of time so no looping is required.

[semlar]

I had this script start acting up after a while on my hunter, but I didn't have time to look into it too much. There might be a flaw in the logic somewhere.

It should be simpler if you already know which spells you want to watch though.

Strictly speaking, it should only require an OnUpdate script checking when the spell goes on cooldown and then keeping track of whether that cooldown changes.