Gradient Color Help

[Aftermathhqt]

Hi, i'm trying to gradient color my FPS/MS when its dropping but its not working that great!

Its either i only get it to either green or red..

A.ColorGradient = function(a, b, ...)
    local Percent
 
    if b == 0 then
        Percent = 0
    else
        Percent = a / b
    end
 
    if Percent >= 1 then
        local R, G, B = select(select("#", ...) - 2, ...)
 
        return R, G, B
    elseif Percent <= 0 then
        local R, G, B = ...
 
        return R, G, B
    end
 
    local Num = (select("#", ...) / 3)
    local Segment, RelPercent = modf(Percent * (Num - 1))
    local R1, G1, B1, R2, G2, B2 = select((Segment * 3) + 1, ...)
 
    return R1 + (R2 - R1) * RelPercent, G1 + (G2 - G1) * RelPercent, B1 + (B2 - B1) * RelPercent
end

A.RGBToHex = function(R, G, B)
    R = R <= 1 and R >= 0 and R or 0
    G = G <= 1 and G >= 0 and G or 0
    B = B <= 1 and B >= 0 and B or 0
 
    return format("|cff%02x%02x%02x", R * 255, G * 255, B * 255)
end

local AStatsFrame = CreateFrame("Frame", nil, UIParent)
AStatsFrame:SetSize(160, 50)
AStatsFrame:SetPoint("BOTTOMLEFT", UIParent, -35, -15.5)
 
local AStatsText = AStatsFrame:CreateFontString(nil, "OVERLAY")
AStatsText:SetPoint("CENTER", AStatsFrame, 0, 0)
AStatsText:SetFont(C.Media.Font2, 12, "THINOUTLINE")
AStatsText:SetShadowOffset(1, -1)
AStatsText:SetShadowColor(0,0,0)
AStatsText:SetTextColor(A.ClassColor.r, A.ClassColor.g, A.ClassColor.b)
 
local FPS = GetFramerate()
local MS = select(3, GetNetStats())
 
local FR, FG, FB = A.ColorGradient(FPS, 15, 100, .8, 0, .8, .8, 0, .8, 0, 0)
local MR, MG, MB = A.ColorGradient(MS, 1000, 100, .8, 0, .8, .8, 0, .8, 0, 0)
 
local ColorFPS = A.RGBToHex(FR, FG, FB)
local ColorMS = A.RGBToHex(MR, MG, MB)
 
local Int = 0
 
AStatsFrame:SetScript("OnUpdate", function(self, elapsed)
    Int = Int - elapsed
    if Int <= 0 then
 
        local FPS = GetFramerate()
        local MS = select(3, GetNetStats())
        
        --AStatsText:SetText(string.format("%s%d|r fps %s%d|r ms", ColorFPS(FPS), FPS, ColorLag(MS), MS))
        AStatsText:SetText(string.format("%s%d|r fps %s%d|r ms", ColorFPS, FPS, ColorMS, MS))
        
        Int = 1
    end
end)

[Lombra]

This function looks extremely convoluted and not very readable. I don't know if you wrote it yourself, but in any case you should really fix it. I'm pretty sure there's no reason to use ... here, and all it does it make it impossible for an external party to interpret the code. I'm not even going to try to understand it! Just define all the variables, for starters.

That being said, debugging is the first aid of programming! print the values on every line (or at least on two lines) where they change, and you should find out where the logic went wrong soon enough.

A.ColorGradient = function(a, b, ...)
    local Percent
 
    if b == 0 then
        Percent = 0
    else
        Percent = a / b
    end
 
    if Percent >= 1 then
        local R, G, B = select(select("#", ...) - 2, ...)
 
        return R, G, B
    elseif Percent <= 0 then
        local R, G, B = ...
 
        return R, G, B
    end
 
    local Num = (select("#", ...) / 3)
    local Segment, RelPercent = modf(Percent * (Num - 1))
    local R1, G1, B1, R2, G2, B2 = select((Segment * 3) + 1, ...)
 
    return R1 + (R2 - R1) * RelPercent, G1 + (G2 - G1) * RelPercent, B1 + (B2 - B1) * RelPercent
end

[Aftermathhqt]

Originally Posted by Lombra This function looks extremely convoluted and not very readable. I don't know if you wrote it yourself, but in any case you should really fix it. I'm pretty sure there's no reason to use ... here, and all it does it make it impossible for an external party to interpret the code. I'm not even going to try to understand it! Just define all the variables, for starters.

That's really arrogant of you, I didn't ask your opinion about the code. Why you even bother to post something..

[Ketho]

Game92, I honestly think Lombra is giving constructive feedback

[Lombra]

I bothered to post because I wanted to help you figure out how to troubleshoot things on your own, and also to make it easier for people to help you, which honestly is not easy with that function. Variables should have meaningful names, and by using ... you hide almost all parameters, making it very hard to follow the flow.

I can guarantee you that you will have forgotten what this code does before long:

    local Num = (select("#", ...) / 3)
    local Segment, RelPercent = modf(Percent * (Num - 1))
    local R1, G1, B1, R2, G2, B2 = select((Segment * 3) + 1, ...)
 
    return R1 + (R2 - R1) * RelPercent, G1 + (G2 - G1) * RelPercent, B1 + (B2 - B1) * RelPercent

If you refuse to take any of this to heart, then at least use this:

Originally Posted by Lombra That being said, debugging is the first aid of programming! print the values on every line (or at least on two lines) where they change, and you should find out where the logic went wrong soon enough.

Debugging is an extremely simple and useful method of troubleshooting. Everyone uses it.

For example, you could do something like this.

A.ColorGradient = function(a, b, ...)
    local Percent
 
    if b == 0 then
        Percent = 0
    else
        Percent = a / b
    end
 
    print(Percent) -- does the Percent value look fine here?
    if Percent >= 1 then
        local R, G, B = select(select("#", ...) - 2, ...)
 
        print(R, G, B) -- are these the expected color values?
        return R, G, B
    elseif Percent <= 0 then
        local R, G, B = ...
 
        print(R, G, B) -- are these the expected color values?
        return R, G, B
    end
 
    local Num = (select("#", ...) / 3)
    local Segment, RelPercent = modf(Percent * (Num - 1))
    local R1, G1, B1, R2, G2, B2 = select((Segment * 3) + 1, ...)
    print(R1, G1, B1, R2, G2, B2) -- are these the expected color values?
 
    return R1 + (R2 - R1) * RelPercent, G1 + (G2 - G1) * RelPercent, B1 + (B2 - B1) * RelPercent
end

Edit: I may have been needlessly hostile, and for that I apologize. I stand by my opinion that the function code is not at all readable, however. Don't use varargs (...) nor select unless you have a reason to do so, use meaningful variable names, and I would also say the last few lines are a bit too "mathy", but you may be forced to change that if you don't use varargs anyway, I suppose.

[Aftermathhqt]

Originally Posted by Lombra Edit: I may have been needlessly hostile, and for that I apologize. I stand by my opinion that the function code is not at all readable, however. Don't use varargs (...) nor select unless you have a reason to do so, use meaningful variable names, and I would also say the last few lines are a bit too "mathy", but you may be forced to change that if you don't use varargs anyway, I suppose.

No worries. Thanks for the tips though.

[zork]

You can do this with the ColorSelect frame. It has HSV colors.

local CS = CreateFrame("ColorSelect")
     
    --GetSmudgeColorRGB function
    --arg1: color table in RGB {r=0,g=0,b=0}
    --arg2: color table in RGB {r=1,g=1,b=1}
    --arg3: percentage 0-1
    function CS:GetSmudgeColorRGB(colorA,colorB,percentage)
      self:SetColorRGB(colorA.r, colorA.g, colorA.b)
      colorA.h, colorA.s, colorA.v = self:GetColorHSV()
      self:SetColorRGB(colorB.r, colorB.g, colorB.b)
      colorB.h, colorB.s, colorB.v = self:GetColorHSV()
      local colorC = {}
      --check if the angle between the two H values is > 180
      if abs(colorA.h-colorB.h) > 180 then
        local angle = (360-abs(colorA.h-colorB.h))*percentage
        if colorA.h < colorB.h then
          colorC.h = floor(colorA.h-angle)
          if colorC.h < 0 then
            colorC.h = 360+colorC.h
          end
        else
          colorC.h = floor(colorA.h+angle)
          if colorC.h > 360 then
            colorC.h = colorC.h-360
          end
        end
      else
        colorC.h = floor(colorA.h-(colorA.h-colorB.h)*percentage)
      end    
      colorC.s = colorA.s-(colorA.s-colorB.s)*percentage
      colorC.v = colorA.v-(colorA.v-colorB.v)*percentage
      self:SetColorHSV(colorC.h, colorC.s, colorC.v)
      colorC.r, colorC.g, colorC.b = self:GetColorRGB()
      return colorC
    end
     
    --GetSmudgeColorRGB function call
    local color = CS:GetSmudgeColorRGB({r=1,g=0,b=0}, {r=0,g=1,b=0}, 0.5)

http://www.wowinterface.com/download...lorSmudge.html

[Aftermathhqt]

Originally Posted by zork You can do this with the ColorSelect frame. It has HSV colors. local CS = CreateFrame("ColorSelect")           --GetSmudgeColorRGB function     --arg1: color table in RGB {r=0,g=0,b=0}     --arg2: color table in RGB {r=1,g=1,b=1}     --arg3: percentage 0-1     function CS:GetSmudgeColorRGB(colorA,colorB,percentage)       self:SetColorRGB(colorA.r, colorA.g, colorA.b)       colorA.h, colorA.s, colorA.v = self:GetColorHSV()       self:SetColorRGB(colorB.r, colorB.g, colorB.b)       colorB.h, colorB.s, colorB.v = self:GetColorHSV()       local colorC = {}       --check if the angle between the two H values is > 180       if abs(colorA.h-colorB.h) > 180 then         local angle = (360-abs(colorA.h-colorB.h))*percentage         if colorA.h < colorB.h then           colorC.h = floor(colorA.h-angle)           if colorC.h < 0 then             colorC.h = 360+colorC.h           end         else           colorC.h = floor(colorA.h+angle)           if colorC.h > 360 then             colorC.h = colorC.h-360           end         end       else         colorC.h = floor(colorA.h-(colorA.h-colorB.h)*percentage)       end           colorC.s = colorA.s-(colorA.s-colorB.s)*percentage       colorC.v = colorA.v-(colorA.v-colorB.v)*percentage       self:SetColorHSV(colorC.h, colorC.s, colorC.v)       colorC.r, colorC.g, colorC.b = self:GetColorRGB()       return colorC     end           --GetSmudgeColorRGB function call     local color = CS:GetSmudgeColorRGB({r=1,g=0,b=0}, {r=0,g=1,b=0}, 0.5) http://www.wowinterface.com/download...lorSmudge.html

Cheers, will try!