Redeemer fix?

[Maelynn]

I've been using Redeemer for a long time now, and I've loved the quotes it'd produce when ressing someone and the laughs it'd create.

Shame, really, that it has been broken for a while now and the author hasn't logged since the 9th of May.
The problems are related to the Shaman's Reincarnation and the Hunter's Revive Pet. As a Shaman, you get a lua error whenever you either try to use an ankh or when you release while the ankh is available. As a Hunter, you get a "pet name unknown!" message in /s whenever you try to revive your fallen pet.

Is there someone who'd be willing to look at it and make a quick fix for this addon? I know it's been done before for Archy, and I'd really like to be able to use this addon again on my Hunter and Shaman.

[SDPhantom]

If you open Redemer.lua in something like Notepad, find line 78. It should look like the following code below.
To find a line number in Notepad, you need to have Word Wrap turned off in the Format menu so you can turn on the status bar in the View menu. When done, this will show something like "Ln X, Col Y" at the bottom of the window, this would show the line number where "X" is.

	if (event == "COMBAT_LOG_EVENT_UNFILTERED") then
		local arg1, arg2, arg3, arg4, arg5, arg6, arg7, arg8 = ...;
		--[[DEFAULT_CHAT_FRAME:AddMessage(tostring(event));
		DEFAULT_CHAT_FRAME:AddMessage(tostring(arg2));
		DEFAULT_CHAT_FRAME:AddMessage(string.format("0x%x",tostring(arg8)));
		DEFAULT_CHAT_FRAME:AddMessage(tostring(arg7));
		]]--
		--if pet dies, gets pet's name
		if (arg2 == "UNIT_DIED") then
			if (arg8 == 0x1111) then
				PET_NAME = arg7;
			end
		end
	end

Change that block of code to look like this.

	if (event == "COMBAT_LOG_EVENT_UNFILTERED") then
		local arg1, arg2, arg3, arg4, arg5, arg6, arg7, arg8, arg9, arg10 = ...;
		--[[DEFAULT_CHAT_FRAME:AddMessage(tostring(event));
		DEFAULT_CHAT_FRAME:AddMessage(tostring(arg2));
		DEFAULT_CHAT_FRAME:AddMessage(string.format("0x%x",tostring(arg8)));
		DEFAULT_CHAT_FRAME:AddMessage(tostring(arg7));
		]]--
		--if pet dies, gets pet's name
		if (arg2 == "UNIT_DIED") then
			if (arg10 == 0x1111) then
				PET_NAME = arg9;
			end
		end
	end

That should fix the hunter. As for the error on the shaman, can you post the error?

[Maelynn]

I posted that error in the comment section of Redeemer on the 10th of April. The error is the same whether I ankh or release without using my available ankh.

Thanks for looking into this, I appreciate it.

[SDPhantom]

I haven't been able to get the error to pop up when testing the specific call it's making. Has this error still been going on recently?

[Maelynn]

Yes, just last week I noticed for the first time that it also appears when releasing while the ankh is off cd. But to be sure I just logged on to try it again, and got the error again:

Date: 2011-09-07 11:07:43 ID: 1 Error occured in: Global Count: 1 Message: ..\AddOns\Redeemer\Redeemer.lua line 124: bad argument #1 to 'random' (interval is empty) Debug: (tail call): ? [C]: ? [C]: random() Redeemer\Redeemer.lua:124: Redeemer_Quotes() Redeemer\Redeemer.lua:102: Redeemer_OnEvent() [string "*:OnEvent"]:1: [string "*:OnEvent"]:1 AddOns: <snip>

I have removed all the self-ressing quotes, because I don't particularly care for them and found them mostly confusing to other players. Maybe you don't get the error because you still have quotes in that section?

[SDPhantom]

Originally posted by Maelynn I had emptied the self-ressing part of the quote .lua, and it used to work just fine. However, lately I've been getting an error every time I use my Ankh: ...

It's running when the variable selfQuotes is empty, returning 0 as its length to random() and causing that error.
This would be a little hack, but put a null string into selfQuotes in RedeemerQuotes.lua. It should look something like this after you're done.

selfQuotes = {		--Used when self-rezzing, as from a soulstone
	"",
}

This will cause the addon to load the null string and try to send it. The following call to SendChatMessage() will do nothing, continuing without error.

[Maelynn]

I might just vaguely understand that. I think. Yay me.

Okay, so I made the changes you suggested and tested them. On my Shaman I no longer get errors, and my Hunters have finally learned the names of their pets again. Happy days. \o/

Thank you so much for fixing these errors. I'm sure other Redeemer users will be just as grateful as I am.