[Question] if, or, then statement

[laukond]

I am modifying nMinimap's tab code to only show AddOns above 50 memory when no modifer is held down, and AddOns below 50 memory when CTRL is held down. I called the 50 memory 'memoryThreshold' so I can easily configure it at the top.

if (IsAddOnLoaded(i)) and GetAddOnMemoryUsage(i)>memoryThreshold or (IsControlKeyDown()) and GetAddOnMemoryUsage(i)<memoryThreshold and IsAddOnLoaded(i) then

Currently what this does is it shows AddOns above the threshold when no modifier is held down (as intended), but when I hold CTRL it shows AddOns both above and below the threshold, instead of just below.

[semlar]

You need to group the conditions you want evaluated together using parentheses.

if IsAddOnLoaded(i)
and (IsControlKeyDown() and GetAddOnMemoryUsage(i) < memoryThreshold
or GetAddOnMemoryUsage(i) > memoryThreshold) then

Do not put parentheses around single functions because that adds some overhead to the operation. Doing (IsAddonLoaded(i)) is actually slower than just IsAddonLoaded(i).

[laukond]

Ahh of course, that makes sense. Thank you, Semlar

Edit: Bummer, it does not work or else I typed it in wrong.
Here's the whole function: http://pastebin.com/0K59Gp5C

[semlar]

Instead of just having (IsControlKeyDown() and GetAddOnMemoryUsage(i) < memoryThreshold) grouped it needs to be all of (IsControlKeyDown() and GetAddOnMemoryUsage(i) < memoryThreshold or GetAddOnMemoryUsage(i) > memoryThreshold).

If that doesn't work try this, which is more verbose but I don't think it should be necessary

if IsAddOnLoaded(i)
and ((IsControlKeyDown() and GetAddOnMemoryUsage(i) < memoryThreshold)
or (not IsControlKeyDown() and GetAddOnMemoryUsage(i) > memoryThreshold)) then

[laukond]

The last part worked for me.
Thanks.